authorgravatar for andrew@ziglang.orgAndrew Kelley <andrew@ziglang.org> 2026-06-25 12:55:41-07:00
committergravatar for andrew@ziglang.orgAndrew Kelley <andrew@ziglang.org> 2026-06-29 23:50:20-07:00
log0959167e8161b5b19c1ad836aa35778dc9357c17
tree1d9fc9ef028f72ebdbacad6b9549fbd356b52053
parent34d3bcb353ef34b3e87b12d6d3acd09110ea6d51

take advantage of std.mem.Allocator.print


11 files changed, 136 insertions(+), 165 deletions(-)

lib/compiler/Maker.zig+23-32
......@@ -21,7 +21,6 @@ const process = std.process;
2121const Color = std.zig.Color;
2222const EnvVar = std.zig.EnvVar;
2323const default_local_zig_cache_basename = std.zig.default_local_zig_cache_basename;
24const allocPrint = std.fmt.allocPrint;
2524const stringToEnum = std.meta.stringToEnum;
2625
2726const Fuzz = @import("Maker/Fuzz.zig");
......@@ -125,10 +124,10 @@ pub const CliModule = struct {
125124 if (mem.eql(u8, name, dep.name)) {
126125 argv.appendAssumeCapacity(dep.name);
127126 } else {
128 argv.appendAssumeCapacity(try allocPrint(arena, "{s}={s}", .{ name, dep.name }));
127 argv.appendAssumeCapacity(try arena.print("{s}={s}", .{ name, dep.name }));
129128 }
130129 }
131 argv.appendAssumeCapacity(try allocPrint(arena, "-M{s}={s}", .{ cm.name, cm.root_path }));
130 argv.appendAssumeCapacity(try arena.print("-M{s}={s}", .{ cm.name, cm.root_path }));
132131 }
133132};
134133
......@@ -278,7 +277,7 @@ pub fn main(init: process.Init.Minimal) !void {
278277 fatalWithHint("expected [auto|on|off] found {q}", .{next_arg});
279278
280279 try cached_passthru_configure.append(arena, @intCast(configure_argv.items.len));
281 configure_argv.appendAssumeCapacity(try allocPrint(arena, "--color={t}", .{color}));
280 configure_argv.appendAssumeCapacity(try arena.print("--color={t}", .{color}));
282281 } else if (mem.eql(u8, arg, "--cache-poison")) {
283282 cache_poison = .poisoned;
284283 configure_argv.appendAssumeCapacity("--cache-poison=poisoned");
......@@ -965,7 +964,7 @@ fn configure(graph: *Graph, options: ConfigureOptions) !ScannedConfig {
965964 try build_configurer_argv.appendSlice(gpa, &.{ "--libc", libc_file });
966965 }
967966 if (graph.reference_trace) |n| {
968 try build_configurer_argv.append(gpa, try allocPrint(arena, "-freference-trace={d}", .{n}));
967 try build_configurer_argv.append(gpa, try arena.print("-freference-trace={d}", .{n}));
969968 }
970969 if (graph.debug_compile_errors) {
971970 try build_configurer_argv.append(gpa, "--debug-compile-errors");
......@@ -973,7 +972,7 @@ fn configure(graph: *Graph, options: ConfigureOptions) !ScannedConfig {
973972 try build_configurer_argv.appendSlice(gpa, &.{
974973 "--dep", "@build", //
975974 "--dep", "@dependencies", //
976 try allocPrint(arena, "-Mroot={f}", .{configurer_root_src_path}), //
975 try arena.print("-Mroot={f}", .{configurer_root_src_path}), //
977976 });
978977
979978 // In the loop below, after doing the fetch operation, the argv will be
......@@ -1126,7 +1125,7 @@ fn configure(graph: *Graph, options: ConfigureOptions) !ScannedConfig {
11261125 const hex_digest = hh.final();
11271126 const dependencies_zig_path: Path = .{
11281127 .root_dir = graph.local_cache_root,
1129 .sub_path = try allocPrint(arena, "o/{s}/dependencies.zig", .{&hex_digest}),
1128 .sub_path = try arena.print("o/{s}/dependencies.zig", .{&hex_digest}),
11301129 };
11311130 var atomic_file = try dependencies_zig_path.root_dir.handle.createFileAtomic(
11321131 io,
......@@ -1195,12 +1194,12 @@ fn configure(graph: *Graph, options: ConfigureOptions) !ScannedConfig {
11951194 if (mem.eql(u8, name, sub.name)) {
11961195 build_configurer_argv.appendAssumeCapacity(sub.name);
11971196 } else {
1198 build_configurer_argv.appendAssumeCapacity(try allocPrint(arena, "{s}={s}", .{
1197 build_configurer_argv.appendAssumeCapacity(try arena.print("{s}={s}", .{
11991198 name, sub.name,
12001199 }));
12011200 }
12021201 }
1203 build_configurer_argv.appendAssumeCapacity(try allocPrint(arena, "-M{s}={s}/{s}", .{
1202 build_configurer_argv.appendAssumeCapacity(try arena.print("-M{s}={s}/{s}", .{
12041203 dep.name, dep.root_path, std.zig.build_zig_basename,
12051204 }));
12061205 }
......@@ -1219,7 +1218,7 @@ fn configure(graph: *Graph, options: ConfigureOptions) !ScannedConfig {
12191218 break :cp .{
12201219 .{
12211220 .root_dir = graph.local_cache_root,
1222 .sub_path = try allocPrint(arena, "c/{s}", .{&digest}),
1221 .sub_path = try arena.print("c/{s}", .{&digest}),
12231222 },
12241223 false,
12251224 };
......@@ -1326,7 +1325,7 @@ fn configure(graph: *Graph, options: ConfigureOptions) !ScannedConfig {
13261325 const digest = config_man.final();
13271326 const final_path: Path = .{
13281327 .root_dir = graph.local_cache_root,
1329 .sub_path = try allocPrint(arena, "c/{s}", .{&digest}),
1328 .sub_path = try arena.print("c/{s}", .{&digest}),
13301329 };
13311330 Io.Dir.rename(
13321331 config_tmp_path.root_dir.handle,
......@@ -1597,7 +1596,7 @@ fn cmdFetch(gpa: Allocator, graph: *Graph, args: []const []const u8) !void {
15971596 var saved_path_or_url = path_or_url;
15981597
15991598 if (fetch.latest_commit) |latest_commit| resolved: {
1600 const latest_commit_hex = try allocPrint(arena, "{f}", .{latest_commit});
1599 const latest_commit_hex = try arena.print("{f}", .{latest_commit});
16011600
16021601 var uri = try std.Uri.parse(path_or_url);
16031602
......@@ -1610,7 +1609,7 @@ fn cmdFetch(gpa: Allocator, graph: *Graph, args: []const []const u8) !void {
16101609 log.info("resolved ref {q} to commit {s}", .{ target_ref, latest_commit_hex });
16111610
16121611 // include the original refspec in a query parameter, could be used to check for updates
1613 uri.query = .{ .percent_encoded = try allocPrint(arena, "ref={f}", .{
1612 uri.query = .{ .percent_encoded = try arena.print("ref={f}", .{
16141613 std.fmt.alt(fragment, .formatEscaped),
16151614 }) };
16161615 } else {
......@@ -1621,12 +1620,12 @@ fn cmdFetch(gpa: Allocator, graph: *Graph, args: []const []const u8) !void {
16211620 uri.fragment = .{ .raw = latest_commit_hex };
16221621
16231622 switch (save) {
1624 .yes => saved_path_or_url = try allocPrint(arena, "{f}", .{uri}),
1623 .yes => saved_path_or_url = try arena.print("{f}", .{uri}),
16251624 .no, .exact => {}, // keep the original URL
16261625 }
16271626 }
16281627
1629 const new_node_init = try allocPrint(arena,
1628 const new_node_init = try arena.print(
16301629 \\.{{
16311630 \\ .url = "{f}",
16321631 \\ .hash = "{f}",
......@@ -1636,15 +1635,15 @@ fn cmdFetch(gpa: Allocator, graph: *Graph, args: []const []const u8) !void {
16361635 std.zig.fmtString(package_hash_slice),
16371636 });
16381637
1639 const new_node_text = try allocPrint(arena, ".{f} = {s},\n", .{
1638 const new_node_text = try arena.print(".{f} = {s},\n", .{
16401639 std.zig.fmtIdPU(name), new_node_init,
16411640 });
16421641
1643 const dependencies_init = try allocPrint(arena, ".{{\n {s} }}", .{
1642 const dependencies_init = try arena.print(".{{\n {s} }}", .{
16441643 new_node_text,
16451644 });
16461645
1647 const dependencies_text = try allocPrint(arena, ".dependencies = {s},\n", .{
1646 const dependencies_text = try arena.print(".dependencies = {s},\n", .{
16481647 dependencies_init,
16491648 });
16501649
......@@ -1661,16 +1660,8 @@ fn cmdFetch(gpa: Allocator, graph: *Graph, args: []const []const u8) !void {
16611660 }
16621661 }
16631662
1664 const location_replace = try allocPrint(
1665 arena,
1666 "\"{f}\"",
1667 .{std.zig.fmtString(saved_path_or_url)},
1668 );
1669 const hash_replace = try allocPrint(
1670 arena,
1671 "\"{f}\"",
1672 .{std.zig.fmtString(package_hash_slice)},
1673 );
1663 const location_replace = try arena.print("{q}", .{saved_path_or_url});
1664 const hash_replace = try arena.print("{q}", .{package_hash_slice});
16741665
16751666 log.warn("overwriting existing dependency named {q}", .{name});
16761667 try fixups.replace_nodes_with_string.put(gpa, dep.location_node, location_replace);
......@@ -3272,11 +3263,11 @@ pub fn installSymLinks(
32723263 const name = conf_comp.root_name.slice(c);
32733264
32743265 const filename_major_only, const filename_name_only = if (os_tag.isDarwin()) .{
3275 try allocPrint(arena, "lib{s}.{d}.dylib", .{ name, version.major }),
3276 try allocPrint(arena, "lib{s}.dylib", .{name}),
3266 try arena.print("lib{s}.{d}.dylib", .{ name, version.major }),
3267 try arena.print("lib{s}.dylib", .{name}),
32773268 } else .{
3278 try allocPrint(arena, "lib{s}.so.{d}", .{ name, version.major }),
3279 try allocPrint(arena, "lib{s}.so", .{name}),
3269 try arena.print("lib{s}.so.{d}", .{ name, version.major }),
3270 try arena.print("lib{s}.so", .{name}),
32803271 };
32813272
32823273 return installSymLinksInner(maker, arena, output_path, asking_step_index, filename_major_only, filename_name_only);
lib/compiler/Maker/Step/Compile.zig+27-34
......@@ -10,7 +10,6 @@ const Module = std.Build.Configuration.Module;
1010const Io = std.Io;
1111const Sha256 = std.crypto.hash.sha2.Sha256;
1212const assert = std.debug.assert;
13const allocPrint = std.fmt.allocPrint;
1413
1514const Step = @import("../Step.zig");
1615const Maker = @import("../../Maker.zig");
......@@ -179,7 +178,7 @@ fn lowerZigArgs(
179178 try zig_args.append(gpa, cmd);
180179
181180 if (graph.reference_trace) |some| {
182 try zig_args.append(gpa, try allocPrint(arena, "-freference-trace={d}", .{some}));
181 try zig_args.append(gpa, try arena.print("-freference-trace={d}", .{some}));
183182 }
184183 try addFlag(gpa, zig_args, "allow-so-scripts", conf_comp.flags2.allow_so_scripts.toBool() orelse graph.allow_so_scripts);
185184
......@@ -191,7 +190,7 @@ fn lowerZigArgs(
191190
192191 if (root_module.resolved_target.get(conf).?.query.unwrap()) |query| {
193192 if (query.get(conf).flags.object_format.unwrap()) |ofmt| {
194 try zig_args.append(gpa, try allocPrint(arena, "-ofmt={t}", .{ofmt}));
193 try zig_args.append(gpa, try arena.print("-ofmt={t}", .{ofmt}));
195194 }
196195 }
197196
......@@ -201,7 +200,7 @@ fn lowerZigArgs(
201200 .enabled => try zig_args.append(gpa, "-fentry"),
202201 .symbol_name => {
203202 const symbol_name = conf_comp.entry.value.?.slice(conf);
204 try zig_args.append(gpa, try allocPrint(arena, "-fentry={s}", .{symbol_name}));
203 try zig_args.append(gpa, try arena.print("-fentry={s}", .{symbol_name}));
205204 },
206205 }
207206
......@@ -210,7 +209,7 @@ fn lowerZigArgs(
210209 }
211210
212211 if (conf_comp.stack_size.value) |stack_size| {
213 try zig_args.appendSlice(gpa, &.{ "--stack", try allocPrint(arena, "{d}", .{stack_size}) });
212 try zig_args.appendSlice(gpa, &.{ "--stack", try arena.print("{d}", .{stack_size}) });
214213 }
215214
216215 try addBool(gpa, zig_args, "-ffuzz", fuzz);
......@@ -346,7 +345,7 @@ fn lowerZigArgs(
346345 else => |e| return e,
347346 }
348347 }
349 try zig_args.append(gpa, try allocPrint(arena, "{s}{s}", .{
348 try zig_args.append(gpa, try arena.print("{s}{s}", .{
350349 prefix, system_lib_name,
351350 }));
352351 }
......@@ -526,7 +525,7 @@ fn lowerZigArgs(
526525 if (mem.eql(u8, import_cli_name, name_slice)) {
527526 zig_args.appendAssumeCapacity(import_cli_name);
528527 } else {
529 zig_args.appendAssumeCapacity(try allocPrint(arena, "{s}={s}", .{
528 zig_args.appendAssumeCapacity(try arena.print("{s}={s}", .{
530529 name_slice, import_cli_name,
531530 }));
532531 }
......@@ -542,9 +541,9 @@ fn lowerZigArgs(
542541 try zig_args.ensureUnusedCapacity(gpa, 1);
543542 if (mod.root_source_file.unwrap()) |lp| {
544543 const src = try maker.resolveLazyPathIndexAbs(arena, lp, compile_index);
545 zig_args.appendAssumeCapacity(try allocPrint(arena, "-M{s}={s}", .{ module_cli_name, src }));
544 zig_args.appendAssumeCapacity(try arena.print("-M{s}={s}", .{ module_cli_name, src }));
546545 } else if (moduleNeedsCliArg(&mod, conf)) {
547 zig_args.appendAssumeCapacity(try allocPrint(arena, "-M{s}", .{module_cli_name}));
546 zig_args.appendAssumeCapacity(try arena.print("-M{s}", .{module_cli_name}));
548547 }
549548 }
550549 }
......@@ -583,7 +582,7 @@ fn lowerZigArgs(
583582
584583 if (conf_comp.image_base.value) |image_base| {
585584 (try zig_args.addManyAsArray(gpa, 2)).* = .{
586 "--image-base", try allocPrint(arena, "0x{x}", .{image_base}),
585 "--image-base", try arena.print("0x{x}", .{image_base}),
587586 };
588587 }
589588
......@@ -643,10 +642,10 @@ fn lowerZigArgs(
643642 if (!conf_comp.flags.link_z_relro) (try zig_args.addManyAsArray(gpa, 2)).* = .{ "-z", "norelro" };
644643 if (conf_comp.flags.link_z_lazy) (try zig_args.addManyAsArray(gpa, 2)).* = .{ "-z", "lazy" };
645644 if (conf_comp.link_z_common_page_size.value) |size| (try zig_args.addManyAsArray(gpa, 2)).* = .{
646 "-z", try allocPrint(arena, "common-page-size={d}", .{size}),
645 "-z", try arena.print("common-page-size={d}", .{size}),
647646 };
648647 if (conf_comp.link_z_max_page_size.value) |size| (try zig_args.addManyAsArray(gpa, 2)).* = .{
649 "-z", try allocPrint(arena, "max-page-size={d}", .{size}),
648 "-z", try arena.print("max-page-size={d}", .{size}),
650649 };
651650 if (conf_comp.flags.link_z_defs) (try zig_args.addManyAsArray(gpa, 2)).* = .{ "-z", "defs" };
652651
......@@ -667,7 +666,7 @@ fn lowerZigArgs(
667666 try zig_args.ensureUnusedCapacity(gpa, 1);
668667 if (graph.debug_compiler_runtime_libs) |mode| switch (mode) {
669668 .Debug => zig_args.appendAssumeCapacity("--debug-rt"),
670 else => zig_args.appendAssumeCapacity(try allocPrint(arena, "--debug-rt={t}", .{mode})),
669 else => zig_args.appendAssumeCapacity(try arena.print("--debug-rt={t}", .{mode})),
671670 };
672671
673672 {
......@@ -691,15 +690,9 @@ fn lowerZigArgs(
691690 const abi = root_module_target.flags.abi.unwrap().?;
692691 zig_args.addManyAsArrayAssumeCapacity(2).* = .{
693692 "-install_name",
694 if (conf_comp.install_name.value) |s| s.slice(conf) else try allocPrint(
695 arena,
696 "@rpath/{s}{s}{s}",
697 .{
698 os_tag.libPrefix(abi),
699 conf_comp.root_name.slice(conf),
700 os_tag.dynamicLibSuffix(),
701 },
702 ),
693 if (conf_comp.install_name.value) |s| s.slice(conf) else try arena.print("@rpath/{s}{s}{s}", .{
694 os_tag.libPrefix(abi), conf_comp.root_name.slice(conf), os_tag.dynamicLibSuffix(),
695 }),
703696 };
704697 }
705698 }
......@@ -712,12 +705,12 @@ fn lowerZigArgs(
712705 }
713706 if (conf_comp.pagezero_size.value) |pagezero_size| {
714707 (try zig_args.addManyAsArray(gpa, 2)).* = .{
715 "-pagezero_size", try allocPrint(arena, "{x}", .{pagezero_size}),
708 "-pagezero_size", try arena.print("{x}", .{pagezero_size}),
716709 };
717710 }
718711 if (conf_comp.headerpad_size.value) |headerpad_size| {
719712 (try zig_args.addManyAsArray(gpa, 2)).* = .{
720 "-headerpad", try allocPrint(arena, "{x}", .{headerpad_size}),
713 "-headerpad", try arena.print("{x}", .{headerpad_size}),
721714 };
722715 }
723716 try addBool(gpa, zig_args, "-headerpad_max_install_names", conf_comp.flags.headerpad_max_install_names);
......@@ -740,13 +733,13 @@ fn lowerZigArgs(
740733 {
741734 try zig_args.ensureUnusedCapacity(gpa, 4);
742735 if (conf_comp.initial_memory.value) |initial_memory| {
743 zig_args.appendAssumeCapacity(try allocPrint(arena, "--initial-memory={d}", .{initial_memory}));
736 zig_args.appendAssumeCapacity(try arena.print("--initial-memory={d}", .{initial_memory}));
744737 }
745738 if (conf_comp.max_memory.value) |max_memory| {
746 zig_args.appendAssumeCapacity(try allocPrint(arena, "--max-memory={d}", .{max_memory}));
739 zig_args.appendAssumeCapacity(try arena.print("--max-memory={d}", .{max_memory}));
747740 }
748741 if (conf_comp.global_base.value) |global_base| {
749 zig_args.appendAssumeCapacity(try allocPrint(arena, "--global-base={d}", .{global_base}));
742 zig_args.appendAssumeCapacity(try arena.print("--global-base={d}", .{global_base}));
750743 }
751744 switch (conf_comp.flags3.wasi_exec_model) {
752745 .default => {},
......@@ -812,15 +805,15 @@ fn lowerZigArgs(
812805
813806 if (conf_comp.flags3.build_id.unwrap(conf_comp.build_id.value, conf) orelse graph.build_id) |build_id| {
814807 try zig_args.append(gpa, switch (build_id) {
815 .hexstring => |hs| try allocPrint(arena, "--build-id=0x{x}", .{hs.toSlice()}),
816 .none, .fast, .uuid, .sha1, .md5 => try allocPrint(arena, "--build-id={t}", .{build_id}),
808 .hexstring => |hs| try arena.print("--build-id=0x{x}", .{hs.toSlice()}),
809 .none, .fast, .uuid, .sha1, .md5 => try arena.print("--build-id={t}", .{build_id}),
817810 });
818811 }
819812
820813 const opt_zig_lib_dir: ?[]const u8 = if (conf_comp.zig_lib_dir.value) |dir|
821814 try maker.resolveLazyPathIndexAbs(arena, dir, compile_index)
822815 else if (graph.zig_lib_directory.path) |_|
823 try allocPrint(arena, "{f}", .{graph.zig_lib_directory})
816 try arena.print("{f}", .{graph.zig_lib_directory})
824817 else
825818 null;
826819
......@@ -848,7 +841,7 @@ fn lowerZigArgs(
848841 try addBool(gpa, zig_args, "-municode", conf_comp.flags.mingw_unicode_entry_point);
849842
850843 if (conf_comp.error_limit.value orelse graph.error_limit) |err_limit| (try zig_args.addManyAsArray(gpa, 2)).* = .{
851 "--error-limit", try allocPrint(arena, "{d}", .{err_limit}),
844 "--error-limit", try arena.print("{d}", .{err_limit}),
852845 };
853846
854847 try addFlag(gpa, zig_args, "incremental", conf_comp.flags4.incremental.toBool() orelse graph.incremental);
......@@ -1152,7 +1145,7 @@ const CliNamedModules = struct {
11521145 try result.modules.putNoClobber(arena, mod, {});
11531146 break;
11541147 }
1155 name = try allocPrint(arena, "{s}{d}", .{ orig_name_slice, n });
1148 name = try arena.print("{s}{d}", .{ orig_name_slice, n });
11561149 n += 1;
11571150 }
11581151 }
......@@ -1307,7 +1300,7 @@ fn appendModuleFlags(
13071300 }
13081301
13091302 for (m.export_symbol_names.slice) |symbol_name| {
1310 try zig_args.append(gpa, try allocPrint(arena, "--export={s}", .{symbol_name.slice(conf)}));
1303 try zig_args.append(gpa, try arena.print("--export={s}", .{symbol_name.slice(conf)}));
13111304 }
13121305
13131306 try zig_args.ensureUnusedCapacity(gpa, 2 * m.include_dirs.len);
......@@ -1375,7 +1368,7 @@ pub fn appendIncludeDirFlags(
13751368 zig_args.appendAssumeCapacity(try path.toString(arena));
13761369 },
13771370 .embed_path => |lazy_path| {
1378 zig_args.appendAssumeCapacity(try allocPrint(arena, "--embed-dir={f}", .{
1371 zig_args.appendAssumeCapacity(try arena.print("--embed-dir={f}", .{
13791372 try maker.resolveLazyPathIndex(arena, lazy_path, asking_step),
13801373 }));
13811374 },
lib/compiler/Maker/Step/ObjCopy.zig+9-10
......@@ -3,7 +3,6 @@ const ObjCopy = @This();
33const std = @import("std");
44const Io = std.Io;
55const Path = std.Build.Cache.Path;
6const allocPrint = std.fmt.allocPrint;
76const Configuration = std.Build.Configuration;
87
98const Step = @import("../Step.zig");
......@@ -55,7 +54,7 @@ pub fn make(
5554 .sub_path = try Io.Dir.path.join(arena, &.{ "o", &digest, basename }),
5655 };
5756 if (conf_oc.debug_file.value) |debug_file| {
58 const debug_basename = opt_debug_basename orelse try allocPrint(arena, "{s}.debug", .{
57 const debug_basename = opt_debug_basename orelse try arena.print("{s}.debug", .{
5958 Io.Dir.path.basename(input_path.sub_path),
6059 });
6160 maker.generatedPath(debug_file).* = .{
......@@ -92,7 +91,7 @@ pub fn make(
9291
9392 if (conf_oc.pad_to.value) |pad_to| {
9493 argv.addManyAsArrayAssumeCapacity(2).* = .{
95 "--pad-to", try allocPrint(arena, "{d}", .{pad_to}),
94 "--pad-to", try arena.print("{d}", .{pad_to}),
9695 };
9796 }
9897
......@@ -105,14 +104,14 @@ pub fn make(
105104 argv.appendAssumeCapacity("--compress-debug-sections");
106105
107106 if (conf_oc.debug_file.value) |debug_file| {
108 const debug_basename = opt_debug_basename orelse try allocPrint(arena, "{s}.debug", .{
107 const debug_basename = opt_debug_basename orelse try arena.print("{s}.debug", .{
109108 Io.Dir.path.basename(input_path.sub_path),
110109 });
111110 const debug_dest_path: Path = .{
112111 .root_dir = cache_root,
113112 .sub_path = try Io.Dir.path.join(arena, &.{ "o", &digest, debug_basename }),
114113 };
115 argv.appendAssumeCapacity(try allocPrint(arena, "--extract-to={f}", .{debug_dest_path}));
114 argv.appendAssumeCapacity(try arena.print("--extract-to={f}", .{debug_dest_path}));
116115 maker.generatedPath(debug_file).* = debug_dest_path;
117116 }
118117
......@@ -120,7 +119,7 @@ pub fn make(
120119
121120 for (conf_oc.add_section.slice) |section| {
122121 argv.appendAssumeCapacity("--add-section");
123 argv.appendAssumeCapacity(try allocPrint(arena, "{s}={f}", .{
122 argv.appendAssumeCapacity(try arena.print("{s}={f}", .{
124123 section.section_name.slice(conf),
125124 try maker.resolveLazyPathIndex(arena, section.file_path, step_index),
126125 }));
......@@ -133,14 +132,14 @@ pub fn make(
133132
134133 if (update.flags.alignment.toBytes()) |a| {
135134 argv.appendAssumeCapacity("--set-section-alignment");
136 argv.appendAssumeCapacity(try allocPrint(arena, "{s}={d}", .{ name, a }));
135 argv.appendAssumeCapacity(try arena.print("{s}={d}", .{ name, a }));
137136 }
138137
139138 const f = update.flags.section_flags;
140139 if (f != Configuration.Step.ObjCopy.SectionFlags.default) {
141140 // trailing comma is allowed
142141 argv.appendAssumeCapacity("--set-section-flags");
143 argv.appendAssumeCapacity(try allocPrint(arena, "{s}={s}{s}{s}{s}{s}{s}{s}{s}{s}", .{
142 argv.appendAssumeCapacity(try arena.print("{s}={s}{s}{s}{s}{s}{s}{s}{s}{s}", .{
144143 name,
145144 if (f.alloc) "alloc," else "",
146145 if (f.contents) "contents," else "",
......@@ -155,8 +154,8 @@ pub fn make(
155154 }
156155 }
157156
158 argv.appendAssumeCapacity(try allocPrint(arena, "{f}", .{input_path}));
159 argv.appendAssumeCapacity(try allocPrint(arena, "{f}", .{dest_path}));
157 argv.appendAssumeCapacity(try arena.print("{f}", .{input_path}));
158 argv.appendAssumeCapacity(try arena.print("{f}", .{dest_path}));
160159
161160 argv.appendAssumeCapacity("--listen=-");
162161 _ = Step.evalZigProcess(step_index, maker, argv.items, progress_node, false) catch |err| switch (err) {
lib/compiler/Maker/Step/Run.zig+6-7
......@@ -12,7 +12,6 @@ const Path = std.Build.Cache.Path;
1212const assert = std.debug.assert;
1313const mem = std.mem;
1414const process = std.process;
15const allocPrint = std.fmt.allocPrint;
1615const Allocator = std.mem.Allocator;
1716
1817const Step = @import("../Step.zig");
......@@ -196,8 +195,8 @@ pub fn make(
196195 const cache_dir_string = try convertPathArg(arena, run_index, maker, .{ .root_dir = cache_root }, false);
197196
198197 try argv_list.ensureUnusedCapacity(gpa, 3);
199 argv_list.appendAssumeCapacity(try allocPrint(arena, "--cache-dir={s}", .{cache_dir_string}));
200 argv_list.appendAssumeCapacity(try allocPrint(arena, "--seed=0x{x}", .{graph.random_seed}));
198 argv_list.appendAssumeCapacity(try arena.print("--cache-dir={s}", .{cache_dir_string}));
199 argv_list.appendAssumeCapacity(try arena.print("--seed=0x{x}", .{graph.random_seed}));
201200 argv_list.appendAssumeCapacity("--listen=-");
202201 }
203202
......@@ -1627,8 +1626,8 @@ pub fn rerunInFuzzMode(
16271626 const cache_dir_string = try convertPathArg(arena, run_index, maker, .{ .root_dir = cache_root }, false);
16281627
16291628 try argv_list.ensureUnusedCapacity(gpa, 3);
1630 argv_list.appendAssumeCapacity(try allocPrint(arena, "--cache-dir={s}", .{cache_dir_string}));
1631 argv_list.appendAssumeCapacity(try allocPrint(arena, "--seed=0x{x}", .{graph.random_seed}));
1629 argv_list.appendAssumeCapacity(try arena.print("--cache-dir={s}", .{cache_dir_string}));
1630 argv_list.appendAssumeCapacity(try arena.print("--seed=0x{x}", .{graph.random_seed}));
16321631 argv_list.appendAssumeCapacity("--listen=-");
16331632 }
16341633
......@@ -1925,7 +1924,7 @@ fn runCommand(
19251924 const path = try maker.resolveLazyPath(arena, lazy_path.get(conf), run_index);
19261925 path.root_dir.handle.createDirPath(io, path.subPathOrDot()) catch |e|
19271926 return step.fail(maker, "failed creating directory {f}: {t}", .{ path, e });
1928 interp_argv.appendAssumeCapacity(try allocPrint(arena, "--dir={f}::{s}", .{ path, name.slice(conf) }));
1927 interp_argv.appendAssumeCapacity(try arena.print("--dir={f}::{s}", .{ path, name.slice(conf) }));
19291928 }
19301929 // Wasmtime doeesn't inherit environment variables from the parent process
19311930 // by default. '-S inherit-env' was added in Wasmtime version 20.
......@@ -2479,7 +2478,7 @@ fn addPathForDynLibs(
24792478 const dll_path = try maker.generatedPath(conf_comp.generated_bin.value.?).toString(arena);
24802479 const search_path = Dir.path.dirname(dll_path).?;
24812480 if (environ_map.get(path_key)) |prev_path| {
2482 const new_path = try allocPrint(arena, "{s}{c}{s}", .{ prev_path, path_delimiter, search_path });
2481 const new_path = try arena.print("{s}{c}{s}", .{ prev_path, path_delimiter, search_path });
24832482 try environ_map.put(path_key, new_path);
24842483 } else {
24852484 try environ_map.put(path_key, search_path);
lib/compiler/Maker/Step/TranslateC.zig+3-4
......@@ -3,7 +3,6 @@ const TranslateC = @This();
33const std = @import("std");
44const Io = std.Io;
55const Configuration = std.Build.Configuration;
6const allocPrint = std.fmt.allocPrint;
76const assert = std.debug.assert;
87const OptimizeMode = std.lang.OptimizeMode;
98
......@@ -54,7 +53,7 @@ pub fn make(
5453 .fast => .ReleaseFast,
5554 .small => .ReleaseSmall,
5655 };
57 if (opt) |o| argv.appendAssumeCapacity(try allocPrint(arena, "-O{t}", .{o}));
56 if (opt) |o| argv.appendAssumeCapacity(try arena.print("-O{t}", .{o}));
5857
5958 try argv.ensureUnusedCapacity(arena, conf_tc.include_dirs.len * 2);
6059 for (0..conf_tc.include_dirs.len) |i|
......@@ -133,7 +132,7 @@ pub fn make(
133132 else => |e| return e,
134133 }
135134 }
136 try argv.append(arena, try allocPrint(arena, "{s}{s}", .{
135 try argv.append(arena, try arena.print("{s}{s}", .{
137136 prefix, system_lib_name,
138137 }));
139138 }
......@@ -151,7 +150,7 @@ pub fn make(
151150 }).?;
152151
153152 const stem = Io.Dir.path.stem(Io.Dir.path.basename(c_source_path));
154 const out_basename = try allocPrint(arena, "{s}.zig", .{stem});
153 const out_basename = try arena.print("{s}.zig", .{stem});
155154
156155 maker.generatedPath(conf_tc.output_file).* = try output_dir_path.join(arena, out_basename);
157156}
lib/compiler/Maker/Step/UpdateSourceFiles.zig-1
......@@ -3,7 +3,6 @@ const UpdateSourceFiles = @This();
33const std = @import("std");
44const Io = std.Io;
55const Path = std.Build.Cache.Path;
6const allocPrint = std.fmt.allocPrint;
76const Configuration = std.Build.Configuration;
87
98const Step = @import("../Step.zig");
lib/compiler/Maker/Step/WriteFile.zig-1
......@@ -4,7 +4,6 @@ const std = @import("std");
44const Io = std.Io;
55const assert = std.debug.assert;
66const Path = std.Build.Cache.Path;
7const allocPrint = std.fmt.allocPrint;
87const Configuration = std.Build.Configuration;
98
109const Step = @import("../Step.zig");
lib/std/Build/Step/ConfigHeader.zig+2-7
......@@ -5,7 +5,6 @@ const Io = std.Io;
55const Step = std.Build.Step;
66const Allocator = std.mem.Allocator;
77const Configuration = std.Build.Configuration;
8const allocPrint = std.fmt.allocPrint;
98
109step: Step,
1110values: std.array_hash_map.String(Value) = .empty,
......@@ -84,13 +83,9 @@ pub fn create(owner: *std.Build, options: Options) *ConfigHeader {
8483 };
8584
8685 const name = if (options.style.getPath()) |s|
87 allocPrint(arena, "configure {t} header {f} to {s}", .{
88 options.style, s, include_path,
89 }) catch @panic("OOM")
86 arena.print("configure {t} header {f} to {s}", .{ options.style, s, include_path }) catch @panic("OOM")
9087 else
91 allocPrint(arena, "configure {t} header to {s}", .{
92 options.style, include_path,
93 }) catch @panic("OOM");
88 arena.print("configure {t} header to {s}", .{ options.style, include_path }) catch @panic("OOM");
9489
9590 config_header.* = .{
9691 .step = .init(.{
lib/std/Build/Step/TranslateC.zig+1-2
......@@ -3,7 +3,6 @@ const TranslateC = @This();
33const std = @import("std");
44const fs = std.fs;
55const mem = std.mem;
6const allocPrint = std.fmt.allocPrint;
76const Step = std.Build.Step;
87const LazyPath = std.Build.LazyPath;
98const Configuration = std.Build.Configuration;
......@@ -158,7 +157,7 @@ pub fn defineCMacro(translate_c: *TranslateC, name: []const u8, value: ?[]const
158157 const graph = translate_c.step.owner.graph;
159158 const arena = graph.arena;
160159 const wc = &graph.wip_configuration;
161 const macro = allocPrint(arena, "{s}={s}", .{ name, value orelse "1" }) catch @panic("OOM");
160 const macro = arena.print("{s}={s}", .{ name, value orelse "1" }) catch @panic("OOM");
162161 const macro_string = wc.addString(macro) catch @panic("OOM");
163162 translate_c.c_macros.append(arena, macro_string) catch @panic("OOM");
164163}
src/link/Lld.zig+45-46
......@@ -436,23 +436,23 @@ fn coffLink(lld: *Lld, arena: Allocator) !void {
436436 try argv.append("-DEBUG");
437437
438438 const out_ext = std.fs.path.extension(full_out_path);
439 const out_pdb = coff.pdb_out_path orelse try allocPrint(arena, "{s}.pdb", .{
439 const out_pdb = coff.pdb_out_path orelse try arena.print("{s}.pdb", .{
440440 full_out_path[0 .. full_out_path.len - out_ext.len],
441441 });
442442 const out_pdb_basename = std.fs.path.basename(out_pdb);
443443
444 try argv.append(try allocPrint(arena, "-PDB:{s}", .{out_pdb}));
445 try argv.append(try allocPrint(arena, "-PDBALTPATH:{s}", .{out_pdb_basename}));
444 try argv.append(try arena.print("-PDB:{s}", .{out_pdb}));
445 try argv.append(try arena.print("-PDBALTPATH:{s}", .{out_pdb_basename}));
446446 }
447447 if (comp.version) |version| {
448 try argv.append(try allocPrint(arena, "-VERSION:{d}.{d}", .{ version.major, version.minor }));
448 try argv.append(try arena.print("-VERSION:{d}.{d}", .{ version.major, version.minor }));
449449 }
450450
451451 if (target_util.llvmMachineAbi(target)) |mabi| {
452 try argv.append(try allocPrint(arena, "-MLLVM:-target-abi={s}", .{mabi}));
452 try argv.append(try arena.print("-MLLVM:-target-abi={s}", .{mabi}));
453453 }
454454
455 try argv.append(try allocPrint(arena, "-MLLVM:-float-abi={s}", .{if (target.abi.float() == .hard) "hard" else "soft"}));
455 try argv.append(try arena.print("-MLLVM:-float-abi={s}", .{if (target.abi.float() == .hard) "hard" else "soft"}));
456456
457457 if (comp.config.lto != .none) {
458458 switch (optimize_mode) {
......@@ -462,9 +462,9 @@ fn coffLink(lld: *Lld, arena: Allocator) !void {
462462 }
463463 }
464464 if (comp.config.output_mode == .Exe) {
465 try argv.append(try allocPrint(arena, "-STACK:{d}", .{base.stack_size}));
465 try argv.append(try arena.print("-STACK:{d}", .{base.stack_size}));
466466 }
467 try argv.append(try allocPrint(arena, "-BASE:{d}", .{coff.image_base}));
467 try argv.append(try arena.print("-BASE:{d}", .{coff.image_base}));
468468
469469 switch (base.build_id) {
470470 .none => try argv.append("-BUILD-ID:NO"),
......@@ -483,7 +483,7 @@ fn coffLink(lld: *Lld, arena: Allocator) !void {
483483 }
484484
485485 for (comp.force_undefined_symbols.keys()) |symbol| {
486 try argv.append(try allocPrint(arena, "-INCLUDE:{s}", .{symbol}));
486 try argv.append(try arena.print("-INCLUDE:{s}", .{symbol}));
487487 }
488488
489489 if (is_dyn_lib) {
......@@ -491,7 +491,7 @@ fn coffLink(lld: *Lld, arena: Allocator) !void {
491491 }
492492
493493 if (entry_name) |name| {
494 try argv.append(try allocPrint(arena, "-ENTRY:{s}", .{name}));
494 try argv.append(try arena.print("-ENTRY:{s}", .{name}));
495495 }
496496
497497 if (coff.repro) {
......@@ -511,26 +511,26 @@ fn coffLink(lld: *Lld, arena: Allocator) !void {
511511 try argv.append("-FORCE:UNRESOLVED");
512512 }
513513
514 try argv.append(try allocPrint(arena, "-OUT:{s}", .{full_out_path}));
514 try argv.append(try arena.print("-OUT:{s}", .{full_out_path}));
515515
516516 if (comp.emit_implib) |raw_emit_path| {
517517 const path = try comp.resolveEmitPathFlush(arena, .artifact, raw_emit_path);
518 try argv.append(try allocPrint(arena, "-IMPLIB:{f}", .{path}));
518 try argv.append(try arena.print("-IMPLIB:{f}", .{path}));
519519 }
520520
521521 if (comp.config.link_libc) {
522522 if (comp.libc_installation) |libc_installation| {
523 try argv.append(try allocPrint(arena, "-LIBPATH:{s}", .{libc_installation.crt_dir.?}));
523 try argv.append(try arena.print("-LIBPATH:{s}", .{libc_installation.crt_dir.?}));
524524
525525 if (target.abi == .msvc or target.abi == .itanium) {
526 try argv.append(try allocPrint(arena, "-LIBPATH:{s}", .{libc_installation.msvc_lib_dir.?}));
527 try argv.append(try allocPrint(arena, "-LIBPATH:{s}", .{libc_installation.kernel32_lib_dir.?}));
526 try argv.append(try arena.print("-LIBPATH:{s}", .{libc_installation.msvc_lib_dir.?}));
527 try argv.append(try arena.print("-LIBPATH:{s}", .{libc_installation.kernel32_lib_dir.?}));
528528 }
529529 }
530530 }
531531
532532 for (coff.lib_directories) |lib_directory| {
533 try argv.append(try allocPrint(arena, "-LIBPATH:{s}", .{lib_directory.path orelse "."}));
533 try argv.append(try arena.print("-LIBPATH:{s}", .{lib_directory.path orelse "."}));
534534 }
535535
536536 try argv.ensureUnusedCapacity(comp.link_inputs.len);
......@@ -541,7 +541,7 @@ fn coffLink(lld: *Lld, arena: Allocator) !void {
541541 },
542542 .object, .archive => |obj| {
543543 if (obj.must_link) {
544 argv.appendAssumeCapacity(try allocPrint(arena, "-WHOLEARCHIVE:{f}", .{@as(Cache.Path, obj.path)}));
544 argv.appendAssumeCapacity(try arena.print("-WHOLEARCHIVE:{f}", .{@as(Cache.Path, obj.path)}));
545545 } else {
546546 argv.appendAssumeCapacity(try obj.path.toString(arena));
547547 }
......@@ -561,7 +561,7 @@ fn coffLink(lld: *Lld, arena: Allocator) !void {
561561 }
562562
563563 if (coff.module_definition_file) |def| {
564 try argv.append(try allocPrint(arena, "-DEF:{s}", .{def}));
564 try argv.append(try arena.print("-DEF:{s}", .{def}));
565565 }
566566
567567 const resolved_subsystem: ?std.zig.Subsystem = blk: {
......@@ -590,7 +590,7 @@ fn coffLink(lld: *Lld, arena: Allocator) !void {
590590 const Mode = enum { uefi, win32 };
591591 const mode: Mode = mode: {
592592 if (resolved_subsystem) |subsystem| {
593 try argv.append(try allocPrint(arena, "-SUBSYSTEM:{s},{d}.{d}", .{
593 try argv.append(try arena.print("-SUBSYSTEM:{s},{d}.{d}", .{
594594 @tagName(subsystem),
595595 coff.major_subsystem_version,
596596 coff.minor_subsystem_version,
......@@ -645,8 +645,8 @@ fn coffLink(lld: *Lld, arena: Allocator) !void {
645645 .static => "lib",
646646 .dynamic => "",
647647 };
648 try argv.append(try allocPrint(arena, "{s}vcruntime.lib", .{lib_str}));
649 try argv.append(try allocPrint(arena, "{s}ucrt.lib", .{lib_str}));
648 try argv.append(try arena.print("{s}vcruntime.lib", .{lib_str}));
649 try argv.append(try arena.print("{s}ucrt.lib", .{lib_str}));
650650
651651 //Visual C++ 2015 Conformance Changes
652652 //https://msdn.microsoft.com/en-us/library/bb531344.aspx
......@@ -712,7 +712,7 @@ fn coffLink(lld: *Lld, arena: Allocator) !void {
712712
713713 try argv.ensureUnusedCapacity(comp.windows_libs.count());
714714 for (comp.windows_libs.keys()) |key| {
715 const lib_basename = try allocPrint(arena, "{s}.lib", .{key});
715 const lib_basename = try arena.print("{s}.lib", .{key});
716716 if (comp.crt_files.get(lib_basename)) |crt_file| {
717717 argv.appendAssumeCapacity(try crt_file.full_object_path.toString(arena));
718718 continue;
......@@ -722,7 +722,7 @@ fn coffLink(lld: *Lld, arena: Allocator) !void {
722722 continue;
723723 }
724724 if (target.abi.isGnu()) {
725 const fallback_name = try allocPrint(arena, "lib{s}.dll.a", .{key});
725 const fallback_name = try arena.print("lib{s}.dll.a", .{key});
726726 if (try findLib(arena, io, fallback_name, coff.lib_directories)) |full_path| {
727727 argv.appendAssumeCapacity(full_path);
728728 continue;
......@@ -843,19 +843,19 @@ fn elfLink(lld: *Lld, arena: Allocator) !void {
843843 try argv.append("--error-limit=0");
844844
845845 if (comp.sysroot) |sysroot| {
846 try argv.append(try std.fmt.allocPrint(arena, "--sysroot={s}", .{sysroot}));
846 try argv.append(try arena.print("--sysroot={s}", .{sysroot}));
847847 }
848848
849849 if (target_util.llvmMachineAbi(target)) |mabi| {
850850 try argv.appendSlice(&.{
851851 "-mllvm",
852 try std.fmt.allocPrint(arena, "-target-abi={s}", .{mabi}),
852 try arena.print("-target-abi={s}", .{mabi}),
853853 });
854854 }
855855
856856 try argv.appendSlice(&.{
857857 "-mllvm",
858 try std.fmt.allocPrint(arena, "-float-abi={s}", .{if (target.abi.float() == .hard) "hard" else "soft"}),
858 try arena.print("-float-abi={s}", .{if (target.abi.float() == .hard) "hard" else "soft"}),
859859 });
860860
861861 switch (target.cpu.arch) {
......@@ -894,19 +894,19 @@ fn elfLink(lld: *Lld, arena: Allocator) !void {
894894 if (output_mode == .Exe) {
895895 try argv.appendSlice(&.{
896896 "-z",
897 try std.fmt.allocPrint(arena, "stack-size={d}", .{base.stack_size}),
897 try arena.print("stack-size={d}", .{base.stack_size}),
898898 });
899899 }
900900
901901 switch (base.build_id) {
902902 .none => try argv.append("--build-id=none"),
903 .fast, .uuid, .sha1, .md5 => try argv.append(try std.fmt.allocPrint(arena, "--build-id={s}", .{
903 .fast, .uuid, .sha1, .md5 => try argv.append(try arena.print("--build-id={s}", .{
904904 @tagName(base.build_id),
905905 })),
906 .hexstring => |hs| try argv.append(try std.fmt.allocPrint(arena, "--build-id=0x{x}", .{hs.toSlice()})),
906 .hexstring => |hs| try argv.append(try arena.print("--build-id=0x{x}", .{hs.toSlice()})),
907907 }
908908
909 try argv.append(try std.fmt.allocPrint(arena, "--image-base={d}", .{elf.image_base}));
909 try argv.append(try arena.print("--image-base={d}", .{elf.image_base}));
910910
911911 if (elf.linker_script) |linker_script| {
912912 try argv.append("-T");
......@@ -914,7 +914,7 @@ fn elfLink(lld: *Lld, arena: Allocator) !void {
914914 }
915915
916916 if (elf.sort_section) |how| {
917 const arg = try std.fmt.allocPrint(arena, "--sort-section={s}", .{@tagName(how)});
917 const arg = try arena.print("--sort-section={s}", .{@tagName(how)});
918918 try argv.append(arg);
919919 }
920920
......@@ -980,11 +980,11 @@ fn elfLink(lld: *Lld, arena: Allocator) !void {
980980 }
981981 if (elf.z_common_page_size) |size| {
982982 try argv.append("-z");
983 try argv.append(try std.fmt.allocPrint(arena, "common-page-size={d}", .{size}));
983 try argv.append(try arena.print("common-page-size={d}", .{size}));
984984 }
985985 if (elf.z_max_page_size) |size| {
986986 try argv.append("-z");
987 try argv.append(try std.fmt.allocPrint(arena, "max-page-size={d}", .{size}));
987 try argv.append(try arena.print("max-page-size={d}", .{size}));
988988 }
989989
990990 if (getLDMOption(target)) |ldm| {
......@@ -1190,7 +1190,7 @@ fn elfLink(lld: *Lld, arena: Allocator) !void {
11901190 if (target.os.versionRange().gnuLibCVersion().?.order(rem_in) != .lt) continue;
11911191 }
11921192
1193 const lib_path = try std.fmt.allocPrint(arena, "{f}{c}lib{s}.so.{d}", .{
1193 const lib_path = try arena.print("{f}{c}lib{s}.so.{d}", .{
11941194 comp.glibc_so_files.?.dir_path, fs.path.sep, lib.name, lib.sover,
11951195 });
11961196 try argv.append(lib_path);
......@@ -1207,21 +1207,21 @@ fn elfLink(lld: *Lld, arena: Allocator) !void {
12071207 if (target.os.version_range.semver.min.order(add_in) == .lt) continue;
12081208 }
12091209
1210 const lib_path = try std.fmt.allocPrint(arena, "{f}{c}lib{s}.so.{d}", .{
1210 const lib_path = try arena.print("{f}{c}lib{s}.so.{d}", .{
12111211 comp.freebsd_so_files.?.dir_path, fs.path.sep, lib.name, lib.getSoVersion(&target.os),
12121212 });
12131213 try argv.append(lib_path);
12141214 }
12151215 } else if (target.isNetBSDLibC()) {
12161216 for (netbsd.libs) |lib| {
1217 const lib_path = try std.fmt.allocPrint(arena, "{f}{c}lib{s}.so.{d}", .{
1217 const lib_path = try arena.print("{f}{c}lib{s}.so.{d}", .{
12181218 comp.netbsd_so_files.?.dir_path, fs.path.sep, lib.name, lib.sover,
12191219 });
12201220 try argv.append(lib_path);
12211221 }
12221222 } else if (target.isOpenBSDLibC()) {
12231223 for (openbsd.libs) |lib| {
1224 const lib_path = try std.fmt.allocPrint(arena, "{f}{c}lib{s}.so", .{
1224 const lib_path = try arena.print("{f}{c}lib{s}.so", .{
12251225 comp.openbsd_so_files.?.dir_path, fs.path.sep, lib.name,
12261226 });
12271227 try argv.append(lib_path);
......@@ -1451,12 +1451,12 @@ fn wasmLink(lld: *Lld, arena: Allocator) !void {
14511451 }
14521452
14531453 if (wasm.initial_memory) |initial_memory| {
1454 const arg = try std.fmt.allocPrint(arena, "--initial-memory={d}", .{initial_memory});
1454 const arg = try arena.print("--initial-memory={d}", .{initial_memory});
14551455 try argv.append(arg);
14561456 }
14571457
14581458 if (wasm.max_memory) |max_memory| {
1459 const arg = try std.fmt.allocPrint(arena, "--max-memory={d}", .{max_memory});
1459 const arg = try arena.print("--max-memory={d}", .{max_memory});
14601460 try argv.append(arg);
14611461 }
14621462
......@@ -1465,7 +1465,7 @@ fn wasmLink(lld: *Lld, arena: Allocator) !void {
14651465 }
14661466
14671467 if (wasm.global_base) |global_base| {
1468 const arg = try std.fmt.allocPrint(arena, "--global-base={d}", .{global_base});
1468 const arg = try arena.print("--global-base={d}", .{global_base});
14691469 try argv.append(arg);
14701470 } else {
14711471 // We prepend it by default, so when a stack overflow happens the runtime will trap correctly,
......@@ -1477,7 +1477,7 @@ fn wasmLink(lld: *Lld, arena: Allocator) !void {
14771477
14781478 // Users are allowed to specify which symbols they want to export to the wasm host.
14791479 for (wasm.export_symbol_names) |symbol_name| {
1480 const arg = try std.fmt.allocPrint(arena, "--export={s}", .{symbol_name});
1480 const arg = try arena.print("--export={s}", .{symbol_name});
14811481 try argv.append(arg);
14821482 }
14831483
......@@ -1493,15 +1493,15 @@ fn wasmLink(lld: *Lld, arena: Allocator) !void {
14931493
14941494 try argv.appendSlice(&.{
14951495 "-z",
1496 try std.fmt.allocPrint(arena, "stack-size={d}", .{base.stack_size}),
1496 try arena.print("stack-size={d}", .{base.stack_size}),
14971497 });
14981498
14991499 switch (base.build_id) {
15001500 .none => try argv.append("--build-id=none"),
1501 .fast, .uuid, .sha1 => try argv.append(try std.fmt.allocPrint(arena, "--build-id={s}", .{
1501 .fast, .uuid, .sha1 => try argv.append(try arena.print("--build-id={s}", .{
15021502 @tagName(base.build_id),
15031503 })),
1504 .hexstring => |hs| try argv.append(try std.fmt.allocPrint(arena, "--build-id=0x{x}", .{hs.toSlice()})),
1504 .hexstring => |hs| try argv.append(try arena.print("--build-id=0x{x}", .{hs.toSlice()})),
15051505 .md5 => {},
15061506 }
15071507
......@@ -1685,7 +1685,7 @@ fn spawnLld(comp: *Compilation, arena: Allocator, argv: []const []const u8) !voi
16851685 .argv = &.{
16861686 argv[0],
16871687 argv[1],
1688 try std.fmt.allocPrint(arena, "@{s}", .{
1688 try arena.print("@{s}", .{
16891689 try comp.dirs.local_cache.join(arena, &.{rsp_path}),
16901690 }),
16911691 },
......@@ -1740,7 +1740,6 @@ const std = @import("std");
17401740const Io = std.Io;
17411741const Allocator = std.mem.Allocator;
17421742const Cache = std.Build.Cache;
1743const allocPrint = std.fmt.allocPrint;
17441743const assert = std.debug.assert;
17451744const fs = std.fs;
17461745const log = std.log.scoped(.link);
src/main.zig+20-21
......@@ -21,7 +21,6 @@ const AstGen = std.zig.AstGen;
2121const ZonGen = std.zig.ZonGen;
2222const Server = std.zig.Server;
2323const stringToEnum = std.meta.stringToEnum;
24const allocPrint = std.fmt.allocPrint;
2524
2625pub const tracy = @import("tracy.zig");
2726const Compilation = @import("Compilation.zig");
......@@ -2964,7 +2963,7 @@ fn buildOutputType(
29642963 while (preprocessor_args_it.next()) |arg| {
29652964 if (mem.eql(u8, arg, "-MD") or mem.eql(u8, arg, "-MMD") or mem.eql(u8, arg, "-MT")) {
29662965 disable_c_depfile = true;
2967 const cc_arg = try allocPrint(arena, "-Wp,{s},{s}", .{ arg, preprocessor_args_it.nextOrFatal() });
2966 const cc_arg = try arena.print("-Wp,{s},{s}", .{ arg, preprocessor_args_it.nextOrFatal() });
29682967 try cc_argv.append(arena, cc_arg);
29692968 } else {
29702969 fatal("unsupported preprocessor arg: {s}", .{arg});
......@@ -3408,9 +3407,9 @@ fn buildOutputType(
34083407 .yes_default_value => if (create_module.resolved_options.output_mode == .Lib and
34093408 create_module.resolved_options.link_mode == .dynamic and target.ofmt == .elf)
34103409 if (have_version)
3411 try allocPrint(arena, "lib{s}.so.{d}", .{ root_name, version.major })
3410 try arena.print("lib{s}.so.{d}", .{ root_name, version.major })
34123411 else
3413 try allocPrint(arena, "lib{s}.so", .{root_name})
3412 try arena.print("lib{s}.so", .{root_name})
34143413 else
34153414 null,
34163415 };
......@@ -3420,7 +3419,7 @@ fn buildOutputType(
34203419 .yes_default_path => emit: {
34213420 if (output_to_cache != null) break :emit .yes_cache;
34223421 const name = switch (clang_preprocessor_mode) {
3423 .pch => try allocPrint(arena, "{s}.pch", .{root_name}),
3422 .pch => try arena.print("{s}.pch", .{root_name}),
34243423 else => try std.zig.binNameAlloc(arena, .{
34253424 .root_name = root_name,
34263425 .cpu_arch = target.cpu.arch,
......@@ -3456,16 +3455,16 @@ fn buildOutputType(
34563455 },
34573456 };
34583457
3459 const default_h_basename = try allocPrint(arena, "{s}.h", .{root_name});
3458 const default_h_basename = try arena.print("{s}.h", .{root_name});
34603459 const emit_h_resolved = emit_h.resolve(io, default_h_basename, output_to_cache);
34613460
3462 const default_asm_basename = try allocPrint(arena, "{s}.s", .{root_name});
3461 const default_asm_basename = try arena.print("{s}.s", .{root_name});
34633462 const emit_asm_resolved = emit_asm.resolve(io, default_asm_basename, output_to_cache);
34643463
3465 const default_llvm_ir_basename = try allocPrint(arena, "{s}.ll", .{root_name});
3464 const default_llvm_ir_basename = try arena.print("{s}.ll", .{root_name});
34663465 const emit_llvm_ir_resolved = emit_llvm_ir.resolve(io, default_llvm_ir_basename, output_to_cache);
34673466
3468 const default_llvm_bc_basename = try allocPrint(arena, "{s}.bc", .{root_name});
3467 const default_llvm_bc_basename = try arena.print("{s}.bc", .{root_name});
34693468 const emit_llvm_bc_resolved = emit_llvm_bc.resolve(io, default_llvm_bc_basename, output_to_cache);
34703469
34713470 const emit_docs_resolved = emit_docs.resolve(io, "docs", output_to_cache);
......@@ -3486,7 +3485,7 @@ fn buildOutputType(
34863485 fatal("the argument -femit-implib is allowed only when building a Windows DLL", .{});
34873486 }
34883487 }
3489 const default_implib_basename = try allocPrint(arena, "{s}.lib", .{root_name});
3488 const default_implib_basename = try arena.print("{s}.lib", .{root_name});
34903489 const emit_implib_resolved: Compilation.CreateOptions.Emit = switch (emit_implib) {
34913490 .no => .no,
34923491 .yes => emit_implib.resolve(io, default_implib_basename, output_to_cache),
......@@ -3515,7 +3514,7 @@ fn buildOutputType(
35153514
35163515 // "-" is stdin. Dump it to a real file.
35173516 const sep = fs.path.sep_str;
3518 const dump_path = try allocPrint(arena, "tmp" ++ sep ++ "{x}-dump-stdin{s}", .{
3517 const dump_path = try arena.print("tmp" ++ sep ++ "{x}-dump-stdin{s}", .{
35193518 randInt(io, u64), ext.canonicalName(target),
35203519 });
35213520 try dirs.local_cache.handle.createDirPath(io, "tmp");
......@@ -3544,7 +3543,7 @@ fn buildOutputType(
35443543
35453544 const bin_digest: Cache.BinDigest = hasher.hasher.finalResult();
35463545
3547 const sub_path = try allocPrint(arena, "tmp" ++ sep ++ "{x}-stdin{s}", .{
3546 const sub_path = try arena.print("tmp" ++ sep ++ "{x}-stdin{s}", .{
35483547 &bin_digest, ext.canonicalName(target),
35493548 });
35503549 try dirs.local_cache.handle.rename(dump_path, dirs.local_cache.handle, sub_path, io);
......@@ -3876,9 +3875,9 @@ fn buildOutputType(
38763875 for (mod.cc_argv) |cc_arg| test_exec_args.appendAssumeCapacity(cc_arg);
38773876 for (mod.deps) |dep| try test_exec_args.appendSlice(arena, &.{
38783877 "--dep",
3879 if (std.mem.eql(u8, dep.key, dep.value)) dep.value else try std.fmt.allocPrint(arena, "{s}={s}", .{ dep.key, dep.value }),
3878 if (std.mem.eql(u8, dep.key, dep.value)) dep.value else try arena.print("{s}={s}", .{ dep.key, dep.value }),
38803879 });
3881 try test_exec_args.append(arena, try std.fmt.allocPrint(arena, "-M{s}", .{mod_name}));
3880 try test_exec_args.append(arena, try arena.print("-M{s}", .{mod_name}));
38823881 }
38833882
38843883 try test_exec_args.ensureUnusedCapacity(arena, comp.global_cc_argv.len);
......@@ -4573,7 +4572,7 @@ fn runOrTest(
45734572 try argv.append(exe_path);
45744573 if (arg_mode == .zig_test) {
45754574 try argv.append(
4576 try allocPrint(arena, "--seed=0x{x}", .{randInt(io, u32)}),
4575 try arena.print("--seed=0x{x}", .{randInt(io, u32)}),
45774576 );
45784577 }
45794578 } else {
......@@ -4781,7 +4780,7 @@ fn cmdTranslateC(
47814780 assert(comp.c_source_files.len == 1);
47824781 const c_source_file = comp.c_source_files[0];
47834782
4784 const translated_basename = try allocPrint(arena, "{s}.zig", .{comp.root_name});
4783 const translated_basename = try arena.print("{s}.zig", .{comp.root_name});
47854784
47864785 var man: Cache.Manifest = comp.obtainCObjectCacheManifest(comp.root_mod);
47874786 man.want_shared_lock = false;
......@@ -4890,7 +4889,7 @@ fn jitCmd(
48904889
48914890 const root_prog_node = std.Progress.start(io, .{
48924891 .disable_printing = (color == .off),
4893 .root_name = try allocPrint(arena, "Compiling {s} (first time setup)", .{options.cmd_name}),
4892 .root_name = try arena.print("Compiling {s} (first time setup)", .{options.cmd_name}),
48944893 });
48954894 defer root_prog_node.end();
48964895
......@@ -5053,13 +5052,13 @@ fn jitCmdInner(
50535052 if (options.prepend_cmd) |cmd|
50545053 child_argv.appendAssumeCapacity(cmd);
50555054 if (options.prepend_zig_lib_dir_path)
5056 child_argv.appendAssumeCapacity(try allocPrint(arena, "--zig-lib={s}", .{dirs.zig_lib.path.?}));
5055 child_argv.appendAssumeCapacity(try arena.print("--zig-lib={s}", .{dirs.zig_lib.path.?}));
50575056 if (options.prepend_zig_exe_path)
5058 child_argv.appendAssumeCapacity(try allocPrint(arena, "--zig={s}", .{self_exe_path}));
5057 child_argv.appendAssumeCapacity(try arena.print("--zig={s}", .{self_exe_path}));
50595058 if (options.prepend_global_cache_path)
5060 child_argv.appendAssumeCapacity(try allocPrint(arena, "--global-cache={s}", .{dirs.global_cache.path.?}));
5059 child_argv.appendAssumeCapacity(try arena.print("--global-cache={s}", .{dirs.global_cache.path.?}));
50615060 if (options.prepend_seed)
5062 child_argv.appendAssumeCapacity(try allocPrint(arena, "--seed=0x{x}", .{randInt(io, u32)}));
5061 child_argv.appendAssumeCapacity(try arena.print("--seed=0x{x}", .{randInt(io, u32)}));
50635062
50645063 child_argv.appendSliceAssumeCapacity(args);
50655064