From 109e4d85c09339b35e25b5aba2dbd9b83074cfb7 Mon Sep 17 00:00:00 2001 From: Andrew Kelley Date: Wed, 27 May 2026 18:11:08 -0700 Subject: [PATCH] std.Io.net: don't check canonical name string in DNS resolution test We can't test the actual string here because it might be "localhost.localdomain" or even the computer host name (as on Windows). --- lib/std/Io/net/test.zig | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/lib/std/Io/net/test.zig b/lib/std/Io/net/test.zig index a93726c3c51c71489dbfad07f6979f3f49bf9391..1565904c574a6e392593dc7ad4b3c85a9ac1fd0a 100644 --- a/lib/std/Io/net/test.zig +++ b/lib/std/Io/net/test.zig @@ -136,21 +136,22 @@ test "resolve DNS" { }; var addresses_found: usize = 0; + var found_canonical_name = false; while (results.getOne(io)) |result| switch (result) { .address => |address| { if (address.eql(&localhost_v4) or address.eql(&localhost_v6)) addresses_found += 1; }, - .canonical_name => |canonical_name| try testing.expectEqualStrings( - if (canonical_name.bytes[canonical_name.bytes.len - 1] == '.') "localhost." else "localhost", - canonical_name.bytes, - ), + // We can't test the actual string here because it might be "localhost.localdomain" + // or even the computer host name (as on Windows). + .canonical_name => found_canonical_name = true, } else |err| switch (err) { error.Closed => {}, error.Canceled => |e| return e, } + try testing.expect(found_canonical_name); try testing.expect(addresses_found != 0); } -- 2.54.0