Commit 18d412ab2fb7bda92f7bfbdf732849bbcd066c33 | zig

author	Will Lillis <will.lillis24@gmail.com> 2024-07-20 02:31:19-04:00
committer	Andrew Kelley <andrew@ziglang.org> 2024-07-21 00:10:36-07:00
log	18d412ab2fb7bda92f7bfbdf732849bbcd066c33
tree	3363867ffee39f01401cd130f82f108d087ec62e
parent	9b292c094909e51718c1d37dbeb859674dd98c8a

fix: remove misleading error note for failed array coercions

2 files changed, 22 insertions(+), 7 deletions(-)

src
- Sema.zig
test
- cases
  - compile_errors
    invalid_array_assignment_with_valid_elems.zig

src/Sema.zig+11-7

 @@ -30279,7 +30279,7 @@ pub fn coerceInMemoryAllowed(
         if ((src_info.signedness == dest_info.signedness and dest_info.bits < src_info.bits) or
             // small enough unsigned ints can get casted to large enough signed ints
-            (dest_info.signedness == .signed and (src_info.signedness == .unsigned or dest_info.bits <= src_info.bits)) or
+            (dest_info.signedness == .signed and src_info.signedness == .unsigned and dest_info.bits <= src_info.bits) or
             (dest_info.signedness == .unsigned and src_info.signedness == .signed))
         {
             return InMemoryCoercionResult{ .int_not_coercible = .{
 @@ -30360,12 +30360,16 @@ pub fn coerceInMemoryAllowed(
         }
         const child = try sema.coerceInMemoryAllowed(block, dest_info.elem_type, src_info.elem_type, dest_is_mut, target, dest_src, src_src, null);
-        if (child != .ok) {
+        switch (child) {
-            return InMemoryCoercionResult{ .array_elem = .{
+            .ok => {},
-                .child = try child.dupe(sema.arena),
+            .no_match => return child,
-                .actual = src_info.elem_type,
+            else => {
-                .wanted = dest_info.elem_type,
+                return InMemoryCoercionResult{ .array_elem = .{
-            } };
+                    .child = try child.dupe(sema.arena),
+                    .actual = src_info.elem_type,
+                    .wanted = dest_info.elem_type,
+                } };
+            },
         }
         const ok_sent = (dest_info.sentinel == null and src_info.sentinel == null) or
             (src_info.sentinel != null and

test/cases/compile_errors/invalid_array_assignment_with_valid_elems.zig created+11

...	@@ -0,0 +1,11 @@
1	export fn a() void {
2	const x = [_]u16{ 1, 2, 3 };
3	const y: [3]i32 = x;
4	_ = y;
5	}
6
7	// error
8	// backend=stage2
9	// target=native
10	//
11	// 3:23: error: expected type '[3]i32', found '[3]u16'