From 198f35c98c8a8216a120f146605bb729e7b8dd66 Mon Sep 17 00:00:00 2001 From: Andrew Kelley Date: Mon, 25 May 2026 15:00:56 -0700 Subject: [PATCH] Maker: restore commit: clear step inputs when resetting the step I'm a bit confused because my understanding is that each step is supposed to make its own decision about whether to clear its watch inputs and start over, or retain them from the previous update. However, without this fix in place, the problem from #35224 manifests itself again. Since this fix is in place in master branch, I'll leave it for now and audit the file watching logic later. --- lib/compiler/Maker/Step.zig | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/lib/compiler/Maker/Step.zig b/lib/compiler/Maker/Step.zig index 2a42dd6959dd0510c0d6ff3887ef6e2b5eb5b411..1193b2c2a514021ff8c7db0a0053fdec6e08ac7f 100644 --- a/lib/compiler/Maker/Step.zig +++ b/lib/compiler/Maker/Step.zig @@ -312,8 +312,7 @@ pub fn reset(step: *Step, maker: *Maker) void { step.result_duration_ns = null; step.result_peak_rss = 0; step.test_results = .{}; - // We do not clearWatchInputs here because each step manages that choice - // independently. + clearWatchInputs(step, maker); step.result_error_bundle.deinit(gpa); step.result_error_bundle = std.zig.ErrorBundle.empty; -- 2.54.0