authorgravatar for kcbanner@gmail.comCasey Banner <kcbanner@gmail.com> 2023-03-25 16:33:25-04:00
committergravatar for kcbanner@gmail.comCasey Banner <kcbanner@gmail.com> 2023-03-25 16:33:25-04:00
log4569a28ea35e7152f01db1d36c493506b6ca71b6
tree0abcd98b7b88d89075042f391859a3c0152357ea
parentc79073c176a909abce3feba96203caef1e6d8360

build: fixes from review

1 files changed, 4 insertions(+), 3 deletions(-)

lib/std/Build/CompileStep.zig+4-3
...@@ -140,7 +140,8 @@ link_function_sections: bool = false,...@@ -140,7 +140,8 @@ link_function_sections: bool = false,
140/// exported symbols.140/// exported symbols.
141link_gc_sections: ?bool = null,141link_gc_sections: ?bool = null,
142142
143linker_dynamicbase: ?bool = null,143/// (Windows) Whether or not to enable ASLR. Maps to the /DYNAMICBASE[:NO] linker argument.
144linker_dynamicbase: bool = true,
144145
145linker_allow_shlib_undefined: ?bool = null,146linker_allow_shlib_undefined: ?bool = null,
146147
...@@ -1476,8 +1477,8 @@ fn make(step: *Step, prog_node: *std.Progress.Node) !void {...@@ -1476,8 +1477,8 @@ fn make(step: *Step, prog_node: *std.Progress.Node) !void {
1476 if (self.link_gc_sections) |x| {1477 if (self.link_gc_sections) |x| {
1477 try zig_args.append(if (x) "--gc-sections" else "--no-gc-sections");1478 try zig_args.append(if (x) "--gc-sections" else "--no-gc-sections");
1478 }1479 }
1479 if (self.linker_dynamicbase) |x| {1480 if (!self.linker_dynamicbase) {
1480 if (!x) try zig_args.append("--no-dynamicbase");1481 try zig_args.append("--no-dynamicbase");
1481 }1482 }
1482 if (self.linker_allow_shlib_undefined) |x| {1483 if (self.linker_allow_shlib_undefined) |x| {
1483 try zig_args.append(if (x) "-fallow-shlib-undefined" else "-fno-allow-shlib-undefined");1484 try zig_args.append(if (x) "-fallow-shlib-undefined" else "-fno-allow-shlib-undefined");