From 662683cafd552404fb704e9d0a8caf1eaaf35af8 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Alex=20R=C3=B8nne=20Petersen?= Date: Fri, 30 Aug 2024 13:15:28 +0200 Subject: [PATCH] update_cpu_features: Fix feature_overrides logic and replace an omit_cpus misuse. --- tools/update_cpu_features.zig | 13 +++++-------- 1 file changed, 5 insertions(+), 8 deletions(-) diff --git a/tools/update_cpu_features.zig b/tools/update_cpu_features.zig index 38651620d3a66a0e3cc0366bfdfc9e3f2120560c..63637d8f780861fd69eea88286aca11c59002233 100644 --- a/tools/update_cpu_features.zig +++ b/tools/update_cpu_features.zig @@ -985,11 +985,8 @@ const llvm_targets = [_]LlvmTarget{ .zig_name = "powerpc", .llvm_name = "PowerPC", .td_name = "PPC.td", - .feature_overrides = &.{ - .{ - .llvm_name = "ppc32", - .omit = true, - }, + .omit_cpus = &.{ + "ppc32", }, }, .{ @@ -1387,7 +1384,7 @@ fn processOneTarget(job: Job) anyerror!void { var all_cpus = std.ArrayList(Cpu).init(arena); { var it = root_map.iterator(); - root_it: while (it.next()) |kv| { + while (it.next()) |kv| { if (kv.key_ptr.len == 0) continue; if (kv.key_ptr.*[0] == '!') continue; if (kv.value_ptr.* != .object) continue; @@ -1469,7 +1466,7 @@ fn processOneTarget(job: Job) anyerror!void { for (llvm_target.feature_overrides) |feature_override| { if (mem.eql(u8, llvm_name, feature_override.llvm_name)) { if (feature_override.omit) { - continue :root_it; + continue; } if (feature_override.zig_name) |override_name| { zig_name = override_name; @@ -1515,7 +1512,7 @@ fn processOneTarget(job: Job) anyerror!void { for (llvm_target.feature_overrides) |feature_override| { if (mem.eql(u8, llvm_name, feature_override.llvm_name)) { if (feature_override.omit) { - continue :root_it; + continue; } if (feature_override.zig_name) |override_name| { zig_name = override_name; -- 2.54.0