Commit 689032d571ace146a78c5286125822dfd02970b2 | zig

author	Tom Read Cutting <readcuttingt@gmail.com> 2023-10-15 20:08:18+01:00
committer	Ryan Liptak <squeek502@hotmail.com> 2025-11-21 01:52:50-08:00
log	689032d571ace146a78c5286125822dfd02970b2
tree	d25d7a8143fcf6abb339bf6164171423314262de
parent	534370c4dede07c692ced0c5526a5370f233b4d3

Deal with NT paths in GetFinalPathNameByHandle

When calling QueryObjectName, NT namespaced paths can be returned. This
change appropriately strips the prefix to turn it into an absolute path.

(The above behaviour was observed at least in Wine so far)

Co-authored-by: Ryan Liptak <squeek502@hotmail.com>

1 files changed, 19 insertions(+), 8 deletions(-)

lib
- std
  - os
    windows.zig

lib/std/os/windows.zig+19-8

 @@ -1298,16 +1298,27 @@ pub fn GetFinalPathNameByHandle(
         },
         .Dos => {
             // parse the string to separate volume path from file path
-            const expected_prefix = std.unicode.utf8ToUtf16LeStringLiteral("\\Device\\");
+            const device_prefix = std.unicode.utf8ToUtf16LeStringLiteral("\\Device\\");
-            // TODO find out if a path can start with something besides `\Device\<volume name>`,
+            // We aren't entirely sure of the structure of the path returned by
-            // and if we need to handle it differently
+            // QueryObjectName in all contexts/environments.
-            // (i.e. how to determine the start and end of the volume name in that case)
+            // This code is written to cover the various cases that have
-            if (!mem.eql(u16, expected_prefix, final_path[0..expected_prefix.len])) return error.Unexpected;
+            // been encountered and solved appropriately. But note that there's
+            // no easy way to verify that they have all been tackled!
+            // (Unless you, the reader knows of one then please do action that!)
+            if (!mem.startsWith(u16, final_path, device_prefix)) {
+                // Wine seems to return NT namespaced paths starting with \??\ from QueryObjectName
+                // (e.g. `\??\Z:\some\path\to\a\file.txt`), in which case we can just strip the
+                // prefix to turn it into an absolute path.
+                return ntToWin32Namespace(final_path, out_buffer) catch |err| switch (err) {
+                    error.NotNtPath => return error.Unexpected,
+                    error.NameTooLong => |e| return e,
+                };
+            }
-            const file_path_begin_index = mem.indexOfPos(u16, final_path, expected_prefix.len, &[_]u16{'\\'}) orelse unreachable;
+            const file_path_begin_index = mem.indexOfPos(u16, final_path, device_prefix.len, &[_]u16{'\\'}) orelse unreachable;
             const volume_name_u16 = final_path[0..file_path_begin_index];
-            const device_name_u16 = volume_name_u16[expected_prefix.len..];
+            const device_name_u16 = volume_name_u16[device_prefix.len..];
             const file_name_u16 = final_path[file_path_begin_index..];
             // MUP is Multiple UNC Provider, and indicates that the path is a UNC