authorgravatar for kubkon@jakubkonka.comJakub Konka <kubkon@jakubkonka.com> 2024-03-12 20:21:48+01:00
committergravatar for kubkon@jakubkonka.comJakub Konka <kubkon@jakubkonka.com> 2024-03-13 08:25:38+01:00
log7ba2453b8ec56ccacfccc466183e1aaafbd5210e
treed8bebae027be1b725d731a635cc9498f22fb3ea1
parent55c085b893892f89e7d9930f3ec6c22537ebb54f

test/link/elf: do not check for $thunk in thunks tests for now

Andrew and I have discovered that on Linux max peak rss value is taken to be `max(build_runner, test_suite)` and since the thunks test emit a huge binary, we will easily exceed the declared maximum for any of the test suites. This can be worked around for now by not checking for $thunk symbols in this test since it doesn't really yield any additional information; however ideally we would implement per-thread local temp arena that can be freed.

1 files changed, 0 insertions(+), 12 deletions(-)

test/link/elf.zig-12
...@@ -2698,12 +2698,6 @@ fn testThunks(b: *Build, opts: Options) *Step {...@@ -2698,12 +2698,6 @@ fn testThunks(b: *Build, opts: Options) *Step {
2698 run.expectStdOutEqual("bar=42, foo=0, foobar=42");2698 run.expectStdOutEqual("bar=42, foo=0, foobar=42");
2699 run.expectExitCode(0);2699 run.expectExitCode(0);
2700 test_step.dependOn(&run.step);2700 test_step.dependOn(&run.step);
2701
2702 const check = exe.checkObject();
2703 check.max_bytes = std.math.maxInt(u32);
2704 check.checkInSymtab();
2705 check.checkContains("__libc_start_main$thunk");
2706 test_step.dependOn(&check.step);
2707 }2701 }
27082702
2709 {2703 {
...@@ -2714,12 +2708,6 @@ fn testThunks(b: *Build, opts: Options) *Step {...@@ -2714,12 +2708,6 @@ fn testThunks(b: *Build, opts: Options) *Step {
2714 run.expectStdOutEqual("bar=42, foo=0, foobar=42");2708 run.expectStdOutEqual("bar=42, foo=0, foobar=42");
2715 run.expectExitCode(0);2709 run.expectExitCode(0);
2716 test_step.dependOn(&run.step);2710 test_step.dependOn(&run.step);
2717
2718 const check = exe.checkObject();
2719 check.max_bytes = std.math.maxInt(u32);
2720 check.checkInSymtab();
2721 check.checkContains("__libc_start_main$thunk");
2722 test_step.dependOn(&check.step);
2723 }2711 }
27242712
2725 return test_step;2713 return test_step;