authorgravatar for mitchell.hashimoto@gmail.comMitchell Hashimoto <mitchell.hashimoto@gmail.com> 2022-01-31 21:24:37-08:00
committergravatar for andrew@ziglang.orgAndrew Kelley <andrew@ziglang.org> 2022-02-01 11:21:23-07:00
log970f954039ae91ffae51b71f408f1f787aadc98a
tree9ba8fc7d7a11ed8c294485b7f7b802679cca9cca
parent3e99495ed8d2a384501338edb4885e709d51bf74

stage2: cmp_eq between untyped undefines values results in undef bool

2 files changed, 3 insertions(+), 5 deletions(-)

src/Sema.zig+3-3
......@@ -9244,9 +9244,9 @@ fn cmpSelf(
92449244 const resolved_type = sema.typeOf(casted_lhs);
92459245 const runtime_src: LazySrcLoc = src: {
92469246 if (try sema.resolveMaybeUndefVal(block, lhs_src, casted_lhs)) |lhs_val| {
9247 if (lhs_val.isUndef()) return sema.addConstUndef(resolved_type);
9247 if (lhs_val.isUndef()) return sema.addConstUndef(Type.initTag(.bool));
92489248 if (try sema.resolveMaybeUndefVal(block, rhs_src, casted_rhs)) |rhs_val| {
9249 if (rhs_val.isUndef()) return sema.addConstUndef(resolved_type);
9249 if (rhs_val.isUndef()) return sema.addConstUndef(Type.initTag(.bool));
92509250
92519251 if (lhs_val.compare(op, rhs_val, resolved_type)) {
92529252 return Air.Inst.Ref.bool_true;
......@@ -9265,7 +9265,7 @@ fn cmpSelf(
92659265 // bool eq/neq more efficiently.
92669266 if (resolved_type.zigTypeTag() == .Bool) {
92679267 if (try sema.resolveMaybeUndefVal(block, rhs_src, casted_rhs)) |rhs_val| {
9268 if (rhs_val.isUndef()) return sema.addConstUndef(resolved_type);
9268 if (rhs_val.isUndef()) return sema.addConstUndef(Type.initTag(.bool));
92699269 return sema.runtimeBoolCmp(block, op, casted_lhs, rhs_val.toBool(), lhs_src);
92709270 }
92719271 }
test/behavior/math.zig-2
......@@ -1024,8 +1024,6 @@ test "vector comparison" {
10241024}
10251025
10261026test "compare undefined literal with comptime_int" {
1027 if (builtin.zig_backend != .stage1) return error.SkipZigTest; // TODO
1028
10291027 var x = undefined == 1;
10301028 // x is now undefined with type bool
10311029 x = true;