authorgravatar for ashe@kivikakk.eeAsherah Connor <ashe@kivikakk.ee> 2021-01-15 10:34:53+11:00
committergravatar for ashe@kivikakk.eeAsherah Connor <ashe@kivikakk.ee> 2021-01-15 10:34:53+11:00
logaffb57aad97240bf183015e6acba7eab4a9276bb
tree4fb325049997577b85b75d7119787edcffcd53cb
parent9168b217b23c5270328c3846fec61930ec7d2533

use interfaces

3 files changed, 15 insertions(+), 46 deletions(-)

lib/std/build/emit_raw.zig+3-4
......@@ -51,10 +51,9 @@ const BinaryElfOutput = struct {
5151 .segments = ArrayList(*BinaryElfSegment).init(allocator),
5252 .sections = ArrayList(*BinaryElfSection).init(allocator),
5353 };
54 const elf_source = std.elf.FileParseSource{ .file = elf_file };
55 const elf_hdr = try std.elf.Header.read(elf_source);
54 const elf_hdr = try std.elf.Header.read(&elf_file);
5655
57 var section_headers = elf_hdr.section_header_iterator(elf_source);
56 var section_headers = elf_hdr.section_header_iterator(&elf_file);
5857 while (try section_headers.next()) |section| {
5958 if (sectionValidForOutput(section)) {
6059 const newSection = try allocator.create(BinaryElfSection);
......@@ -68,7 +67,7 @@ const BinaryElfOutput = struct {
6867 }
6968 }
7069
71 var program_headers = elf_hdr.program_header_iterator(elf_source);
70 var program_headers = elf_hdr.program_header_iterator(&elf_file);
7271 while (try program_headers.next()) |phdr| {
7372 if (phdr.p_type == elf.PT_LOAD) {
7473 const newSegment = try allocator.create(BinaryElfSegment);
lib/std/elf.zig+10-39
......@@ -334,40 +334,6 @@ pub const ET = extern enum(u16) {
334334 pub const HIPROC = 0xffff;
335335};
336336
337pub const FileParseSource = struct {
338 file: std.fs.File,
339
340 fn readNoEof(self: FileParseSource, buf: []u8, offset: u64) !void {
341 var i: usize = 0;
342 while (i < buf.len) {
343 const len = self.file.pread(buf[i .. buf.len - i], offset + i) catch |err| switch (err) {
344 error.SystemResources => return error.SystemResources,
345 error.IsDir => return error.UnableToReadElfFile,
346 error.OperationAborted => return error.UnableToReadElfFile,
347 error.BrokenPipe => return error.UnableToReadElfFile,
348 error.Unseekable => return error.UnableToReadElfFile,
349 error.ConnectionResetByPeer => return error.UnableToReadElfFile,
350 error.ConnectionTimedOut => return error.UnableToReadElfFile,
351 error.InputOutput => return error.FileSystem,
352 error.Unexpected => return error.Unexpected,
353 error.WouldBlock => return error.Unexpected,
354 error.NotOpenForReading => return error.Unexpected,
355 error.AccessDenied => return error.Unexpected,
356 };
357 if (len == 0) return error.UnexpectedEndOfFile;
358 i += len;
359 }
360 }
361};
362
363pub const BufferParseSource = struct {
364 buffer: []const u8,
365
366 fn readNoEof(self: BufferParseSource, buf: []u8, offset: u64) !void {
367 std.mem.copy(u8, buf, self.buffer[offset .. offset + buf.len]);
368 }
369};
370
371337/// All integers are native endian.
372338pub const Header = struct {
373339 endian: builtin.Endian,
......@@ -397,7 +363,8 @@ pub const Header = struct {
397363
398364 pub fn read(parse_source: anytype) !Header {
399365 var hdr_buf: [@sizeOf(Elf64_Ehdr)]u8 align(@alignOf(Elf64_Ehdr)) = undefined;
400 try parse_source.readNoEof(&hdr_buf, 0);
366 try parse_source.seekableStream().seekTo(0);
367 try parse_source.reader().readNoEof(&hdr_buf);
401368 return Header.parse(&hdr_buf);
402369 }
403370
......@@ -448,7 +415,8 @@ pub fn ProgramHeaderIterator(ParseSource: anytype) type {
448415 if (self.elf_header.is_64) {
449416 var phdr: Elf64_Phdr = undefined;
450417 const offset = self.elf_header.phoff + @sizeOf(@TypeOf(phdr)) * self.index;
451 try self.parse_source.readNoEof(mem.asBytes(&phdr), offset);
418 try self.parse_source.seekableStream().seekTo(offset);
419 try self.parse_source.reader().readNoEof(mem.asBytes(&phdr));
452420
453421 // ELF endianness matches native endianness.
454422 if (self.elf_header.endian == std.builtin.endian) return phdr;
......@@ -468,7 +436,8 @@ pub fn ProgramHeaderIterator(ParseSource: anytype) type {
468436
469437 var phdr: Elf32_Phdr = undefined;
470438 const offset = self.elf_header.phoff + @sizeOf(@TypeOf(phdr)) * self.index;
471 try self.parse_source.readNoEof(mem.asBytes(&phdr), offset);
439 try self.parse_source.seekableStream().seekTo(offset);
440 try self.parse_source.reader().readNoEof(mem.asBytes(&phdr));
472441
473442 // ELF endianness does NOT match native endianness.
474443 if (self.elf_header.endian != std.builtin.endian) {
......@@ -513,7 +482,8 @@ pub fn SectionHeaderIterator(ParseSource: anytype) type {
513482 if (self.elf_header.is_64) {
514483 var shdr: Elf64_Shdr = undefined;
515484 const offset = self.elf_header.shoff + @sizeOf(@TypeOf(shdr)) * self.index;
516 try self.parse_source.readNoEof(mem.asBytes(&shdr), offset);
485 try self.parse_source.seekableStream().seekTo(offset);
486 try self.parse_source.reader().readNoEof(mem.asBytes(&shdr));
517487
518488 // ELF endianness matches native endianness.
519489 if (self.elf_header.endian == std.builtin.endian) return shdr;
......@@ -535,7 +505,8 @@ pub fn SectionHeaderIterator(ParseSource: anytype) type {
535505
536506 var shdr: Elf32_Shdr = undefined;
537507 const offset = self.elf_header.shoff + @sizeOf(@TypeOf(shdr)) * self.index;
538 try self.parse_source.readNoEof(mem.asBytes(&shdr), offset);
508 try self.parse_source.seekableStream().seekTo(offset);
509 try self.parse_source.reader().readNoEof(mem.asBytes(&shdr));
539510
540511 // ELF endianness does NOT match native endianness.
541512 if (self.elf_header.endian != std.builtin.endian) {
src/test.zig+2-3
......@@ -989,9 +989,8 @@ pub const TestContext = struct {
989989 var file = try tmp_dir.openFile(bin_name, .{ .read = true });
990990 defer file.close();
991991
992 const elf_source = std.elf.FileParseSource{ .file = file };
993 const header = try std.elf.Header.read(elf_source);
994 var iterator = header.program_header_iterator(elf_source);
992 const header = try std.elf.Header.read(&file);
993 var iterator = header.program_header_iterator(&file);
995994
996995 var none_loaded = true;
997996