authorgravatar for michaldrozd@protonmail.chfardragon <michaldrozd@protonmail.ch> 2026-06-04 18:41:41+00:00
committergravatar for michaldrozd@protonmail.chfardragon <michaldrozd@protonmail.ch> 2026-06-05 14:59:18+02:00
logbe18e17ce528f5e4a0cda5f694c8ad13a6b38662
tree28f66a8ebc8651553cc8cd0972765a25d5336706
parentcf741692f7c34b1bd3269fdd7437903bad64804d

Fix unexpected trailing whitespace for cmakedefine with no replacement value

3 files changed, 7 insertions(+), 4 deletions(-)

lib/compiler/Maker/Step/ConfigHeader.zig+6-1
......@@ -418,7 +418,12 @@ fn renderValueC(conf: *const Configuration, w: *Writer, name: []const u8, value:
418418}
419419
420420fn renderValueCIdent(w: *Writer, name: []const u8, ident: []const u8) Writer.Error!void {
421 return w.print("#define {s} {s}\n", .{ name, ident });
421 try w.print("#define {s}", .{name});
422 if (ident.len > 0) {
423 try w.writeByte(' ');
424 try w.writeAll(ident);
425 }
426 return w.writeByte('\n');
422427}
423428
424429fn renderValueCBool(w: *Writer, name: []const u8, b: bool) Writer.Error!void {
test/standalone/config_header/cmake/cmakedefine_edge_cases.h+1-2
......@@ -6,8 +6,7 @@
66/* #undef MULTI_WORD_FALSE */
77
88// cmakedefine with no replacement value (truthy)
9// TODO: unexpected whitespace is being added here
10#define NO_VALUE
9#define NO_VALUE
1110
1211// cmakedefine with no replacement value (falsy)
1312/* #undef NO_VALUE_FALSE */
test/standalone/config_header/cmake/cmakedefine_edge_cases.h.in-1
......@@ -5,7 +5,6 @@
55#cmakedefine MULTI_WORD_FALSE "hello world"
66
77// cmakedefine with no replacement value (truthy)
8// TODO: unexpected whitespace is being added here
98#cmakedefine NO_VALUE
109
1110// cmakedefine with no replacement value (falsy)