Commit cd1417dbdf098634641e87dba4c3be2806d76250 | zig

author	yujiri8 <yujiri@disroot.org> 2023-05-31 07:15:52-04:00
committer	GitHub <noreply@github.com> 2023-05-31 11:15:52+00:00
log	cd1417dbdf098634641e87dba4c3be2806d76250
tree	86f37e2015cb84fd08ec260772b7bb6b40686811
parent	32e719e070067333efa9d4888927b425d118fc97
signature	Signed by PGP key 4AEE18F83AFDEB23

don't crash when can't evaluate comptime expression with inferred type

Closes #15911.

3 files changed, 24 insertions(+), 3 deletions(-)

src
- Module.zig
- Sema.zig
test
- cases
  - compile_errors
    unable_to_evaluate_comptime_expr_with_inferred_type.zig

src/Module.zig+4

 @@ -6021,6 +6021,10 @@ pub fn errNoteNonLazy(
     comptime format: []const u8,
     args: anytype,
 ) error{OutOfMemory}!void {
+    if (src_loc.lazy == .unneeded) {
+        assert(parent.src_loc.lazy == .unneeded);
+        return;
+    }
     const msg = try std.fmt.allocPrint(mod.gpa, format, args);
     errdefer mod.gpa.free(msg);

src/Sema.zig+3-3

test/cases/compile_errors/unable_to_evaluate_comptime_expr_with_inferred_type.zig created+17

...	@@ -0,0 +1,17 @@
1	const A = struct {
2	a: u8,
3	};
4
5	var n: u8 = 5;
6	var a: A = .{ .a = n };
7
8	pub export fn entry() void {
9	_ = a;
10	}
11
12	// error
13	// backend=stage2
14	// target=native
15	//
16	// :6:13: error: unable to evaluate comptime expression
17	// :6:16: note: operation is runtime due to this operand

...	@@ -882,7 +882,7 @@ fn analyzeBodyInner(	...	@@ -882,7 +882,7 @@ fn analyzeBodyInner(
882		882
883	var dbg_block_begins: u32 = 0;	883	var dbg_block_begins: u32 = 0;
884		884
885	// We use a while(true) loop here to avoid a redundant way of breaking out of	885	// We use a while (true) loop here to avoid a redundant way of breaking out of
886	// the loop. The only way to break out of the loop is with a `noreturn`	886	// the loop. The only way to break out of the loop is with a `noreturn`
887	// instruction.	887	// instruction.
888	var i: usize = 0;	888	var i: usize = 0;
...	@@ -18073,7 +18073,7 @@ fn zirStructInitAnon(	...	@@ -18073,7 +18073,7 @@ fn zirStructInitAnon(
18073	return sema.addConstantMaybeRef(block, tuple_ty, tuple_val, is_ref);	18073	return sema.addConstantMaybeRef(block, tuple_ty, tuple_val, is_ref);
18074	};	18074	};
18075		18075
18076	sema.requireRuntimeBlock(block, src, .unneeded) catch \|err\| switch (err) {	18076	sema.requireRuntimeBlock(block, .unneeded, null) catch \|err\| switch (err) {
18077	error.NeededSourceLocation => {	18077	error.NeededSourceLocation => {
18078	const decl = sema.mod.declPtr(block.src_decl);	18078	const decl = sema.mod.declPtr(block.src_decl);
18079	const field_src = Module.initSrc(src.node_offset.x, sema.gpa, decl, runtime_index);	18079	const field_src = Module.initSrc(src.node_offset.x, sema.gpa, decl, runtime_index);
...	@@ -18179,7 +18179,7 @@ fn zirArrayInit(	...	@@ -18179,7 +18179,7 @@ fn zirArrayInit(
18179	return sema.addConstantMaybeRef(block, array_ty, array_val, is_ref);	18179	return sema.addConstantMaybeRef(block, array_ty, array_val, is_ref);
18180	};	18180	};
18181		18181
18182	sema.requireRuntimeBlock(block, src, .unneeded) catch \|err\| switch (err) {	18182	sema.requireRuntimeBlock(block, .unneeded, null) catch \|err\| switch (err) {
18183	error.NeededSourceLocation => {	18183	error.NeededSourceLocation => {
18184	const decl = sema.mod.declPtr(block.src_decl);	18184	const decl = sema.mod.declPtr(block.src_decl);
18185	const elem_src = Module.initSrc(src.node_offset.x, sema.gpa, decl, runtime_index);	18185	const elem_src = Module.initSrc(src.node_offset.x, sema.gpa, decl, runtime_index);