From cde6956b2128d9c28b00e0e25e27346abd1c3a88 Mon Sep 17 00:00:00 2001 From: David Rubin Date: Mon, 15 Jul 2024 02:34:40 -0700 Subject: [PATCH] riscv: remove redundant assert in `genBinOp` --- src/arch/riscv64/CodeGen.zig | 1 - test/behavior/byteswap.zig | 1 - test/behavior/cast.zig | 1 - test/behavior/floatop.zig | 1 - test/behavior/generics.zig | 3 --- test/behavior/globals.zig | 1 - test/behavior/pointers.zig | 2 -- test/behavior/src.zig | 1 - test/behavior/string_literals.zig | 1 - test/behavior/struct.zig | 1 - test/behavior/vector.zig | 4 ---- 11 files changed, 17 deletions(-) diff --git a/src/arch/riscv64/CodeGen.zig b/src/arch/riscv64/CodeGen.zig index 6ca4f37695121d684b5ee66f5a46947ccd51da34..34c782f66b72a259bca8a7f9ebfd05263a8f733f 100644 --- a/src/arch/riscv64/CodeGen.zig +++ b/src/arch/riscv64/CodeGen.zig @@ -2368,7 +2368,6 @@ fn genBinOp( const pt = func.pt; const zcu = pt.zcu; const bit_size = lhs_ty.bitSize(pt); - assert(bit_size <= 64); const is_unsigned = lhs_ty.isUnsignedInt(zcu); diff --git a/test/behavior/byteswap.zig b/test/behavior/byteswap.zig index 0c6e655b25c5dd273d33051d9f2c3c5605277f05..fd7e2af8503b2bd8889bb2d381d5799b9175c07c 100644 --- a/test/behavior/byteswap.zig +++ b/test/behavior/byteswap.zig @@ -100,7 +100,6 @@ test "@byteSwap vectors u8" { if (builtin.zig_backend == .stage2_aarch64) return error.SkipZigTest; if (builtin.zig_backend == .stage2_sparc64) return error.SkipZigTest; // TODO if (builtin.zig_backend == .stage2_spirv64) return error.SkipZigTest; - if (builtin.zig_backend == .stage2_riscv64) return error.SkipZigTest; try comptime vector8(); try vector8(); diff --git a/test/behavior/cast.zig b/test/behavior/cast.zig index 816fa02f5b62b8d5644c12948db999e5bcc83b20..44fcb08cf38a7878b1b077d56aa0c606b32b510d 100644 --- a/test/behavior/cast.zig +++ b/test/behavior/cast.zig @@ -1983,7 +1983,6 @@ test "peer type resolution: vector and array and tuple" { if (builtin.zig_backend == .stage2_arm) return error.SkipZigTest; // TODO if (builtin.zig_backend == .stage2_wasm) return error.SkipZigTest; // TODO if (builtin.zig_backend == .stage2_sparc64) return error.SkipZigTest; // TODO - if (builtin.zig_backend == .stage2_riscv64) return error.SkipZigTest; var vec: @Vector(2, i8) = .{ 10, 20 }; var arr: [2]i8 = .{ 30, 40 }; diff --git a/test/behavior/floatop.zig b/test/behavior/floatop.zig index f644465d6327dfa5ea4b973f13ed9edec8df73ac..f9f2579b0acaa0124a150c8018f31f66d300139d 100644 --- a/test/behavior/floatop.zig +++ b/test/behavior/floatop.zig @@ -134,7 +134,6 @@ test "cmp f16" { test "cmp f32/f64" { if (builtin.zig_backend == .stage2_sparc64) return error.SkipZigTest; // TODO if (builtin.zig_backend == .stage2_x86_64 and builtin.target.ofmt != .elf and builtin.target.ofmt != .macho) return error.SkipZigTest; - if (builtin.zig_backend == .stage2_riscv64) return error.SkipZigTest; try testCmp(f32); try comptime testCmp(f32); diff --git a/test/behavior/generics.zig b/test/behavior/generics.zig index 6bd627dfe3c09ca024689ef2bf2eead8ea8ee83b..2a40123259fbff4c11e94705fe246e32cccc88e8 100644 --- a/test/behavior/generics.zig +++ b/test/behavior/generics.zig @@ -19,7 +19,6 @@ fn checkSize(comptime T: type) usize { test "simple generic fn" { if (builtin.zig_backend == .stage2_aarch64) return error.SkipZigTest; if (builtin.zig_backend == .stage2_sparc64) return error.SkipZigTest; // TODO - if (builtin.zig_backend == .stage2_riscv64) return error.SkipZigTest; try expect(max(i32, 3, -1) == 3); try expect(max(u8, 1, 100) == 100); @@ -56,7 +55,6 @@ test "fn with comptime args" { if (builtin.zig_backend == .stage2_arm) return error.SkipZigTest; if (builtin.zig_backend == .stage2_aarch64) return error.SkipZigTest; if (builtin.zig_backend == .stage2_sparc64) return error.SkipZigTest; // TODO - if (builtin.zig_backend == .stage2_riscv64) return error.SkipZigTest; try expect(gimmeTheBigOne(1234, 5678) == 5678); try expect(shouldCallSameInstance(34, 12) == 34); @@ -67,7 +65,6 @@ test "anytype params" { if (builtin.zig_backend == .stage2_arm) return error.SkipZigTest; if (builtin.zig_backend == .stage2_aarch64) return error.SkipZigTest; if (builtin.zig_backend == .stage2_sparc64) return error.SkipZigTest; // TODO - if (builtin.zig_backend == .stage2_riscv64) return error.SkipZigTest; try expect(max_i32(12, 34) == 34); try expect(max_f64(1.2, 3.4) == 3.4); diff --git a/test/behavior/globals.zig b/test/behavior/globals.zig index f7a23b725fcf92ba185b5f1ec74bf737b6416f01..89dc20c5c786536f862fddc37270d4ce5973192d 100644 --- a/test/behavior/globals.zig +++ b/test/behavior/globals.zig @@ -18,7 +18,6 @@ test "store to global vector" { if (builtin.zig_backend == .stage2_sparc64) return error.SkipZigTest; if (builtin.zig_backend == .stage2_arm) return error.SkipZigTest; if (builtin.zig_backend == .stage2_aarch64) return error.SkipZigTest; - if (builtin.zig_backend == .stage2_riscv64) return error.SkipZigTest; try expect(vpos[1] == 0.0); vpos = @Vector(2, f32){ 0.0, 1.0 }; diff --git a/test/behavior/pointers.zig b/test/behavior/pointers.zig index 36152cf81af60a5953541a6a90894178617fd228..d8a773f69c71c0e810aa88b0a310d2ecffda418d 100644 --- a/test/behavior/pointers.zig +++ b/test/behavior/pointers.zig @@ -125,7 +125,6 @@ test "initialize const optional C pointer to null" { test "assigning integer to C pointer" { if (builtin.zig_backend == .stage2_sparc64) return error.SkipZigTest; // TODO - if (builtin.zig_backend == .stage2_riscv64) return error.SkipZigTest; var x: i32 = 0; var y: i32 = 1; @@ -143,7 +142,6 @@ test "assigning integer to C pointer" { test "C pointer comparison and arithmetic" { if (builtin.zig_backend == .stage2_sparc64) return error.SkipZigTest; // TODO - if (builtin.zig_backend == .stage2_riscv64) return error.SkipZigTest; const S = struct { fn doTheTest() !void { diff --git a/test/behavior/src.zig b/test/behavior/src.zig index 7c2b377d5b3880aa02f91ee65eb7074ba479832c..f0455bdd2edb491e15bf7ad9d642ea2887b76e22 100644 --- a/test/behavior/src.zig +++ b/test/behavior/src.zig @@ -17,7 +17,6 @@ test "@src" { if (builtin.zig_backend == .stage2_aarch64) return error.SkipZigTest; // TODO if (builtin.zig_backend == .stage2_sparc64) return error.SkipZigTest; // TODO if (builtin.zig_backend == .stage2_arm) return error.SkipZigTest; // TODO - if (builtin.zig_backend == .stage2_riscv64) return error.SkipZigTest; try doTheTest(); } diff --git a/test/behavior/string_literals.zig b/test/behavior/string_literals.zig index a45403af97009693e53b61ece2b167e0174aaeab..8a0a1052289bb5653f3358d590f542b26de4c1b1 100644 --- a/test/behavior/string_literals.zig +++ b/test/behavior/string_literals.zig @@ -65,7 +65,6 @@ fn testFnForSrc() std.builtin.SourceLocation { test "@src() returns a struct containing 0-terminated string slices" { if (builtin.zig_backend == .stage2_aarch64) return error.SkipZigTest; // TODO if (builtin.zig_backend == .stage2_sparc64) return error.SkipZigTest; // TODO - if (builtin.zig_backend == .stage2_riscv64) return error.SkipZigTest; const src = testFnForSrc(); try std.testing.expect([:0]const u8 == @TypeOf(src.file)); diff --git a/test/behavior/struct.zig b/test/behavior/struct.zig index 689c725db3c3275f08d3441104077a90d7484150..38bbd4b0c43cee39962d65fd3b5aa7d706dc9a1a 100644 --- a/test/behavior/struct.zig +++ b/test/behavior/struct.zig @@ -1587,7 +1587,6 @@ test "optional field init with tuple" { test "if inside struct init inside if" { if (builtin.zig_backend == .stage2_aarch64) return error.SkipZigTest; // TODO - if (builtin.zig_backend == .stage2_riscv64) return error.SkipZigTest; const MyStruct = struct { x: u32 }; const b: u32 = 5; diff --git a/test/behavior/vector.zig b/test/behavior/vector.zig index d4b2acd6afd8985445232015c0dfa432dec187d2..5ae6e400ffe022ceed726b06eb5b31c14ac1a4fd 100644 --- a/test/behavior/vector.zig +++ b/test/behavior/vector.zig @@ -445,7 +445,6 @@ test "load vector elements via runtime index" { if (builtin.zig_backend == .stage2_aarch64) return error.SkipZigTest; // TODO if (builtin.zig_backend == .stage2_arm) return error.SkipZigTest; // TODO if (builtin.zig_backend == .stage2_sparc64) return error.SkipZigTest; // TODO - if (builtin.zig_backend == .stage2_riscv64) return error.SkipZigTest; const S = struct { fn doTheTest() !void { @@ -1240,7 +1239,6 @@ test "loading the second vector from a slice of vectors" { if (builtin.zig_backend == .stage2_aarch64) return error.SkipZigTest; // TODO if (builtin.zig_backend == .stage2_arm) return error.SkipZigTest; // TODO if (builtin.zig_backend == .stage2_sparc64) return error.SkipZigTest; // TODO - if (builtin.zig_backend == .stage2_riscv64) return error.SkipZigTest; @setRuntimeSafety(false); var small_bases = [2]@Vector(2, u8){ @@ -1327,7 +1325,6 @@ test "zero multiplicand" { if (builtin.zig_backend == .stage2_aarch64) return error.SkipZigTest; // TODO if (builtin.zig_backend == .stage2_arm) return error.SkipZigTest; // TODO if (builtin.zig_backend == .stage2_sparc64) return error.SkipZigTest; // TODO - if (builtin.zig_backend == .stage2_riscv64) return error.SkipZigTest; const zeros = @Vector(2, u32){ 0.0, 0.0 }; var ones = @Vector(2, u32){ 1.0, 1.0 }; @@ -1488,7 +1485,6 @@ test "store vector with memset" { test "addition of vectors represented as strings" { if (builtin.zig_backend == .stage2_aarch64) return error.SkipZigTest; // TODO if (builtin.zig_backend == .stage2_arm) return error.SkipZigTest; // TODO - if (builtin.zig_backend == .stage2_riscv64) return error.SkipZigTest; const V = @Vector(3, u8); const foo: V = "foo".*; -- 2.54.0