Commit d3ca10d5d8bc92280a14f9e40dc41d6accc1b4c2 | zig

author	Matthew Lugg <mlugg@mlugg.co.uk> 2025-02-03 20:10:44+00:00
committer	Matthew Lugg <mlugg@mlugg.co.uk> 2025-02-04 16:20:29+00:00
log	d3ca10d5d8bc92280a14f9e40dc41d6accc1b4c2
tree	20306667045b1136e12399d5fe13612925f0677c
parent	3a4bb47fedbb890dc149622e31c75101b14c3b16
signature	Commit is signed but in an unrecognized format.

Zcu: remove `*_loaded` fields on `File`

Instead, `source`, `tree`, and `zir` should all be optional. This is
precisely what we're actually trying to model here; and `File` isn't
optimized for memory consumption or serializability anyway, so it's fine
to use a couple of extra bytes on actual optionals here.

11 files changed, 191 insertions(+), 240 deletions(-)

src
- Builtin.zig
- Compilation.zig
- Package
  - Module.zig
- Sema.zig
- Type.zig
- Zcu.zig
- Zcu
  - PerThread.zig
- link.zig
- link
  - Dwarf.zig
- main.zig
- print_zir.zig

src/Builtin.zig+9-13

 @@ -264,14 +264,12 @@ pub fn append(opts: @This(), buffer: *std.ArrayList(u8)) Allocator.Error!void {
 }
 pub fn populateFile(comp: *Compilation, mod: *Module, file: *File) !void {
-    assert(file.source_loaded == true);
     if (mod.root.statFile(mod.root_src_path)) |stat| {
-        if (stat.size != file.source.len) {
+        if (stat.size != file.source.?.len) {
             std.log.warn(
                 "the cached file '{}{s}' had the wrong size. Expected {d}, found {d}. " ++
                     "Overwriting with correct file contents now",
-                .{ mod.root, mod.root_src_path, file.source.len, stat.size },
+                .{ mod.root, mod.root_src_path, file.source.?.len, stat.size },
             );
             try writeFile(file, mod);
 @@ -296,15 +294,13 @@ pub fn populateFile(comp: *Compilation, mod: *Module, file: *File) !void {
     log.debug("parsing and generating '{s}'", .{mod.root_src_path});
-    file.tree = try std.zig.Ast.parse(comp.gpa, file.source, .zig);
+    file.tree = try std.zig.Ast.parse(comp.gpa, file.source.?, .zig);
-    assert(file.tree.errors.len == 0); // builtin.zig must parse
+    assert(file.tree.?.errors.len == 0); // builtin.zig must parse
-    file.tree_loaded = true;
-    file.zir = try AstGen.generate(comp.gpa, file.tree);
+    file.zir = try AstGen.generate(comp.gpa, file.tree.?);
-    assert(!file.zir.hasCompileErrors()); // builtin.zig must not have astgen errors
+    assert(!file.zir.?.hasCompileErrors()); // builtin.zig must not have astgen errors
-    file.zir_loaded = true;
     file.status = .success_zir;
-    // Note that whilst we set `zir_loaded` here, we populated `path_digest`
+    // Note that whilst we set `zir` here, we populated `path_digest`
     // all the way back in `Package.Module.create`.
 }
 @@ -312,7 +308,7 @@ fn writeFile(file: *File, mod: *Module) !void {
     var buf: [std.fs.max_path_bytes]u8 = undefined;
     var af = try mod.root.atomicFile(mod.root_src_path, .{ .make_path = true }, &buf);
     defer af.deinit();
-    try af.file.writeAll(file.source);
+    try af.file.writeAll(file.source.?);
     af.finish() catch |err| switch (err) {
         error.AccessDenied => switch (builtin.os.tag) {
             .windows => {
 @@ -326,7 +322,7 @@ fn writeFile(file: *File, mod: *Module) !void {
     };
     file.stat = .{
-        .size = file.source.len,
+        .size = file.source.?.len,
         .inode = 0, // dummy value
         .mtime = 0, // dummy value
     };

src/Compilation.zig+7-13

 @@ -3211,7 +3211,7 @@ pub fn getAllErrorsAlloc(comp: *Compilation) !ErrorBundle {
             } else {
                 // Must be ZIR or Zoir errors. Note that this may include AST errors.
                 _ = try file.getTree(gpa); // Tree must be loaded.
-                if (file.zir_loaded) {
+                if (file.zir != null) {
                     try addZirErrorMessages(&bundle, file);
                 } else if (file.zoir != null) {
                     try addZoirErrorMessages(&bundle, file);
 @@ -3623,22 +3623,17 @@ pub fn addModuleErrorMsg(
 }
 pub fn addZirErrorMessages(eb: *ErrorBundle.Wip, file: *Zcu.File) !void {
-    assert(file.zir_loaded);
-    assert(file.tree_loaded);
-    assert(file.source_loaded);
     const gpa = eb.gpa;
     const src_path = try file.fullPath(gpa);
     defer gpa.free(src_path);
-    return eb.addZirErrorMessages(file.zir, file.tree, file.source, src_path);
+    return eb.addZirErrorMessages(file.zir.?, file.tree.?, file.source.?, src_path);
 }
 pub fn addZoirErrorMessages(eb: *ErrorBundle.Wip, file: *Zcu.File) !void {
-    assert(file.source_loaded);
-    assert(file.tree_loaded);
     const gpa = eb.gpa;
     const src_path = try file.fullPath(gpa);
     defer gpa.free(src_path);
-    return eb.addZoirErrorMessages(file.zoir.?, file.tree, file.source, src_path);
+    return eb.addZoirErrorMessages(file.zoir.?, file.tree.?, file.source.?, src_path);
 }
 pub fn performAllTheWork(
 @@ -4312,18 +4307,17 @@ fn workerAstGenFile(
     // Pre-emptively look for `@import` paths and queue them up.
     // If we experience an error preemptively fetching the
     // file, just ignore it and let it happen again later during Sema.
-    assert(file.zir_loaded);
+    const imports_index = file.zir.?.extra[@intFromEnum(Zir.ExtraIndex.imports)];
-    const imports_index = file.zir.extra[@intFromEnum(Zir.ExtraIndex.imports)];
     if (imports_index != 0) {
-        const extra = file.zir.extraData(Zir.Inst.Imports, imports_index);
+        const extra = file.zir.?.extraData(Zir.Inst.Imports, imports_index);
         var import_i: u32 = 0;
         var extra_index = extra.end;
         while (import_i < extra.data.imports_len) : (import_i += 1) {
-            const item = file.zir.extraData(Zir.Inst.Imports.Item, extra_index);
+            const item = file.zir.?.extraData(Zir.Inst.Imports.Item, extra_index);
             extra_index = item.end;
-            const import_path = file.zir.nullTerminatedString(item.data.name);
+            const import_path = file.zir.?.nullTerminatedString(item.data.name);
             // `@import("builtin")` is handled specially.
             if (mem.eql(u8, import_path, "builtin")) continue;

src/Package/Module.zig+4-6

 @@ -482,13 +482,11 @@ pub fn create(arena: Allocator, options: CreateOptions) !*Package.Module {
         };
         new_file.* = .{
             .sub_file_path = "builtin.zig",
-            .source = generated_builtin_source,
-            .source_loaded = true,
-            .tree_loaded = false,
-            .zir_loaded = false,
             .stat = undefined,
-            .tree = undefined,
+            .source = generated_builtin_source,
-            .zir = undefined,
+            .tree = null,
+            .zir = null,
+            .zoir = null,
             .status = .never_loaded,
             .prev_status = .never_loaded,
             .mod = new,

src/Sema.zig+6-7

src/Type.zig+3-4

...	@@ -3587,8 +3587,7 @@ pub fn typeDeclSrcLine(ty: Type, zcu: *Zcu) ?u32 {	...	@@ -3587,8 +3587,7 @@ pub fn typeDeclSrcLine(ty: Type, zcu: *Zcu) ?u32 {
3587	};	3587	};
3588	const info = tracked.resolveFull(&zcu.intern_pool) orelse return null;	3588	const info = tracked.resolveFull(&zcu.intern_pool) orelse return null;
3589	const file = zcu.fileByIndex(info.file);	3589	const file = zcu.fileByIndex(info.file);
3590	assert(file.zir_loaded);	3590	const zir = file.zir.?;
3591	const zir = file.zir;
3592	const inst = zir.instructions.get(@intFromEnum(info.inst));	3591	const inst = zir.instructions.get(@intFromEnum(info.inst));
3593	return switch (inst.tag) {	3592	return switch (inst.tag) {
3594	.struct_init, .struct_init_ref => zir.extraData(Zir.Inst.StructInit, inst.data.pl_node.payload_index).data.abs_line,	3593	.struct_init, .struct_init_ref => zir.extraData(Zir.Inst.StructInit, inst.data.pl_node.payload_index).data.abs_line,
...	@@ -3905,7 +3904,7 @@ fn resolveStructInner(	...	@@ -3905,7 +3904,7 @@ fn resolveStructInner(
3905	var comptime_err_ret_trace = std.ArrayList(Zcu.LazySrcLoc).init(gpa);	3904	var comptime_err_ret_trace = std.ArrayList(Zcu.LazySrcLoc).init(gpa);
3906	defer comptime_err_ret_trace.deinit();	3905	defer comptime_err_ret_trace.deinit();
3907		3906
3908	const zir = zcu.namespacePtr(struct_obj.namespace).fileScope(zcu).zir;	3907	const zir = zcu.namespacePtr(struct_obj.namespace).fileScope(zcu).zir.?;
3909	var sema: Sema = .{	3908	var sema: Sema = .{
3910	.pt = pt,	3909	.pt = pt,
3911	.gpa = gpa,	3910	.gpa = gpa,
...	@@ -3959,7 +3958,7 @@ fn resolveUnionInner(	...	@@ -3959,7 +3958,7 @@ fn resolveUnionInner(
3959	var comptime_err_ret_trace = std.ArrayList(Zcu.LazySrcLoc).init(gpa);	3958	var comptime_err_ret_trace = std.ArrayList(Zcu.LazySrcLoc).init(gpa);
3960	defer comptime_err_ret_trace.deinit();	3959	defer comptime_err_ret_trace.deinit();
3961		3960
3962	const zir = zcu.namespacePtr(union_obj.namespace).fileScope(zcu).zir;	3961	const zir = zcu.namespacePtr(union_obj.namespace).fileScope(zcu).zir.?;
3963	var sema: Sema = .{	3962	var sema: Sema = .{
3964	.pt = pt,	3963	.pt = pt,
3965	.gpa = gpa,	3964	.gpa = gpa,

src/Zcu.zig+39-46

...	@@ -660,22 +660,17 @@ pub const Namespace = struct {	...	@@ -660,22 +660,17 @@ pub const Namespace = struct {
660	pub const File = struct {	660	pub const File = struct {
661	status: Status,	661	status: Status,
662	prev_status: Status,	662	prev_status: Status,
663	source_loaded: bool,
664	tree_loaded: bool,
665	zir_loaded: bool,
666	/// Relative to the owning package's root source directory.	663	/// Relative to the owning package's root source directory.
667	/// Memory is stored in gpa, owned by File.	664	/// Memory is stored in gpa, owned by File.
668	sub_file_path: []const u8,	665	sub_file_path: []const u8,
669	/// Whether this is populated depends on `source_loaded`.
670	source: [:0]const u8,
671	/// Whether this is populated depends on `status`.	666	/// Whether this is populated depends on `status`.
672	stat: Cache.File.Stat,	667	stat: Cache.File.Stat,
673	/// Whether this is populated or not depends on `tree_loaded`.	668
674	tree: Ast,	669	source: ?[:0]const u8,
675	/// Whether this is populated or not depends on `zir_loaded`.	670	tree: ?Ast,
676	zir: Zir,	671	zir: ?Zir,
677	/// Cached Zoir, generated lazily.	672	zoir: ?Zoir,
678	zoir: ?Zoir = null,	673
679	/// Module that this file is a part of, managed externally.	674	/// Module that this file is a part of, managed externally.
680	mod: *Package.Module,	675	mod: *Package.Module,
681	/// Whether this file is a part of multiple packages. This is an error condition which will be reported after AstGen.	676	/// Whether this file is a part of multiple packages. This is an error condition which will be reported after AstGen.
...	@@ -727,23 +722,23 @@ pub const File = struct {	...	@@ -727,23 +722,23 @@ pub const File = struct {
727	}	722	}
728		723
729	pub fn unloadTree(file: *File, gpa: Allocator) void {	724	pub fn unloadTree(file: *File, gpa: Allocator) void {
730	if (file.tree_loaded) {	725	if (file.tree) \|*tree\| {
731	file.tree_loaded = false;	726	tree.deinit(gpa);
732	file.tree.deinit(gpa);	727	file.tree = null;
733	}	728	}
734	}	729	}
735		730
736	pub fn unloadSource(file: *File, gpa: Allocator) void {	731	pub fn unloadSource(file: *File, gpa: Allocator) void {
737	if (file.source_loaded) {	732	if (file.source) \|source\| {
738	file.source_loaded = false;	733	gpa.free(source);
739	gpa.free(file.source);	734	file.source = null;
740	}	735	}
741	}	736	}
742		737
743	pub fn unloadZir(file: *File, gpa: Allocator) void {	738	pub fn unloadZir(file: *File, gpa: Allocator) void {
744	if (file.zir_loaded) {	739	if (file.zir) \|*zir\| {
745	file.zir_loaded = false;	740	zir.deinit(gpa);
746	file.zir.deinit(gpa);	741	file.zir = null;
747	}	742	}
748	}	743	}
749		744
...	@@ -753,8 +748,8 @@ pub const File = struct {	...	@@ -753,8 +748,8 @@ pub const File = struct {
753	};	748	};
754		749
755	pub fn getSource(file: *File, gpa: Allocator) !Source {	750	pub fn getSource(file: *File, gpa: Allocator) !Source {
756	if (file.source_loaded) return Source{	751	if (file.source) \|source\| return .{
757	.bytes = file.source,	752	.bytes = source,
758	.stat = file.stat,	753	.stat = file.stat,
759	};	754	};
760		755
...	@@ -769,7 +764,8 @@ pub const File = struct {	...	@@ -769,7 +764,8 @@ pub const File = struct {
769	return error.FileTooBig;	764	return error.FileTooBig;
770		765
771	const source = try gpa.allocSentinel(u8, @as(usize, @intCast(stat.size)), 0);	766	const source = try gpa.allocSentinel(u8, @as(usize, @intCast(stat.size)), 0);
772	defer if (!file.source_loaded) gpa.free(source);	767	defer gpa.free(source);
		768
773	const amt = try f.readAll(source);	769	const amt = try f.readAll(source);
774	if (amt != stat.size)	770	if (amt != stat.size)
775	return error.UnexpectedEndOfFile;	771	return error.UnexpectedEndOfFile;
...	@@ -778,9 +774,9 @@ pub const File = struct {	...	@@ -778,9 +774,9 @@ pub const File = struct {
778	// used for error reporting. We need to keep the stat fields stale so that	774	// used for error reporting. We need to keep the stat fields stale so that
779	// astGenFile can know to regenerate ZIR.	775	// astGenFile can know to regenerate ZIR.
780		776
		777	errdefer comptime unreachable; // don't error after populating `source`
781	file.source = source;	778	file.source = source;
782	file.source_loaded = true;	779	return .{
783	return Source{
784	.bytes = source,	780	.bytes = source,
785	.stat = .{	781	.stat = .{
786	.size = stat.size,	782	.size = stat.size,
...	@@ -791,20 +787,20 @@ pub const File = struct {	...	@@ -791,20 +787,20 @@ pub const File = struct {
791	}	787	}
792		788
793	pub fn getTree(file: File, gpa: Allocator) !const Ast {	789	pub fn getTree(file: File, gpa: Allocator) !const Ast {
794	if (file.tree_loaded) return &file.tree;	790	if (file.tree) \|*tree\| return tree;
795		791
796	const source = try file.getSource(gpa);	792	const source = try file.getSource(gpa);
797	file.tree = try Ast.parse(gpa, source.bytes, file.getMode());	793	file.tree = try .parse(gpa, source.bytes, file.getMode());
798	file.tree_loaded = true;	794	return &file.tree.?;
799	return &file.tree;
800	}	795	}
801		796
802	pub fn getZoir(file: File, zcu: Zcu) !*const Zoir {	797	pub fn getZoir(file: File, zcu: Zcu) !*const Zoir {
803	if (file.zoir) \|*zoir\| return zoir;	798	if (file.zoir) \|*zoir\| return zoir;
804		799
805	assert(file.tree_loaded);	800	const tree = file.tree.?;
806	assert(file.tree.mode == .zon);	801	assert(tree.mode == .zon);
807	file.zoir = try ZonGen.generate(zcu.gpa, file.tree, .{});	802
		803	file.zoir = try ZonGen.generate(zcu.gpa, tree, .{});
808	if (file.zoir.?.hasCompileErrors()) {	804	if (file.zoir.?.hasCompileErrors()) {
809	try zcu.failed_files.putNoClobber(zcu.gpa, file, null);	805	try zcu.failed_files.putNoClobber(zcu.gpa, file, null);
810	return error.AnalysisFail;	806	return error.AnalysisFail;
...	@@ -900,18 +896,18 @@ pub const File = struct {	...	@@ -900,18 +896,18 @@ pub const File = struct {
900		896
901	// We can only mark children as failed if the ZIR is loaded, which may not	897	// We can only mark children as failed if the ZIR is loaded, which may not
902	// be the case if there were other astgen failures in this file	898	// be the case if there were other astgen failures in this file
903	if (!file.zir_loaded) return;	899	if (file.zir == null) return;
904		900
905	const imports_index = file.zir.extra[@intFromEnum(Zir.ExtraIndex.imports)];	901	const imports_index = file.zir.?.extra[@intFromEnum(Zir.ExtraIndex.imports)];
906	if (imports_index == 0) return;	902	if (imports_index == 0) return;
907	const extra = file.zir.extraData(Zir.Inst.Imports, imports_index);	903	const extra = file.zir.?.extraData(Zir.Inst.Imports, imports_index);
908		904
909	var extra_index = extra.end;	905	var extra_index = extra.end;
910	for (0..extra.data.imports_len) \|_\| {	906	for (0..extra.data.imports_len) \|_\| {
911	const item = file.zir.extraData(Zir.Inst.Imports.Item, extra_index);	907	const item = file.zir.?.extraData(Zir.Inst.Imports.Item, extra_index);
912	extra_index = item.end;	908	extra_index = item.end;
913		909
914	const import_path = file.zir.nullTerminatedString(item.data.name);	910	const import_path = file.zir.?.nullTerminatedString(item.data.name);
915	if (mem.eql(u8, import_path, "builtin")) continue;	911	if (mem.eql(u8, import_path, "builtin")) continue;
916		912
917	const res = pt.importFile(file, import_path) catch continue;	913	const res = pt.importFile(file, import_path) catch continue;
...	@@ -1012,7 +1008,7 @@ pub const SrcLoc = struct {	...	@@ -1012,7 +1008,7 @@ pub const SrcLoc = struct {
1012	lazy: LazySrcLoc.Offset,	1008	lazy: LazySrcLoc.Offset,
1013		1009
1014	pub fn baseSrcToken(src_loc: SrcLoc) Ast.TokenIndex {	1010	pub fn baseSrcToken(src_loc: SrcLoc) Ast.TokenIndex {
1015	const tree = src_loc.file_scope.tree;	1011	const tree = src_loc.file_scope.tree.?;
1016	return tree.firstToken(src_loc.base_node);	1012	return tree.firstToken(src_loc.base_node);
1017	}	1013	}
1018		1014
...	@@ -1057,7 +1053,6 @@ pub const SrcLoc = struct {	...	@@ -1057,7 +1053,6 @@ pub const SrcLoc = struct {
1057	const node_off = traced_off.x;	1053	const node_off = traced_off.x;
1058	const tree = try src_loc.file_scope.getTree(gpa);	1054	const tree = try src_loc.file_scope.getTree(gpa);
1059	const node = src_loc.relativeToNodeIndex(node_off);	1055	const node = src_loc.relativeToNodeIndex(node_off);
1060	assert(src_loc.file_scope.tree_loaded);
1061	return tree.nodeToSpan(node);	1056	return tree.nodeToSpan(node);
1062	},	1057	},
1063	.node_offset_main_token => \|node_off\| {	1058	.node_offset_main_token => \|node_off\| {
...	@@ -1069,7 +1064,6 @@ pub const SrcLoc = struct {	...	@@ -1069,7 +1064,6 @@ pub const SrcLoc = struct {
1069	.node_offset_bin_op => \|node_off\| {	1064	.node_offset_bin_op => \|node_off\| {
1070	const tree = try src_loc.file_scope.getTree(gpa);	1065	const tree = try src_loc.file_scope.getTree(gpa);
1071	const node = src_loc.relativeToNodeIndex(node_off);	1066	const node = src_loc.relativeToNodeIndex(node_off);
1072	assert(src_loc.file_scope.tree_loaded);
1073	return tree.nodeToSpan(node);	1067	return tree.nodeToSpan(node);
1074	},	1068	},
1075	.node_offset_initializer => \|node_off\| {	1069	.node_offset_initializer => \|node_off\| {
...	@@ -2408,9 +2402,8 @@ pub const LazySrcLoc = struct {	...	@@ -2408,9 +2402,8 @@ pub const LazySrcLoc = struct {
2408	if (zir_inst == .main_struct_inst) return .{ file, 0 };	2402	if (zir_inst == .main_struct_inst) return .{ file, 0 };
2409		2403
2410	// Otherwise, make sure ZIR is loaded.	2404	// Otherwise, make sure ZIR is loaded.
2411	assert(file.zir_loaded);	2405	const zir = file.zir.?;
2412		2406
2413	const zir = file.zir;
2414	const inst = zir.instructions.get(@intFromEnum(zir_inst));	2407	const inst = zir.instructions.get(@intFromEnum(zir_inst));
2415	const base_node: Ast.Node.Index = switch (inst.tag) {	2408	const base_node: Ast.Node.Index = switch (inst.tag) {
2416	.declaration => inst.data.declaration.src_node,	2409	.declaration => inst.data.declaration.src_node,
...	@@ -3671,7 +3664,7 @@ fn resolveReferencesInner(zcu: *Zcu) !std.AutoHashMapUnmanaged(AnalUnit, ?Resolv	...	@@ -3671,7 +3664,7 @@ fn resolveReferencesInner(zcu: *Zcu) !std.AutoHashMapUnmanaged(AnalUnit, ?Resolv
3671	const inst_info = nav.analysis.?.zir_index.resolveFull(ip) orelse continue;	3664	const inst_info = nav.analysis.?.zir_index.resolveFull(ip) orelse continue;
3672	const file = zcu.fileByIndex(inst_info.file);	3665	const file = zcu.fileByIndex(inst_info.file);
3673	// If the file failed AstGen, the TrackedInst refers to the old ZIR.	3666	// If the file failed AstGen, the TrackedInst refers to the old ZIR.
3674	const zir = if (file.status == .success_zir) file.zir else file.prev_zir.?.*;	3667	const zir = if (file.status == .success_zir) file.zir.? else file.prev_zir.?.*;
3675	const decl = zir.getDeclaration(inst_info.inst);	3668	const decl = zir.getDeclaration(inst_info.inst);
3676		3669
3677	if (!comp.config.is_test or file.mod != zcu.main_mod) continue;	3670	if (!comp.config.is_test or file.mod != zcu.main_mod) continue;
...	@@ -3703,7 +3696,7 @@ fn resolveReferencesInner(zcu: *Zcu) !std.AutoHashMapUnmanaged(AnalUnit, ?Resolv	...	@@ -3703,7 +3696,7 @@ fn resolveReferencesInner(zcu: *Zcu) !std.AutoHashMapUnmanaged(AnalUnit, ?Resolv
3703	const inst_info = ip.getNav(nav).analysis.?.zir_index.resolveFull(ip) orelse continue;	3696	const inst_info = ip.getNav(nav).analysis.?.zir_index.resolveFull(ip) orelse continue;
3704	const file = zcu.fileByIndex(inst_info.file);	3697	const file = zcu.fileByIndex(inst_info.file);
3705	// If the file failed AstGen, the TrackedInst refers to the old ZIR.	3698	// If the file failed AstGen, the TrackedInst refers to the old ZIR.
3706	const zir = if (file.status == .success_zir) file.zir else file.prev_zir.?.*;	3699	const zir = if (file.status == .success_zir) file.zir.? else file.prev_zir.?.*;
3707	const decl = zir.getDeclaration(inst_info.inst);	3700	const decl = zir.getDeclaration(inst_info.inst);
3708	if (decl.linkage == .@"export") {	3701	if (decl.linkage == .@"export") {
3709	const unit: AnalUnit = .wrap(.{ .nav_val = nav });	3702	const unit: AnalUnit = .wrap(.{ .nav_val = nav });
...	@@ -3721,7 +3714,7 @@ fn resolveReferencesInner(zcu: *Zcu) !std.AutoHashMapUnmanaged(AnalUnit, ?Resolv	...	@@ -3721,7 +3714,7 @@ fn resolveReferencesInner(zcu: *Zcu) !std.AutoHashMapUnmanaged(AnalUnit, ?Resolv
3721	const inst_info = ip.getNav(nav).analysis.?.zir_index.resolveFull(ip) orelse continue;	3714	const inst_info = ip.getNav(nav).analysis.?.zir_index.resolveFull(ip) orelse continue;
3722	const file = zcu.fileByIndex(inst_info.file);	3715	const file = zcu.fileByIndex(inst_info.file);
3723	// If the file failed AstGen, the TrackedInst refers to the old ZIR.	3716	// If the file failed AstGen, the TrackedInst refers to the old ZIR.
3724	const zir = if (file.status == .success_zir) file.zir else file.prev_zir.?.*;	3717	const zir = if (file.status == .success_zir) file.zir.? else file.prev_zir.?.*;
3725	const decl = zir.getDeclaration(inst_info.inst);	3718	const decl = zir.getDeclaration(inst_info.inst);
3726	if (decl.linkage == .@"export") {	3719	if (decl.linkage == .@"export") {
3727	const unit: AnalUnit = .wrap(.{ .nav_val = nav });	3720	const unit: AnalUnit = .wrap(.{ .nav_val = nav });
...	@@ -3858,7 +3851,7 @@ pub fn navSrcLine(zcu: *Zcu, nav_index: InternPool.Nav.Index) u32 {	...	@@ -3858,7 +3851,7 @@ pub fn navSrcLine(zcu: *Zcu, nav_index: InternPool.Nav.Index) u32 {
3858	const ip = &zcu.intern_pool;	3851	const ip = &zcu.intern_pool;
3859	const inst_info = ip.getNav(nav_index).srcInst(ip).resolveFull(ip).?;	3852	const inst_info = ip.getNav(nav_index).srcInst(ip).resolveFull(ip).?;
3860	const zir = zcu.fileByIndex(inst_info.file).zir;	3853	const zir = zcu.fileByIndex(inst_info.file).zir;
3861	return zir.getDeclaration(inst_info.inst).src_line;	3854	return zir.?.getDeclaration(inst_info.inst).src_line;
3862	}	3855	}
3863		3856
3864	pub fn navValue(zcu: *const Zcu, nav_index: InternPool.Nav.Index) Value {	3857	pub fn navValue(zcu: *const Zcu, nav_index: InternPool.Nav.Index) Value {

src/Zcu/PerThread.zig+56-63

 @@ -209,7 +209,6 @@ pub fn astGenFile(
                 },
                 else => |e| return e,
             };
-            file.zir_loaded = true;
             file.stat = .{
                 .size = header.stat_size,
                 .inode = header.stat_inode,
 @@ -219,12 +218,12 @@ pub fn astGenFile(
             file.status = .success_zir;
             log.debug("AstGen cached success: {s}", .{file.sub_file_path});
-            if (file.zir.hasCompileErrors()) {
+            if (file.zir.?.hasCompileErrors()) {
                 comp.mutex.lock();
                 defer comp.mutex.unlock();
                 try zcu.failed_files.putNoClobber(gpa, file, null);
             }
-            if (file.zir.loweringFailed()) {
+            if (file.zir.?.loweringFailed()) {
                 file.status = .astgen_failure;
                 return error.AnalysisFail;
             }
 @@ -261,13 +260,12 @@ pub fn astGenFile(
     //    single-threaded context, so we need to keep both versions around
     //    until that point in the pipeline. Previous ZIR data is freed after
     //    that.
-    if (file.zir_loaded and !file.zir.loweringFailed()) {
+    if (file.zir != null and !file.zir.?.loweringFailed()) {
         assert(file.prev_zir == null);
         const prev_zir_ptr = try gpa.create(Zir);
         file.prev_zir = prev_zir_ptr;
-        prev_zir_ptr.* = file.zir;
+        prev_zir_ptr.* = file.zir.?;
-        file.zir = undefined;
+        file.zir = null;
-        file.zir_loaded = false;
     }
     file.unload(gpa);
 @@ -275,7 +273,7 @@ pub fn astGenFile(
         return error.FileTooBig;
     const source = try gpa.allocSentinel(u8, @as(usize, @intCast(stat.size)), 0);
-    defer if (!file.source_loaded) gpa.free(source);
+    defer if (file.source == null) gpa.free(source);
     const amt = try source_file.readAll(source);
     if (amt != stat.size)
         return error.UnexpectedEndOfFile;
 @@ -286,42 +284,39 @@ pub fn astGenFile(
         .mtime = stat.mtime,
     };
     file.source = source;
-    file.source_loaded = true;
     file.tree = try Ast.parse(gpa, source, .zig);
-    file.tree_loaded = true;
     // Any potential AST errors are converted to ZIR errors here.
-    file.zir = try AstGen.generate(gpa, file.tree);
+    file.zir = try AstGen.generate(gpa, file.tree.?);
-    file.zir_loaded = true;
     file.prev_status = file.status;
     file.status = .success_zir;
     log.debug("AstGen fresh success: {s}", .{file.sub_file_path});
     const safety_buffer = if (Zcu.data_has_safety_tag)
-        try gpa.alloc([8]u8, file.zir.instructions.len)
+        try gpa.alloc([8]u8, file.zir.?.instructions.len)
     else
         undefined;
     defer if (Zcu.data_has_safety_tag) gpa.free(safety_buffer);
     const data_ptr = if (Zcu.data_has_safety_tag)
-        if (file.zir.instructions.len == 0)
+        if (file.zir.?.instructions.len == 0)
             @as([*]const u8, undefined)
         else
             @as([*]const u8, @ptrCast(safety_buffer.ptr))
     else
-        @as([*]const u8, @ptrCast(file.zir.instructions.items(.data).ptr));
+        @as([*]const u8, @ptrCast(file.zir.?.instructions.items(.data).ptr));
     if (Zcu.data_has_safety_tag) {
         // The `Data` union has a safety tag but in the file format we store it without.
-        for (file.zir.instructions.items(.data), 0..) |*data, i| {
+        for (file.zir.?.instructions.items(.data), 0..) |*data, i| {
             const as_struct: *const Zcu.HackDataLayout = @ptrCast(data);
             safety_buffer[i] = as_struct.data;
         }
     }
     const header: Zir.Header = .{
-        .instructions_len = @as(u32, @intCast(file.zir.instructions.len)),
+        .instructions_len = @as(u32, @intCast(file.zir.?.instructions.len)),
-        .string_bytes_len = @as(u32, @intCast(file.zir.string_bytes.len)),
+        .string_bytes_len = @as(u32, @intCast(file.zir.?.string_bytes.len)),
-        .extra_len = @as(u32, @intCast(file.zir.extra.len)),
+        .extra_len = @as(u32, @intCast(file.zir.?.extra.len)),
         .stat_size = stat.size,
         .stat_inode = stat.inode,
 @@ -333,20 +328,20 @@ pub fn astGenFile(
             .len = @sizeOf(Zir.Header),
         },
         .{
-            .base = @as([*]const u8, @ptrCast(file.zir.instructions.items(.tag).ptr)),
+            .base = @as([*]const u8, @ptrCast(file.zir.?.instructions.items(.tag).ptr)),
-            .len = file.zir.instructions.len,
+            .len = file.zir.?.instructions.len,
         },
         .{
             .base = data_ptr,
-            .len = file.zir.instructions.len * 8,
+            .len = file.zir.?.instructions.len * 8,
         },
         .{
-            .base = file.zir.string_bytes.ptr,
+            .base = file.zir.?.string_bytes.ptr,
-            .len = file.zir.string_bytes.len,
+            .len = file.zir.?.string_bytes.len,
         },
         .{
-            .base = @as([*]const u8, @ptrCast(file.zir.extra.ptr)),
+            .base = @as([*]const u8, @ptrCast(file.zir.?.extra.ptr)),
-            .len = file.zir.extra.len * 4,
+            .len = file.zir.?.extra.len * 4,
         },
     };
     cache_file.writevAll(&iovecs) catch |err| {
 @@ -355,12 +350,12 @@ pub fn astGenFile(
         });
     };
-    if (file.zir.hasCompileErrors()) {
+    if (file.zir.?.hasCompileErrors()) {
         comp.mutex.lock();
         defer comp.mutex.unlock();
         try zcu.failed_files.putNoClobber(gpa, file, null);
     }
-    if (file.zir.loweringFailed()) {
+    if (file.zir.?.loweringFailed()) {
         file.status = .astgen_failure;
         return error.AnalysisFail;
     }
 @@ -392,7 +387,7 @@ pub fn updateZirRefs(pt: Zcu.PerThread) Allocator.Error!void {
             try zcu.markDependeeOutdated(.not_marked_po, .{ .file = file_index });
         }
         const old_zir = file.prev_zir orelse continue;
-        const new_zir = file.zir;
+        const new_zir = file.zir.?;
         const gop = try updated_files.getOrPut(gpa, file_index);
         assert(!gop.found_existing);
         gop.value_ptr.* = .{
 @@ -400,7 +395,7 @@ pub fn updateZirRefs(pt: Zcu.PerThread) Allocator.Error!void {
             .inst_map = .{},
         };
         if (!new_zir.loweringFailed()) {
-            try Zcu.mapOldZirToNew(gpa, old_zir.*, file.zir, &gop.value_ptr.inst_map);
+            try Zcu.mapOldZirToNew(gpa, old_zir.*, new_zir, &gop.value_ptr.inst_map);
         }
     }
 @@ -426,7 +421,7 @@ pub fn updateZirRefs(pt: Zcu.PerThread) Allocator.Error!void {
                 // Either way, invalidate associated `src_hash` deps.
                 log.debug("tracking failed for %{d}{s}", .{
                     old_inst,
-                    if (file.zir.loweringFailed()) " due to AstGen failure" else "",
+                    if (file.zir.?.loweringFailed()) " due to AstGen failure" else "",
                 });
                 tracked_inst.inst = .lost;
                 try zcu.markDependeeOutdated(.not_marked_po, .{ .src_hash = tracked_inst_index });
 @@ -435,7 +430,7 @@ pub fn updateZirRefs(pt: Zcu.PerThread) Allocator.Error!void {
             tracked_inst.inst = InternPool.TrackedInst.MaybeLost.ZirIndex.wrap(new_inst);
             const old_zir = file.prev_zir.?.*;
-            const new_zir = file.zir;
+            const new_zir = file.zir.?;
             const old_tag = old_zir.instructions.items(.tag)[@intFromEnum(old_inst)];
             const old_data = old_zir.instructions.items(.data)[@intFromEnum(old_inst)];
 @@ -532,7 +527,7 @@ pub fn updateZirRefs(pt: Zcu.PerThread) Allocator.Error!void {
     for (updated_files.keys(), updated_files.values()) |file_index, updated_file| {
         const file = updated_file.file;
-        if (file.zir.loweringFailed()) {
+        if (file.zir.?.loweringFailed()) {
             // Keep `prev_zir` around: it's the last usable ZIR.
             // Don't update the namespace, as we have no new data to update *to*.
         } else {
 @@ -805,7 +800,7 @@ fn analyzeComptimeUnit(pt: Zcu.PerThread, cu_id: InternPool.ComptimeUnit.Id) Zcu
     // unnecessary, and we can move the below `removeDependenciesForDepender` call up with its friends
     // in `ensureComptimeUnitUpToDate`.
     if (file.status != .success_zir) return error.AnalysisFail;
-    const zir = file.zir;
+    const zir = file.zir.?;
     // We are about to re-analyze this unit; drop its depenndencies.
     zcu.intern_pool.removeDependenciesForDepender(gpa, anal_unit);
 @@ -1002,7 +997,7 @@ fn analyzeNavVal(pt: Zcu.PerThread, nav_id: InternPool.Nav.Index) Zcu.CompileErr
     // unnecessary, and we can move the below `removeDependenciesForDepender` call up with its friends
     // in `ensureComptimeUnitUpToDate`.
     if (file.status != .success_zir) return error.AnalysisFail;
-    const zir = file.zir;
+    const zir = file.zir.?;
     // We are about to re-analyze this unit; drop its depenndencies.
     zcu.intern_pool.removeDependenciesForDepender(gpa, anal_unit);
 @@ -1380,7 +1375,7 @@ fn analyzeNavType(pt: Zcu.PerThread, nav_id: InternPool.Nav.Index) Zcu.CompileEr
     // unnecessary, and we can move the below `removeDependenciesForDepender` call up with its friends
     // in `ensureComptimeUnitUpToDate`.
     if (file.status != .success_zir) return error.AnalysisFail;
-    const zir = file.zir;
+    const zir = file.zir.?;
     // We are about to re-analyze this unit; drop its depenndencies.
     zcu.intern_pool.removeDependenciesForDepender(gpa, anal_unit);
 @@ -1758,7 +1753,7 @@ fn createFileRootStruct(
     const gpa = zcu.gpa;
     const ip = &zcu.intern_pool;
     const file = zcu.fileByIndex(file_index);
-    const extended = file.zir.instructions.items(.data)[@intFromEnum(Zir.Inst.Index.main_struct_inst)].extended;
+    const extended = file.zir.?.instructions.items(.data)[@intFromEnum(Zir.Inst.Index.main_struct_inst)].extended;
     assert(extended.opcode == .struct_decl);
     const small: Zir.Inst.StructDecl.Small = @bitCast(extended.small);
     assert(!small.has_captures_len);
 @@ -1766,16 +1761,16 @@ fn createFileRootStruct(
     assert(small.layout == .auto);
     var extra_index: usize = extended.operand + @typeInfo(Zir.Inst.StructDecl).@"struct".fields.len;
     const fields_len = if (small.has_fields_len) blk: {
-        const fields_len = file.zir.extra[extra_index];
+        const fields_len = file.zir.?.extra[extra_index];
         extra_index += 1;
         break :blk fields_len;
     } else 0;
     const decls_len = if (small.has_decls_len) blk: {
-        const decls_len = file.zir.extra[extra_index];
+        const decls_len = file.zir.?.extra[extra_index];
         extra_index += 1;
         break :blk decls_len;
     } else 0;
-    const decls = file.zir.bodySlice(extra_index, decls_len);
+    const decls = file.zir.?.bodySlice(extra_index, decls_len);
     extra_index += decls_len;
     const tracked_inst = try ip.trackZir(gpa, pt.tid, .{
 @@ -1844,17 +1839,17 @@ fn updateFileNamespace(pt: Zcu.PerThread, file_index: Zcu.File.Index) Allocator.
     const namespace_index = Type.fromInterned(file_root_type).getNamespaceIndex(zcu);
     const decls = decls: {
-        const extended = file.zir.instructions.items(.data)[@intFromEnum(Zir.Inst.Index.main_struct_inst)].extended;
+        const extended = file.zir.?.instructions.items(.data)[@intFromEnum(Zir.Inst.Index.main_struct_inst)].extended;
         const small: Zir.Inst.StructDecl.Small = @bitCast(extended.small);
         var extra_index: usize = extended.operand + @typeInfo(Zir.Inst.StructDecl).@"struct".fields.len;
         extra_index += @intFromBool(small.has_fields_len);
         const decls_len = if (small.has_decls_len) blk: {
-            const decls_len = file.zir.extra[extra_index];
+            const decls_len = file.zir.?.extra[extra_index];
             extra_index += 1;
             break :blk decls_len;
         } else 0;
-        break :decls file.zir.bodySlice(extra_index, decls_len);
+        break :decls file.zir.?.bodySlice(extra_index, decls_len);
     };
     try pt.scanNamespace(namespace_index, decls);
     zcu.namespacePtr(namespace_index).generation = zcu.generation;
 @@ -1873,7 +1868,7 @@ fn semaFile(pt: Zcu.PerThread, file_index: Zcu.File.Index) Zcu.SemaError!void {
     if (file.status != .success_zir) {
         return error.AnalysisFail;
     }
-    assert(file.zir_loaded);
+    assert(file.zir != null);
     const new_namespace_index = try pt.createNamespace(.{
         .parent = .none,
 @@ -1983,13 +1978,11 @@ pub fn importPkg(pt: Zcu.PerThread, mod: *Module) !Zcu.ImportFileResult {
     gop.value_ptr.* = new_file_index;
     new_file.* = .{
         .sub_file_path = sub_file_path,
-        .source = undefined,
-        .source_loaded = false,
-        .tree_loaded = false,
-        .zir_loaded = false,
         .stat = undefined,
-        .tree = undefined,
+        .source = null,
-        .zir = undefined,
+        .tree = null,
+        .zir = null,
+        .zoir = null,
         .status = .never_loaded,
         .prev_status = .never_loaded,
         .mod = mod,
 @@ -2096,13 +2089,11 @@ pub fn importFile(
     gop.value_ptr.* = new_file_index;
     new_file.* = .{
         .sub_file_path = sub_file_path,
-        .source = undefined,
-        .source_loaded = false,
-        .tree_loaded = false,
-        .zir_loaded = false,
         .stat = undefined,
-        .tree = undefined,
+        .source = null,
-        .zir = undefined,
+        .tree = null,
+        .zir = null,
+        .zoir = null,
         .status = .never_loaded,
         .prev_status = .never_loaded,
         .mod = mod,
 @@ -2441,7 +2432,7 @@ const ScanDeclIter = struct {
         const namespace = zcu.namespacePtr(namespace_index);
         const gpa = zcu.gpa;
         const file = namespace.fileScope(zcu);
-        const zir = file.zir;
+        const zir = file.zir.?;
         const ip = &zcu.intern_pool;
         const decl = zir.getDeclaration(decl_inst);
 @@ -2591,7 +2582,7 @@ fn analyzeFnBodyInner(pt: Zcu.PerThread, func_index: InternPool.Index) Zcu.SemaE
     const func = zcu.funcInfo(func_index);
     const inst_info = func.zir_body_inst.resolveFull(ip) orelse return error.AnalysisFail;
     const file = zcu.fileByIndex(inst_info.file);
-    const zir = file.zir;
+    const zir = file.zir.?;
     try zcu.analysis_in_progress.put(gpa, anal_unit, {});
     errdefer _ = zcu.analysis_in_progress.swapRemove(anal_unit);
 @@ -2843,7 +2834,9 @@ pub fn getErrorValueFromSlice(pt: Zcu.PerThread, name: []const u8) Allocator.Err
 /// Removes any entry from `Zcu.failed_files` associated with `file`. Acquires `Compilation.mutex` as needed.
 /// `file.zir` must be unchanged from the last update, as it is used to determine if there is such an entry.
 fn lockAndClearFileCompileError(pt: Zcu.PerThread, file: *Zcu.File) void {
-    if (!file.zir_loaded or !file.zir.hasCompileErrors()) return;
+    const zir = file.zir orelse return;
+    if (zir.hasCompileErrors()) return;
     pt.zcu.comp.mutex.lock();
     defer pt.zcu.comp.mutex.unlock();
     if (pt.zcu.failed_files.fetchSwapRemove(file)) |kv| {
 @@ -3779,7 +3772,7 @@ fn recreateStructType(
     const inst_info = key.zir_index.resolveFull(ip).?;
     const file = zcu.fileByIndex(inst_info.file);
     assert(file.status == .success_zir); // otherwise inst tracking failed
-    const zir = file.zir;
+    const zir = file.zir.?;
     assert(zir.instructions.items(.tag)[@intFromEnum(inst_info.inst)] == .extended);
     const extended = zir.instructions.items(.data)[@intFromEnum(inst_info.inst)].extended;
 @@ -3852,7 +3845,7 @@ fn recreateUnionType(
     const inst_info = key.zir_index.resolveFull(ip).?;
     const file = zcu.fileByIndex(inst_info.file);
     assert(file.status == .success_zir); // otherwise inst tracking failed
-    const zir = file.zir;
+    const zir = file.zir.?;
     assert(zir.instructions.items(.tag)[@intFromEnum(inst_info.inst)] == .extended);
     const extended = zir.instructions.items(.data)[@intFromEnum(inst_info.inst)].extended;
 @@ -3939,7 +3932,7 @@ fn recreateEnumType(
     const inst_info = key.zir_index.resolveFull(ip).?;
     const file = zcu.fileByIndex(inst_info.file);
     assert(file.status == .success_zir); // otherwise inst tracking failed
-    const zir = file.zir;
+    const zir = file.zir.?;
     assert(zir.instructions.items(.tag)[@intFromEnum(inst_info.inst)] == .extended);
     const extended = zir.instructions.items(.data)[@intFromEnum(inst_info.inst)].extended;
 @@ -4083,7 +4076,7 @@ pub fn ensureNamespaceUpToDate(pt: Zcu.PerThread, namespace_index: Zcu.Namespace
     const inst_info = key.zir_index.resolveFull(ip) orelse return error.AnalysisFail;
     const file = zcu.fileByIndex(inst_info.file);
     if (file.status != .success_zir) return error.AnalysisFail;
-    const zir = file.zir;
+    const zir = file.zir.?;
     assert(zir.instructions.items(.tag)[@intFromEnum(inst_info.inst)] == .extended);
     const extended = zir.instructions.items(.data)[@intFromEnum(inst_info.inst)].extended;

src/link.zig+1-2

...	@@ -750,8 +750,7 @@ pub const File = struct {	...	@@ -750,8 +750,7 @@ pub const File = struct {
750	{	750	{
751	const ti = ti_id.resolveFull(&pt.zcu.intern_pool).?;	751	const ti = ti_id.resolveFull(&pt.zcu.intern_pool).?;
752	const file = pt.zcu.fileByIndex(ti.file);	752	const file = pt.zcu.fileByIndex(ti.file);
753	assert(file.zir_loaded);	753	const inst = file.zir.?.instructions.get(@intFromEnum(ti.inst));
754	const inst = file.zir.instructions.get(@intFromEnum(ti.inst));
755	assert(inst.tag == .declaration);	754	assert(inst.tag == .declaration);
756	}	755	}
757		756

src/link/Dwarf.zig+7-10

src/main.zig+49-63

 @@ -3636,7 +3636,7 @@ fn buildOutputType(
     if (show_builtin) {
         const builtin_mod = comp.root_mod.getBuiltinDependency();
-        const source = builtin_mod.builtin_file.?.source;
+        const source = builtin_mod.builtin_file.?.source.?;
         return std.io.getStdOut().writeAll(source);
     }
     switch (listen) {
 @@ -6135,14 +6135,12 @@ fn cmdAstCheck(
     var file: Zcu.File = .{
         .status = .never_loaded,
         .prev_status = .never_loaded,
-        .source_loaded = false,
-        .tree_loaded = false,
-        .zir_loaded = false,
         .sub_file_path = undefined,
-        .source = undefined,
         .stat = undefined,
-        .tree = undefined,
+        .source = null,
-        .zir = undefined,
+        .tree = null,
+        .zir = null,
+        .zoir = null,
         .mod = undefined,
     };
     if (zig_source_file) |file_name| {
 @@ -6163,7 +6161,6 @@ fn cmdAstCheck(
         file.sub_file_path = file_name;
         file.source = source;
-        file.source_loaded = true;
         file.stat = .{
             .size = stat.size,
             .inode = stat.inode,
 @@ -6176,7 +6173,6 @@ fn cmdAstCheck(
         };
         file.sub_file_path = "<stdin>";
         file.source = source;
-        file.source_loaded = true;
         file.stat.size = source.len;
     }
 @@ -6196,17 +6192,15 @@ fn cmdAstCheck(
         .fully_qualified_name = "root",
     });
-    file.tree = try Ast.parse(gpa, file.source, mode);
+    file.tree = try Ast.parse(gpa, file.source.?, mode);
-    file.tree_loaded = true;
+    defer file.tree.?.deinit(gpa);
-    defer file.tree.deinit(gpa);
     switch (mode) {
         .zig => {
-            file.zir = try AstGen.generate(gpa, file.tree);
+            file.zir = try AstGen.generate(gpa, file.tree.?);
-            file.zir_loaded = true;
+            defer file.zir.?.deinit(gpa);
-            defer file.zir.deinit(gpa);
-            if (file.zir.hasCompileErrors()) {
+            if (file.zir.?.hasCompileErrors()) {
                 var wip_errors: std.zig.ErrorBundle.Wip = undefined;
                 try wip_errors.init(gpa);
                 defer wip_errors.deinit();
 @@ -6215,13 +6209,13 @@ fn cmdAstCheck(
                 defer error_bundle.deinit(gpa);
                 error_bundle.renderToStdErr(color.renderOptions());
-                if (file.zir.loweringFailed()) {
+                if (file.zir.?.loweringFailed()) {
                     process.exit(1);
                 }
             }
             if (!want_output_text) {
-                if (file.zir.hasCompileErrors()) {
+                if (file.zir.?.hasCompileErrors()) {
                     process.exit(1);
                 } else {
                     return cleanExit();
 @@ -6233,18 +6227,18 @@ fn cmdAstCheck(
             {
                 const token_bytes = @sizeOf(Ast.TokenList) +
-                    file.tree.tokens.len * (@sizeOf(std.zig.Token.Tag) + @sizeOf(Ast.ByteOffset));
+                    file.tree.?.tokens.len * (@sizeOf(std.zig.Token.Tag) + @sizeOf(Ast.ByteOffset));
-                const tree_bytes = @sizeOf(Ast) + file.tree.nodes.len *
+                const tree_bytes = @sizeOf(Ast) + file.tree.?.nodes.len *
                     (@sizeOf(Ast.Node.Tag) +
                     @sizeOf(Ast.Node.Data) +
                     @sizeOf(Ast.TokenIndex));
-                const instruction_bytes = file.zir.instructions.len *
+                const instruction_bytes = file.zir.?.instructions.len *
                     // Here we don't use @sizeOf(Zir.Inst.Data) because it would include
                     // the debug safety tag but we want to measure release size.
                     (@sizeOf(Zir.Inst.Tag) + 8);
-                const extra_bytes = file.zir.extra.len * @sizeOf(u32);
+                const extra_bytes = file.zir.?.extra.len * @sizeOf(u32);
                 const total_bytes = @sizeOf(Zir) + instruction_bytes + extra_bytes +
-                    file.zir.string_bytes.len * @sizeOf(u8);
+                    file.zir.?.string_bytes.len * @sizeOf(u8);
                 const stdout = io.getStdOut();
                 const fmtIntSizeBin = std.fmt.fmtIntSizeBin;
                 // zig fmt: off
 @@ -6258,27 +6252,27 @@ fn cmdAstCheck(
                     \\# Extra Data Items:   {d} ({})
                     \\
                 , .{
-                    fmtIntSizeBin(file.source.len),
+                    fmtIntSizeBin(file.source.?.len),
-                    file.tree.tokens.len, fmtIntSizeBin(token_bytes),
+                    file.tree.?.tokens.len, fmtIntSizeBin(token_bytes),
-                    file.tree.nodes.len, fmtIntSizeBin(tree_bytes),
+                    file.tree.?.nodes.len, fmtIntSizeBin(tree_bytes),
                     fmtIntSizeBin(total_bytes),
-                    file.zir.instructions.len, fmtIntSizeBin(instruction_bytes),
+                    file.zir.?.instructions.len, fmtIntSizeBin(instruction_bytes),
-                    fmtIntSizeBin(file.zir.string_bytes.len),
+                    fmtIntSizeBin(file.zir.?.string_bytes.len),
-                    file.zir.extra.len, fmtIntSizeBin(extra_bytes),
+                    file.zir.?.extra.len, fmtIntSizeBin(extra_bytes),
                 });
                 // zig fmt: on
             }
             try @import("print_zir.zig").renderAsTextToFile(gpa, &file, io.getStdOut());
-            if (file.zir.hasCompileErrors()) {
+            if (file.zir.?.hasCompileErrors()) {
                 process.exit(1);
             } else {
                 return cleanExit();
             }
         },
         .zon => {
-            const zoir = try ZonGen.generate(gpa, file.tree, .{});
+            const zoir = try ZonGen.generate(gpa, file.tree.?, .{});
             defer zoir.deinit(gpa);
             if (zoir.hasCompileErrors()) {
 @@ -6289,7 +6283,7 @@ fn cmdAstCheck(
                 {
                     const src_path = try file.fullPath(gpa);
                     defer gpa.free(src_path);
-                    try wip_errors.addZoirErrorMessages(zoir, file.tree, file.source, src_path);
+                    try wip_errors.addZoirErrorMessages(zoir, file.tree.?, file.source.?, src_path);
                 }
                 var error_bundle = try wip_errors.toOwnedBundle("");
 @@ -6519,26 +6513,24 @@ fn cmdDumpZir(
     var file: Zcu.File = .{
         .status = .never_loaded,
         .prev_status = .never_loaded,
-        .source_loaded = false,
-        .tree_loaded = false,
-        .zir_loaded = true,
         .sub_file_path = undefined,
-        .source = undefined,
         .stat = undefined,
-        .tree = undefined,
+        .source = null,
+        .tree = null,
         .zir = try Zcu.loadZirCache(gpa, f),
+        .zoir = null,
         .mod = undefined,
     };
-    defer file.zir.deinit(gpa);
+    defer file.zir.?.deinit(gpa);
     {
-        const instruction_bytes = file.zir.instructions.len *
+        const instruction_bytes = file.zir.?.instructions.len *
             // Here we don't use @sizeOf(Zir.Inst.Data) because it would include
             // the debug safety tag but we want to measure release size.
             (@sizeOf(Zir.Inst.Tag) + 8);
-        const extra_bytes = file.zir.extra.len * @sizeOf(u32);
+        const extra_bytes = file.zir.?.extra.len * @sizeOf(u32);
         const total_bytes = @sizeOf(Zir) + instruction_bytes + extra_bytes +
-            file.zir.string_bytes.len * @sizeOf(u8);
+            file.zir.?.string_bytes.len * @sizeOf(u8);
         const stdout = io.getStdOut();
         const fmtIntSizeBin = std.fmt.fmtIntSizeBin;
         // zig fmt: off
 @@ -6550,9 +6542,9 @@ fn cmdDumpZir(
             \\
         , .{
             fmtIntSizeBin(total_bytes),
-            file.zir.instructions.len, fmtIntSizeBin(instruction_bytes),
+            file.zir.?.instructions.len, fmtIntSizeBin(instruction_bytes),
-            fmtIntSizeBin(file.zir.string_bytes.len),
+            fmtIntSizeBin(file.zir.?.string_bytes.len),
-            file.zir.extra.len, fmtIntSizeBin(extra_bytes),
+            file.zir.?.extra.len, fmtIntSizeBin(extra_bytes),
         });
         // zig fmt: on
     }
 @@ -6587,18 +6579,16 @@ fn cmdChangelist(
     var file: Zcu.File = .{
         .status = .never_loaded,
         .prev_status = .never_loaded,
-        .source_loaded = false,
-        .tree_loaded = false,
-        .zir_loaded = false,
         .sub_file_path = old_source_file,
-        .source = undefined,
         .stat = .{
             .size = stat.size,
             .inode = stat.inode,
             .mtime = stat.mtime,
         },
-        .tree = undefined,
+        .source = null,
-        .zir = undefined,
+        .tree = null,
+        .zir = null,
+        .zoir = null,
         .mod = undefined,
     };
 @@ -6613,17 +6603,14 @@ fn cmdChangelist(
     if (amt != stat.size)
         return error.UnexpectedEndOfFile;
     file.source = source;
-    file.source_loaded = true;
-    file.tree = try Ast.parse(gpa, file.source, .zig);
+    file.tree = try Ast.parse(gpa, file.source.?, .zig);
-    file.tree_loaded = true;
+    defer file.tree.?.deinit(gpa);
-    defer file.tree.deinit(gpa);
-    file.zir = try AstGen.generate(gpa, file.tree);
+    file.zir = try AstGen.generate(gpa, file.tree.?);
-    file.zir_loaded = true;
+    defer file.zir.?.deinit(gpa);
-    defer file.zir.deinit(gpa);
-    if (file.zir.loweringFailed()) {
+    if (file.zir.?.loweringFailed()) {
         var wip_errors: std.zig.ErrorBundle.Wip = undefined;
         try wip_errors.init(gpa);
         defer wip_errors.deinit();
 @@ -6652,13 +6639,12 @@ fn cmdChangelist(
     var new_tree = try Ast.parse(gpa, new_source, .zig);
     defer new_tree.deinit(gpa);
-    var old_zir = file.zir;
+    var old_zir = file.zir.?;
     defer old_zir.deinit(gpa);
-    file.zir_loaded = false;
+    file.zir = null;
     file.zir = try AstGen.generate(gpa, new_tree);
-    file.zir_loaded = true;
-    if (file.zir.loweringFailed()) {
+    if (file.zir.?.loweringFailed()) {
         var wip_errors: std.zig.ErrorBundle.Wip = undefined;
         try wip_errors.init(gpa);
         defer wip_errors.deinit();
 @@ -6672,7 +6658,7 @@ fn cmdChangelist(
     var inst_map: std.AutoHashMapUnmanaged(Zir.Inst.Index, Zir.Inst.Index) = .empty;
     defer inst_map.deinit(gpa);
-    try Zcu.mapOldZirToNew(gpa, old_zir, file.zir, &inst_map);
+    try Zcu.mapOldZirToNew(gpa, old_zir, file.zir.?, &inst_map);
     var bw = io.bufferedWriter(io.getStdOut().writer());
     const stdout = bw.writer();

src/print_zir.zig+10-13

 @@ -22,7 +22,7 @@ pub fn renderAsTextToFile(
         .gpa = gpa,
         .arena = arena.allocator(),
         .file = scope_file,
-        .code = scope_file.zir,
+        .code = scope_file.zir.?,
         .indent = 0,
         .parent_decl_node = 0,
         .recurse_decls = true,
 @@ -36,18 +36,18 @@ pub fn renderAsTextToFile(
     try stream.print("%{d} ", .{@intFromEnum(main_struct_inst)});
     try writer.writeInstToStream(stream, main_struct_inst);
     try stream.writeAll("\n");
-    const imports_index = scope_file.zir.extra[@intFromEnum(Zir.ExtraIndex.imports)];
+    const imports_index = scope_file.zir.?.extra[@intFromEnum(Zir.ExtraIndex.imports)];
     if (imports_index != 0) {
         try stream.writeAll("Imports:\n");
-        const extra = scope_file.zir.extraData(Zir.Inst.Imports, imports_index);
+        const extra = scope_file.zir.?.extraData(Zir.Inst.Imports, imports_index);
         var extra_index = extra.end;
         for (0..extra.data.imports_len) |_| {
-            const item = scope_file.zir.extraData(Zir.Inst.Imports.Item, extra_index);
+            const item = scope_file.zir.?.extraData(Zir.Inst.Imports.Item, extra_index);
             extra_index = item.end;
-            const import_path = scope_file.zir.nullTerminatedString(item.data.name);
+            const import_path = scope_file.zir.?.nullTerminatedString(item.data.name);
             try stream.print("  @import(\"{}\") ", .{
                 std.zig.fmtEscapes(import_path),
             });
 @@ -75,7 +75,7 @@ pub fn renderInstructionContext(
         .gpa = gpa,
         .arena = arena.allocator(),
         .file = scope_file,
-        .code = scope_file.zir,
+        .code = scope_file.zir.?,
         .indent = if (indent < 2) 2 else indent,
         .parent_decl_node = parent_decl_node,
         .recurse_decls = false,
 @@ -107,7 +107,7 @@ pub fn renderSingleInstruction(
         .gpa = gpa,
         .arena = arena.allocator(),
         .file = scope_file,
-        .code = scope_file.zir,
+        .code = scope_file.zir.?,
         .indent = indent,
         .parent_decl_node = parent_decl_node,
         .recurse_decls = false,
 @@ -2759,8 +2759,7 @@ const Writer = struct {
     }
     fn writeSrcNode(self: *Writer, stream: anytype, src_node: i32) !void {
-        if (!self.file.tree_loaded) return;
+        const tree = self.file.tree orelse return;
-        const tree = self.file.tree;
         const abs_node = self.relativeToNodeIndex(src_node);
         const src_span = tree.nodeToSpan(abs_node);
         const start = self.line_col_cursor.find(tree.source, src_span.start);
 @@ -2772,8 +2771,7 @@ const Writer = struct {
     }
     fn writeSrcTok(self: *Writer, stream: anytype, src_tok: u32) !void {
-        if (!self.file.tree_loaded) return;
+        const tree = self.file.tree orelse return;
-        const tree = self.file.tree;
         const abs_tok = tree.firstToken(self.parent_decl_node) + src_tok;
         const span_start = tree.tokens.items(.start)[abs_tok];
         const span_end = span_start + @as(u32, @intCast(tree.tokenSlice(abs_tok).len));
 @@ -2786,8 +2784,7 @@ const Writer = struct {
     }
     fn writeSrcTokAbs(self: *Writer, stream: anytype, src_tok: u32) !void {
-        if (!self.file.tree_loaded) return;
+        const tree = self.file.tree orelse return;
-        const tree = self.file.tree;
         const span_start = tree.tokens.items(.start)[src_tok];
         const span_end = span_start + @as(u32, @intCast(tree.tokenSlice(src_tok).len));
         const start = self.line_col_cursor.find(tree.source, span_start);

...	@@ -7649,9 +7649,8 @@ fn analyzeCall(	...	@@ -7649,9 +7649,8 @@ fn analyzeCall(
7649	const nav = ip.getNav(info.owner_nav);	7649	const nav = ip.getNav(info.owner_nav);
7650	const resolved_func_inst = info.zir_body_inst.resolveFull(ip) orelse return error.AnalysisFail;	7650	const resolved_func_inst = info.zir_body_inst.resolveFull(ip) orelse return error.AnalysisFail;
7651	const file = zcu.fileByIndex(resolved_func_inst.file);	7651	const file = zcu.fileByIndex(resolved_func_inst.file);
7652	assert(file.zir_loaded);	7652	const zir_info = file.zir.?.getFnInfo(resolved_func_inst.inst);
7653	const zir_info = file.zir.getFnInfo(resolved_func_inst.inst);	7653	break :b .{ nav, file.zir.?, info.zir_body_inst, resolved_func_inst.inst, zir_info };
7654	break :b .{ nav, file.zir, info.zir_body_inst, resolved_func_inst.inst, zir_info };
7655	} else .{ undefined, undefined, undefined, undefined, undefined };	7654	} else .{ undefined, undefined, undefined, undefined, undefined };
7656		7655
7657	// This is the `inst_map` used when evaluating generic parameters and return types.	7656	// This is the `inst_map` used when evaluating generic parameters and return types.
...	@@ -35328,7 +35327,7 @@ fn backingIntType(	...	@@ -35328,7 +35327,7 @@ fn backingIntType(
35328	break :blk accumulator;	35327	break :blk accumulator;
35329	};	35328	};
35330		35329
35331	const zir = zcu.namespacePtr(struct_type.namespace).fileScope(zcu).zir;	35330	const zir = zcu.namespacePtr(struct_type.namespace).fileScope(zcu).zir.?;
35332	const zir_index = struct_type.zir_index.resolve(ip) orelse return error.AnalysisFail;	35331	const zir_index = struct_type.zir_index.resolve(ip) orelse return error.AnalysisFail;
35333	const extended = zir.instructions.items(.data)[@intFromEnum(zir_index)].extended;	35332	const extended = zir.instructions.items(.data)[@intFromEnum(zir_index)].extended;
35334	assert(extended.opcode == .struct_decl);	35333	assert(extended.opcode == .struct_decl);
...	@@ -35948,7 +35947,7 @@ fn structFields(	...	@@ -35948,7 +35947,7 @@ fn structFields(
35948	const gpa = zcu.gpa;	35947	const gpa = zcu.gpa;
35949	const ip = &zcu.intern_pool;	35948	const ip = &zcu.intern_pool;
35950	const namespace_index = struct_type.namespace;	35949	const namespace_index = struct_type.namespace;
35951	const zir = zcu.namespacePtr(namespace_index).fileScope(zcu).zir;	35950	const zir = zcu.namespacePtr(namespace_index).fileScope(zcu).zir.?;
35952	const zir_index = struct_type.zir_index.resolve(ip) orelse return error.AnalysisFail;	35951	const zir_index = struct_type.zir_index.resolve(ip) orelse return error.AnalysisFail;
35953		35952
35954	const fields_len, _, var extra_index = structZirInfo(zir, zir_index);	35953	const fields_len, _, var extra_index = structZirInfo(zir, zir_index);
...	@@ -36149,7 +36148,7 @@ fn structFieldInits(	...	@@ -36149,7 +36148,7 @@ fn structFieldInits(
36149	assert(!struct_type.haveFieldInits(ip));	36148	assert(!struct_type.haveFieldInits(ip));
36150		36149
36151	const namespace_index = struct_type.namespace;	36150	const namespace_index = struct_type.namespace;
36152	const zir = zcu.namespacePtr(namespace_index).fileScope(zcu).zir;	36151	const zir = zcu.namespacePtr(namespace_index).fileScope(zcu).zir.?;
36153	const zir_index = struct_type.zir_index.resolve(ip) orelse return error.AnalysisFail;	36152	const zir_index = struct_type.zir_index.resolve(ip) orelse return error.AnalysisFail;
36154	const fields_len, _, var extra_index = structZirInfo(zir, zir_index);	36153	const fields_len, _, var extra_index = structZirInfo(zir, zir_index);
36155		36154
...	@@ -36268,7 +36267,7 @@ fn unionFields(	...	@@ -36268,7 +36267,7 @@ fn unionFields(
36268	const zcu = pt.zcu;	36267	const zcu = pt.zcu;
36269	const gpa = zcu.gpa;	36268	const gpa = zcu.gpa;
36270	const ip = &zcu.intern_pool;	36269	const ip = &zcu.intern_pool;
36271	const zir = zcu.namespacePtr(union_type.namespace).fileScope(zcu).zir;	36270	const zir = zcu.namespacePtr(union_type.namespace).fileScope(zcu).zir.?;
36272	const zir_index = union_type.zir_index.resolve(ip) orelse return error.AnalysisFail;	36271	const zir_index = union_type.zir_index.resolve(ip) orelse return error.AnalysisFail;
36273	const extended = zir.instructions.items(.data)[@intFromEnum(zir_index)].extended;	36272	const extended = zir.instructions.items(.data)[@intFromEnum(zir_index)].extended;
36274	assert(extended.opcode == .union_decl);	36273	assert(extended.opcode == .union_decl);

...	@@ -2358,8 +2358,7 @@ fn initWipNavInner(	...	@@ -2358,8 +2358,7 @@ fn initWipNavInner(
2358	const nav = ip.getNav(nav_index);	2358	const nav = ip.getNav(nav_index);
2359	const inst_info = nav.srcInst(ip).resolveFull(ip).?;	2359	const inst_info = nav.srcInst(ip).resolveFull(ip).?;
2360	const file = zcu.fileByIndex(inst_info.file);	2360	const file = zcu.fileByIndex(inst_info.file);
2361	assert(file.zir_loaded);	2361	const decl = file.zir.?.getDeclaration(inst_info.inst);
2362	const decl = file.zir.getDeclaration(inst_info.inst);
2363	log.debug("initWipNav({s}:{d}:{d} %{d} = {})", .{	2362	log.debug("initWipNav({s}:{d}:{d} %{d} = {})", .{
2364	file.sub_file_path,	2363	file.sub_file_path,
2365	decl.src_line + 1,	2364	decl.src_line + 1,
...	@@ -2373,7 +2372,7 @@ fn initWipNavInner(	...	@@ -2373,7 +2372,7 @@ fn initWipNavInner(
2373	switch (nav_key) {	2372	switch (nav_key) {
2374	// Ignore @extern	2373	// Ignore @extern
2375	.@"extern" => \|@"extern"\| if (decl.linkage != .@"extern" or	2374	.@"extern" => \|@"extern"\| if (decl.linkage != .@"extern" or
2376	!@"extern".name.eqlSlice(file.zir.nullTerminatedString(decl.name), ip)) return null,	2375	!@"extern".name.eqlSlice(file.zir.?.nullTerminatedString(decl.name), ip)) return null,
2377	else => {},	2376	else => {},
2378	}	2377	}
2379		2378
...	@@ -2696,8 +2695,7 @@ fn updateComptimeNavInner(dwarf: *Dwarf, pt: Zcu.PerThread, nav_index: InternPoo	...	@@ -2696,8 +2695,7 @@ fn updateComptimeNavInner(dwarf: *Dwarf, pt: Zcu.PerThread, nav_index: InternPoo
2696	const nav = ip.getNav(nav_index);	2695	const nav = ip.getNav(nav_index);
2697	const inst_info = nav.srcInst(ip).resolveFull(ip).?;	2696	const inst_info = nav.srcInst(ip).resolveFull(ip).?;
2698	const file = zcu.fileByIndex(inst_info.file);	2697	const file = zcu.fileByIndex(inst_info.file);
2699	assert(file.zir_loaded);	2698	const decl = file.zir.?.getDeclaration(inst_info.inst);
2700	const decl = file.zir.getDeclaration(inst_info.inst);
2701	log.debug("updateComptimeNav({s}:{d}:{d} %{d} = {})", .{	2699	log.debug("updateComptimeNav({s}:{d}:{d} %{d} = {})", .{
2702	file.sub_file_path,	2700	file.sub_file_path,
2703	decl.src_line + 1,	2701	decl.src_line + 1,
...	@@ -4097,7 +4095,7 @@ pub fn updateContainerType(dwarf: *Dwarf, pt: Zcu.PerThread, type_index: InternP	...	@@ -4097,7 +4095,7 @@ pub fn updateContainerType(dwarf: *Dwarf, pt: Zcu.PerThread, type_index: InternP
4097	// if a newly-tracked instruction can be a type's owner `zir_index`.	4095	// if a newly-tracked instruction can be a type's owner `zir_index`.
4098	comptime assert(Zir.inst_tracking_version == 0);	4096	comptime assert(Zir.inst_tracking_version == 0);
4099		4097
4100	const decl_inst = file.zir.instructions.get(@intFromEnum(inst_info.inst));	4098	const decl_inst = file.zir.?.instructions.get(@intFromEnum(inst_info.inst));
4101	const name_strat: Zir.Inst.NameStrategy = switch (decl_inst.tag) {	4099	const name_strat: Zir.Inst.NameStrategy = switch (decl_inst.tag) {
4102	.struct_init, .struct_init_ref, .struct_init_anon => .anon,	4100	.struct_init, .struct_init_ref, .struct_init_anon => .anon,
4103	.extended => switch (decl_inst.data.extended.opcode) {	4101	.extended => switch (decl_inst.data.extended.opcode) {
...	@@ -4301,14 +4299,13 @@ pub fn updateLineNumber(dwarf: Dwarf, zcu: Zcu, zir_index: InternPool.TrackedI	...	@@ -4301,14 +4299,13 @@ pub fn updateLineNumber(dwarf: Dwarf, zcu: Zcu, zir_index: InternPool.TrackedI
4301	const inst_info = zir_index.resolveFull(ip).?;	4299	const inst_info = zir_index.resolveFull(ip).?;
4302	assert(inst_info.inst != .main_struct_inst);	4300	assert(inst_info.inst != .main_struct_inst);
4303	const file = zcu.fileByIndex(inst_info.file);	4301	const file = zcu.fileByIndex(inst_info.file);
4304	assert(file.zir_loaded);	4302	const decl = file.zir.?.getDeclaration(inst_info.inst);
4305	const decl = file.zir.getDeclaration(inst_info.inst);
4306	log.debug("updateLineNumber({s}:{d}:{d} %{d} = {s})", .{	4303	log.debug("updateLineNumber({s}:{d}:{d} %{d} = {s})", .{
4307	file.sub_file_path,	4304	file.sub_file_path,
4308	decl.src_line + 1,	4305	decl.src_line + 1,
4309	decl.src_column + 1,	4306	decl.src_column + 1,
4310	@intFromEnum(inst_info.inst),	4307	@intFromEnum(inst_info.inst),
4311	file.zir.nullTerminatedString(decl.name),	4308	file.zir.?.nullTerminatedString(decl.name),
4312	});	4309	});
4313		4310
4314	var line_buf: [4]u8 = undefined;	4311	var line_buf: [4]u8 = undefined;
...	@@ -4661,7 +4658,7 @@ pub fn flushModule(dwarf: *Dwarf, pt: Zcu.PerThread) FlushError!void {	...	@@ -4661,7 +4658,7 @@ pub fn flushModule(dwarf: *Dwarf, pt: Zcu.PerThread) FlushError!void {
4661	.target_unit = StringSection.unit,	4658	.target_unit = StringSection.unit,
4662	.target_entry = (try dwarf.debug_line_str.addString(	4659	.target_entry = (try dwarf.debug_line_str.addString(
4663	dwarf,	4660	dwarf,
4664	if (file.mod.builtin_file == file) file.source else "",	4661	if (file.mod.builtin_file == file) file.source.? else "",
4665	)).toOptional(),	4662	)).toOptional(),
4666	});	4663	});
4667	header.appendNTimesAssumeCapacity(0, dwarf.sectionOffsetBytes());	4664	header.appendNTimesAssumeCapacity(0, dwarf.sectionOffsetBytes());