Commit e82cd53df483aa08354de935879a0f9935ba4a1b | zig

author	Andrew Kelley <andrew@ziglang.org> 2018-09-03 21:24:20-04:00
committer	Andrew Kelley <andrew@ziglang.org> 2018-09-03 21:24:20-04:00
log	e82cd53df483aa08354de935879a0f9935ba4a1b
tree	67f249e4ac3728682975a97af5cbc47d3eb4b6f0
parent	a11e73bee2266d4c568bdf9b23c891ac1365bb09
signature	Commit is signed but in an unrecognized format.

fix incorrect value for inline loop

09cc1dc66067f378 failed to handle mem_slot_index correctly

closes #1436

2 files changed, 28 insertions(+), 11 deletions(-)

src
- ir.cpp
test
- cases
  - eval.zig

src/ir.cpp+19-11

 @@ -17,8 +17,7 @@
 #include "util.hpp"
 struct IrExecContext {
-    ConstExprValue *mem_slot_list;
+    ZigList<ConstExprValue *> mem_slot_list;
-    size_t mem_slot_count;
 };
 struct IrBuilder {
 @@ -12496,13 +12495,20 @@ static TypeTableEntry *ir_analyze_instruction_decl_var(IrAnalyze *ira, IrInstruc
         }
     }
-    if (var->value->type != nullptr && var->value->type != result_type && !is_comptime_var) {
+    if (var->value->type != nullptr && !is_comptime_var) {
         // This is at least the second time we've seen this variable declaration during analysis.
         // This means that this is actually a different variable due to, e.g. an inline while loop.
         // We make a new variable so that it can hold a different type, and so the debug info can
         // be distinct.
         VariableTableEntry *new_var = create_local_var(ira->codegen, var->decl_node, var->child_scope,
             &var->name, var->src_is_const, var->gen_is_const, var->shadowable, var->is_comptime, true);
+        new_var->owner_exec = var->owner_exec;
+        if (var->mem_slot_index != SIZE_MAX) {
+            ConstExprValue *vals = create_const_vals(1);
+            new_var->mem_slot_index = ira->exec_context.mem_slot_list.length;
+            ira->exec_context.mem_slot_list.append(vals);
+        }
         var->next_var = new_var;
         var = new_var;
     }
 @@ -12525,10 +12531,9 @@ static TypeTableEntry *ir_analyze_instruction_decl_var(IrAnalyze *ira, IrInstruc
     if (casted_init_value->value.special != ConstValSpecialRuntime) {
         if (var->mem_slot_index != SIZE_MAX) {
-            assert(var->mem_slot_index < ira->exec_context.mem_slot_count);
+            assert(var->mem_slot_index < ira->exec_context.mem_slot_list.length);
-            ConstExprValue *mem_slot = &ira->exec_context.mem_slot_list[var->mem_slot_index];
+            ConstExprValue *mem_slot = ira->exec_context.mem_slot_list.at(var->mem_slot_index);
-            copy_const_val(mem_slot, &casted_init_value->value,
+            copy_const_val(mem_slot, &casted_init_value->value, !is_comptime_var || var->gen_is_const);
-                    !is_comptime_var || var->gen_is_const);
             if (is_comptime_var || (var_class_requires_const && var->gen_is_const)) {
                 ir_build_const_from(ira, &decl_var_instruction->base);
 @@ -13012,8 +13017,8 @@ static IrInstruction *ir_get_var_ptr(IrAnalyze *ira, IrInstruction *instruction,
             assert(var->owner_exec != nullptr);
             assert(var->owner_exec->analysis != nullptr);
             IrExecContext *exec_context = &var->owner_exec->analysis->exec_context;
-            assert(var->mem_slot_index < exec_context->mem_slot_count);
+            assert(var->mem_slot_index < exec_context->mem_slot_list.length);
-            mem_slot = &exec_context->mem_slot_list[var->mem_slot_index];
+            mem_slot = exec_context->mem_slot_list.at(var->mem_slot_index);
         }
     }
 @@ -21228,8 +21233,11 @@ TypeTableEntry *ir_analyze(CodeGen *codegen, IrExecutable *old_exec, IrExecutabl
     ira->new_irb.codegen = codegen;
     ira->new_irb.exec = new_exec;
-    ira->exec_context.mem_slot_count = ira->old_irb.exec->mem_slot_count;
+    ConstExprValue *vals = create_const_vals(ira->old_irb.exec->mem_slot_count);
-    ira->exec_context.mem_slot_list = create_const_vals(ira->exec_context.mem_slot_count);
+    ira->exec_context.mem_slot_list.resize(ira->old_irb.exec->mem_slot_count);
+    for (size_t i = 0; i < ira->exec_context.mem_slot_list.length; i += 1) {
+        ira->exec_context.mem_slot_list.items[i] = &vals[i];
+    }
     IrBasicBlock *old_entry_bb = ira->old_irb.exec->basic_block_list.at(0);
     IrBasicBlock *new_entry_bb = ir_get_new_bb(ira, old_entry_bb, nullptr);

test/cases/eval.zig+9

...	@@ -665,3 +665,12 @@ fn testVarInsideInlineLoop(args: ...) void {	...	@@ -665,3 +665,12 @@ fn testVarInsideInlineLoop(args: ...) void {
665	if (i == 1) assert(x == 42);	665	if (i == 1) assert(x == 42);
666	}	666	}
667	}	667	}
		668
		669	test "inline for with same type but different values" {
		670	var res: usize = 0;
		671	inline for ([]type{ [2]u8, [1]u8, [2]u8 }) \|T\| {
		672	var a: T = undefined;
		673	res += a.len;
		674	}
		675	assert(res == 5);
		676	}