diff --git a/BRANCH_TODO b/BRANCH_TODO index c1e94369b3d448626e7aa9183102c65deea5226c..1f27224f809c6713df9c091511d5ca621f1da922 100644 --- a/BRANCH_TODO +++ b/BRANCH_TODO @@ -65,3 +65,5 @@ * in SwitchProng resolve, make sure AST tree gets loaded. It will be unloaded if using cached ZIR. + + * make AstGen smart enough to omit elided store_to_block_ptr instructions diff --git a/src/Sema.zig b/src/Sema.zig index 626624110ee93bbb83f875a84008cd5a76ce17ce..895ac84dd065e28103a07770124b3c581e6bb0cf 100644 --- a/src/Sema.zig +++ b/src/Sema.zig @@ -1461,6 +1461,11 @@ fn zirStoreToBlockPtr(sema: *Sema, block: *Scope.Block, inst: Zir.Inst.Index) In defer tracy.end(); const bin_inst = sema.code.instructions.items(.data)[inst].bin; + if (bin_inst.lhs == .none) { + // This is an elided instruction, but AstGen was not smart enough + // to omit it. + return; + } const ptr = try sema.resolveInst(bin_inst.lhs); const value = try sema.resolveInst(bin_inst.rhs); const ptr_ty = try sema.mod.simplePtrType(sema.arena, value.ty, true, .One); diff --git a/src/Zir.zig b/src/Zir.zig index 274098fa2819af0b60c13f1da62ab14bcd468ef2..73f8e3e43bfc75df591e6bbfeb907e7e6c042280 100644 --- a/src/Zir.zig +++ b/src/Zir.zig @@ -484,6 +484,8 @@ pub const Inst = struct { /// Same as `store` but the type of the value being stored will be used to infer /// the block type. The LHS is the pointer to store to. /// Uses the `bin` union field. + /// If the pointer is none, it means this instruction has been elided in + /// AstGen, but AstGen was unable to actually omit it from the ZIR code. store_to_block_ptr, /// Same as `store` but the type of the value being stored will be used to infer /// the pointer type.