From f73d7aa1821d6c7d71b89157afc045e04b10e96e Mon Sep 17 00:00:00 2001 From: levinqua Date: Sat, 15 Aug 2026 17:05:31 +0200 Subject: [PATCH] tank/tapi/parse.zig: prefer ensureUnusedCapacity over ensureTotalCapacity ensureUnusedCapacity should be preferred over ensureTotalCapacity. By using ensureTotalCapacity the parsing could fail the assumption that there is enough unused capacity if node.string_value would already have elements. However afaict both functions were only called with string_value = .empty. Therefore behavior should remain unchanged. --- src/link/tapi/parse.zig | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/link/tapi/parse.zig b/src/link/tapi/parse.zig index 487b609bcab3bd93fa38a2fa25026ebfc93cff85..f80150fc66539f3cf40d9a9d0031cd95dae87e82 100644 --- a/src/link/tapi/parse.zig +++ b/src/link/tapi/parse.zig @@ -631,7 +631,7 @@ const Parser = struct { assert(raw[0] == '\'' and raw[raw.len - 1] == '\''); const raw_no_quotes = raw[1 .. raw.len - 1]; - try node.string_value.ensureTotalCapacity(self.allocator, raw_no_quotes.len); + try node.string_value.ensureUnusedCapacity(self.allocator, raw_no_quotes.len); var state: enum { start, @@ -665,7 +665,7 @@ const Parser = struct { assert(raw[0] == '"' and raw[raw.len - 1] == '"'); const raw_no_quotes = raw[1 .. raw.len - 1]; - try node.string_value.ensureTotalCapacity(self.allocator, raw_no_quotes.len); + try node.string_value.ensureUnusedCapacity(self.allocator, raw_no_quotes.len); var state: enum { start, -- 2.54.0