Commit fd43baa9ad37217a5715c1e3cfad2d2d78558d1f | zig

author	Jay Petacat <jay@jayschwa.net> 2023-10-09 22:24:14-06:00
committer	Andrew Kelley <andrew@ziglang.org> 2024-01-16 15:05:38-08:00
log	fd43baa9ad37217a5715c1e3cfad2d2d78558d1f
tree	c0d75d8a8c92038f05ea78f961b5dd7b23e0efbc
parent	a338c279f82bfeb68e37b40cd4fc59557336b6ce

byos: Ease `GeneralPurposeAllocator` integration

These changes enable me to use `GeneralPurposeAllocator` with my "Bring
Your Own OS" package. The previous checks for a freestanding target have
been expanded to `@hasDecl` checks.

- `root.os.heap.page_allocator` is used if it exists.
- `debug.isValidMemory` only calls `os.msync` if it's supported.

2 files changed, 20 insertions(+), 17 deletions(-)

lib
- std
  - debug.zig
  - heap.zig

lib/std/debug.zig+15-14

 @@ -667,20 +667,7 @@ pub const StackIterator = struct {
         if (aligned_address == 0) return false;
         const aligned_memory = @as([*]align(mem.page_size) u8, @ptrFromInt(aligned_address))[0..mem.page_size];
-        if (native_os != .windows) {
+        if (native_os == .windows) {
-            if (native_os != .wasi) {
-                os.msync(aligned_memory, os.MSF.ASYNC) catch |err| {
-                    switch (err) {
-                        os.MSyncError.UnmappedMemory => {
-                            return false;
-                        },
-                        else => unreachable,
-                    }
-                };
-            }
-            return true;
-        } else {
             const w = os.windows;
             var memory_info: w.MEMORY_BASIC_INFORMATION = undefined;
 @@ -700,6 +687,20 @@ pub const StackIterator = struct {
                 return false;
             }
+            return true;
+        } else if (@hasDecl(os.system, "msync") and native_os != .wasi) {
+            os.msync(aligned_memory, os.MSF.ASYNC) catch |err| {
+                switch (err) {
+                    os.MSyncError.UnmappedMemory => {
+                        return false;
+                    },
+                    else => unreachable,
+                }
+            };
+            return true;
+        } else {
+            // We are unable to determine validity of memory on this target.
             return true;
         }
     }

lib/std/heap.zig+5-3

 @@ -223,7 +223,11 @@ fn rawCFree(
 /// This allocator makes a syscall directly for every allocation and free.
 /// Thread-safe and lock-free.
-pub const page_allocator = if (builtin.target.isWasm())
+pub const page_allocator = if (@hasDecl(root, "os") and
+    @hasDecl(root.os, "heap") and
+    @hasDecl(root.os.heap, "page_allocator"))
+    root.os.heap.page_allocator
+else if (builtin.target.isWasm())
     Allocator{
         .ptr = undefined,
         .vtable = &WasmPageAllocator.vtable,
 @@ -233,8 +237,6 @@ else if (builtin.target.os.tag == .plan9)
         .ptr = undefined,
         .vtable = &SbrkAllocator(std.os.plan9.sbrk).vtable,
     }
-else if (builtin.target.os.tag == .freestanding)
-    root.os.heap.page_allocator
 else
     Allocator{
         .ptr = undefined,