From fdd9cf09287b5e397ad9b2c960c833a7de075e4c Mon Sep 17 00:00:00 2001 From: Andrew Kelley Date: Tue, 12 Jun 2018 15:14:32 -0400 Subject: [PATCH] better debugging for CI failures of std.atomic --- std/atomic/queue.zig | 14 ++++++++++++-- std/atomic/stack.zig | 14 ++++++++++++-- 2 files changed, 24 insertions(+), 4 deletions(-) diff --git a/std/atomic/queue.zig b/std/atomic/queue.zig index 4f856d9e017bb9434f65d16ff49ca1f04ea713d8..2a4840738352daac4517a568c8ebc3e59d962174 100644 --- a/std/atomic/queue.zig +++ b/std/atomic/queue.zig @@ -94,8 +94,18 @@ test "std.atomic.queue" { for (getters) |t| t.wait(); - std.debug.assert(context.put_sum == context.get_sum); - std.debug.assert(context.get_count == puts_per_thread * put_thread_count); + if (context.put_sum != context.get_sum) { + std.debug.panic("failure\nput_sum:{} != get_sum:{}", context.put_sum, context.get_sum); + } + + if (context.get_count != puts_per_thread * put_thread_count) { + std.debug.panic( + "failure\nget_count:{} != puts_per_thread:{} * put_thread_count:{}", + context.get_count, + u32(puts_per_thread), + u32(put_thread_count), + ); + } } fn startPuts(ctx: *Context) u8 { diff --git a/std/atomic/stack.zig b/std/atomic/stack.zig index 77fa1a9100bc5e4bf02be37b75d44b0f83cdbb96..c6b368b990907dd70256e107a73e0b7c99cf68ef 100644 --- a/std/atomic/stack.zig +++ b/std/atomic/stack.zig @@ -97,8 +97,18 @@ test "std.atomic.stack" { for (getters) |t| t.wait(); - std.debug.assert(context.put_sum == context.get_sum); - std.debug.assert(context.get_count == puts_per_thread * put_thread_count); + if (context.put_sum != context.get_sum) { + std.debug.panic("failure\nput_sum:{} != get_sum:{}", context.put_sum, context.get_sum); + } + + if (context.get_count != puts_per_thread * put_thread_count) { + std.debug.panic( + "failure\nget_count:{} != puts_per_thread:{} * put_thread_count:{}", + context.get_count, + u32(puts_per_thread), + u32(put_thread_count), + ); + } } fn startPuts(ctx: *Context) u8 { -- 2.54.0