Commit 06879041acfe73e62f549a412d9f012a190113a3 | zig

author	Alex Rønne Petersen <alex@alexrp.com> 2026-02-04 00:00:06+01:00
committer	Alex Rønne Petersen <alex@alexrp.com> 2026-02-04 20:44:37+01:00
log	06879041acfe73e62f549a412d9f012a190113a3
tree	885421fdb817ffec1d3cb9a645ca06c99bfabb2d
parent	a816f9e245b7f0db96fddc727e2c7004bdb88056
signature	Signed by SSH key SHA256:7B/LJ7bpR1eX8aCXSr4mtd5M45VMPKcx9zY8e95b5QM

link.Lld: disable parallel linking on NetBSD host

To work around NetBSD 10.1 malloc bugs.

1 files changed, 16 insertions(+), 0 deletions(-)

src
- link
  - Lld.zig

src/link/Lld.zig+16

 @@ -356,6 +356,16 @@ fn linkAsArchive(lld: *Lld, arena: Allocator) !void {
     if (bad) return error.UnableToWriteArchive;
 }
+fn addCommonArgs(argv: *std.array_list.Managed([]const u8), coff: bool) !void {
+    if (builtin.os.tag == .netbsd) {
+        // NetBSD 10.1's `malloc` appears to have some nasty bugs that occur
+        // when doing parallel linking in LLD, manifesting as input and/or
+        // output section memory randomly being unmapped. So just don't do
+        // parallel linking for now.
+        try argv.append(if (coff) "-threads:1" else "--threads=1");
+    }
+}
 fn coffLink(lld: *Lld, arena: Allocator) !void {
     const comp = lld.base.comp;
     const gpa = comp.gpa;
 @@ -418,6 +428,7 @@ fn coffLink(lld: *Lld, arena: Allocator) !void {
         // it calls exit() and does not reset all global data between invocations.
         const linker_command = "lld-link";
         try argv.appendSlice(&[_][]const u8{ comp.self_exe_path.?, linker_command });
+        try addCommonArgs(&argv, true);
         if (target.isMinGW()) {
             try argv.append("-lldmingw");
 @@ -836,6 +847,8 @@ fn elfLink(lld: *Lld, arena: Allocator) !void {
         // it calls exit() and does not reset all global data between invocations.
         const linker_command = "ld.lld";
         try argv.appendSlice(&[_][]const u8{ comp.self_exe_path.?, linker_command });
+        try addCommonArgs(&argv, false);
         if (is_obj) {
             try argv.append("-r");
         }
 @@ -1401,6 +1414,8 @@ fn wasmLink(lld: *Lld, arena: Allocator) !void {
         // it calls exit() and does not reset all global data between invocations.
         const linker_command = "wasm-ld";
         try argv.appendSlice(&[_][]const u8{ comp.self_exe_path.?, linker_command });
+        try addCommonArgs(&argv, false);
         try argv.append("--error-limit=0");
         if (comp.config.lto != .none) {
 @@ -1724,6 +1739,7 @@ fn spawnLld(comp: *Compilation, arena: Allocator, argv: []const []const u8) !voi
     if (stderr.len > 0) log.warn("unexpected LLD stderr:\n{s}", .{stderr});
 }
+const builtin = @import("builtin");
 const std = @import("std");
 const Io = std.Io;
 const Allocator = std.mem.Allocator;