Commit 092352ec63d3a4e9ff59a5d8ad8f119bf0eda468 | zig

author	Alex Rønne Petersen <alex@alexrp.com> 2025-05-18 20:55:56+02:00
committer	Alex Rønne Petersen <alex@alexrp.com> 2025-05-19 00:22:03+02:00
log	092352ec63d3a4e9ff59a5d8ad8f119bf0eda468
tree	df59739ecb008fb3412477964932933c7ec1d8bc
parent	846571ce4e9840c278eb5bad1eb5221e84cf92de
signature	Signed by SSH key SHA256:7B/LJ7bpR1eX8aCXSr4mtd5M45VMPKcx9zY8e95b5QM

compiler-rt, zigc: Use hidden visibility except when testing.

This prevents symbols from these libraries from polluting the dynamic symbol
tables of binaries built with Zig. The downside is that we no longer deduplicate
the symbols at run time due to weak linkage.

Closes #7935.
Closes #13303.
Closes #19342.

2 files changed, 5 insertions(+), 3 deletions(-)

lib
- c
  - common.zig
- compiler_rt
  - common.zig

lib/c/common.zig+1-1

...	...	@@ -9,7 +9,7 @@ else
9	9	/// Determines the symbol's visibility to other objects.
10	10	/// For WebAssembly this allows the symbol to be resolved to other modules, but will not
11	11	/// export it to the host runtime.
12		pub const visibility: std.builtin.SymbolVisibility = if (builtin.cpu.arch.isWasm() and linkage != .internal)
	12	pub const visibility: std.builtin.SymbolVisibility = if (linkage != .internal)
13	13	.hidden
14	14	else
15	15	.default;

lib/compiler_rt/common.zig+4-2

...	...	@@ -13,8 +13,10 @@ else
13	13	/// Determines the symbol's visibility to other objects.
14	14	/// For WebAssembly this allows the symbol to be resolved to other modules, but will not
15	15	/// export it to the host runtime.
16		pub const visibility: std.builtin.SymbolVisibility =
17		if (builtin.target.cpu.arch.isWasm() and linkage != .internal) .hidden else .default;
	16	pub const visibility: std.builtin.SymbolVisibility = if (linkage != .internal)
	17	.hidden
	18	else
	19	.default;
18	20
19	21	pub const PreferredLoadStoreElement = element: {
20	22	if (std.simd.suggestVectorLength(u8)) \|vec_size\| {