Commit 0dbcf97551765d3abbaea5fb0b9e94e5e0be1b14 | zig

author	Andrew Kelley <andrew@ziglang.org> 2025-12-26 14:08:45-08:00
committer	Andrew Kelley <andrew@ziglang.org> 2025-12-26 19:58:56-08:00
log	0dbcf97551765d3abbaea5fb0b9e94e5e0be1b14
tree	b98ef422ef235478ae678793905ef8e3f98d9e84
parent	eb0d5b1377089ff6c51ffc6de6963b9897c906e4

it should unconditionally close the opened file descriptor, not only on
error.

1 files changed, 8 insertions(+), 7 deletions(-)

lib/std/Io/Threaded.zig+8-7

 @@ -4165,7 +4165,7 @@ fn dirRealPathFilePosix(userdata: ?*anyopaque, dir: Dir, sub_path: []const u8, o
             },
         }
     };
-    errdefer posix.close(fd);
+    defer posix.close(fd);
     return realPathPosix(current_thread, fd, out_buffer);
 }
 @@ -4290,16 +4290,17 @@ fn realPathPosix(current_thread: *Thread, fd: posix.fd_t, out_buffer: []u8) File
                         try current_thread.checkCancel();
                         continue;
                     },
-                    else => |e| {
+                    .BADF => {
                         current_thread.endSyscall();
-                        switch (e) {
+                        return error.FileNotFound;
-                            .BADF => return error.FileNotFound,
+                    },
-                            else => |err| return posix.unexpectedErrno(err),
+                    else => |err| {
-                        }
+                        current_thread.endSyscall();
+                        return posix.unexpectedErrno(err);
                     },
                 }
             }
-            const len = std.mem.indexOfScalar(u8, &k_file.path, 0) orelse k_file.path.len;
+            const len = std.mem.findScalar(u8, &k_file.path, 0) orelse k_file.path.len;
             if (len == 0) return error.NameTooLong;
             return len;
         },