authorgravatar for jacobly@ziglang.orgJacob Young <jacobly@ziglang.org> 2023-05-08 18:35:03-04:00
committergravatar for jacobly@ziglang.orgJacob Young <jacobly@ziglang.org> 2023-05-15 03:07:51-04:00
log1667e831cf8099271d97c9391fe4400622e6f96f
treed63844531c59d5722b6293b2f0ac18b241ea6c23
parente98e58691f2c0759c8534080446cf6faecd30eb0

x86_64: fix issues with getting float fields


1 files changed, 18 insertions(+), 19 deletions(-)

src/arch/x86_64/CodeGen.zig+18-19
......@@ -5325,8 +5325,10 @@ fn airStructFieldVal(self: *Self, inst: Air.Inst.Index) !void {
53255325 const index = extra.field_index;
53265326
53275327 const container_ty = self.air.typeOf(operand);
5328 const container_rc = regClassForType(container_ty);
53285329 const field_ty = container_ty.structFieldType(index);
53295330 if (!field_ty.hasRuntimeBitsIgnoreComptime()) break :result .none;
5331 const field_rc = regClassForType(field_ty);
53305332
53315333 const src_mcv = try self.resolveInst(operand);
53325334 const field_off = switch (container_ty.containerLayout()) {
......@@ -5410,30 +5412,23 @@ fn airStructFieldVal(self: *Self, inst: Air.Inst.Index) !void {
54105412 if (field_extra_bits > 0) try self.truncateRegister(field_ty, dst_reg);
54115413
54125414 const dst_mcv = MCValue{ .register = dst_reg };
5413 const dst_rc = regClassForType(field_ty);
5414 if (dst_rc.eql(gp)) break :result dst_mcv;
5415
5416 const result_reg = try self.register_manager.allocReg(inst, dst_rc);
5417 try self.genSetReg(result_reg, field_ty, dst_mcv);
5418 break :result .{ .register = result_reg };
5415 break :result if (field_rc.supersetOf(gp))
5416 dst_mcv
5417 else
5418 try self.copyToRegisterWithInstTracking(inst, field_ty, dst_mcv);
54195419 },
54205420 .register => |reg| {
54215421 const reg_lock = self.register_manager.lockRegAssumeUnused(reg);
54225422 defer self.register_manager.unlockReg(reg_lock);
54235423
5424 const dst_mcv = if (self.reuseOperand(inst, operand, 0, src_mcv))
5425 src_mcv
5424 const dst_reg = if (src_mcv.isRegister() and field_rc.supersetOf(container_rc) and
5425 self.reuseOperand(inst, operand, 0, src_mcv))
5426 src_mcv.getReg().?
54265427 else
5427 try self.copyToRegisterWithInstTracking(
5428 inst,
5429 Type.usize,
5430 .{ .register = reg.to64() },
5431 );
5432 const dst_mcv_lock: ?RegisterLock = switch (dst_mcv) {
5433 .register => |a_reg| self.register_manager.lockReg(a_reg),
5434 else => null,
5435 };
5436 defer if (dst_mcv_lock) |lock| self.register_manager.unlockReg(lock);
5428 try self.copyToTmpRegister(Type.usize, .{ .register = reg.to64() });
5429 const dst_mcv = MCValue{ .register = dst_reg };
5430 const dst_lock = self.register_manager.lockReg(dst_reg);
5431 defer if (dst_lock) |lock| self.register_manager.unlockReg(lock);
54375432
54385433 // Shift by struct_field_offset.
54395434 try self.genShiftBinOpMir(
......@@ -5460,7 +5455,11 @@ fn airStructFieldVal(self: *Self, inst: Air.Inst.Index) !void {
54605455 registerAlias(dst_mcv.register, field_byte_size),
54615456 );
54625457 }
5463 break :result dst_mcv;
5458
5459 break :result if (field_rc.supersetOf(gp))
5460 dst_mcv
5461 else
5462 try self.copyToRegisterWithInstTracking(inst, field_ty, dst_mcv);
54645463 },
54655464 .register_overflow => |ro| {
54665465 switch (index) {