authorgravatar for kubkon@jakubkonka.comJakub Konka <kubkon@jakubkonka.com> 2021-04-08 08:17:38+02:00
committergravatar for kubkon@jakubkonka.comJakub Konka <kubkon@jakubkonka.com> 2021-04-13 10:56:03+02:00
log23bb6fa9f45d99f97e64bea7011702db19718914
tree67e3f6a0a34461cbcd0646429c350f330e10ad88
parentdb44a7803fac38096526e9b8baba60d966d77ab6

zld: flush MachO


3 files changed, 161 insertions(+), 156 deletions(-)

src/link/MachO/Object.zig+1-1
......@@ -183,7 +183,7 @@ pub fn readLoadCommands(self: *Object, reader: anytype) !void {
183183 cmd.LinkeditData.dataoff += offset;
184184 },
185185 else => {
186 log.debug("Unknown load command detected: 0x{x}.", .{cmd.cmd()});
186 log.warn("Unknown load command detected: 0x{x}.", .{cmd.cmd()});
187187 },
188188 }
189189 self.load_commands.appendAssumeCapacity(cmd);
src/link/MachO/Zld.zig+144-140
......@@ -283,7 +283,7 @@ pub fn link(self: *Zld, files: []const []const u8, out_path: []const u8) !void {
283283 try self.allocateStubsAndGotEntries();
284284 try self.writeStubHelperCommon();
285285 try self.resolveRelocsAndWriteSections();
286 // try self.flush();
286 try self.flush();
287287}
288288
289289fn parseInputFiles(self: *Zld, files: []const []const u8) !void {
......@@ -386,7 +386,7 @@ fn mapAndUpdateSections(
386386 .target_sect_id = target_sect_id,
387387 .offset = @intCast(u32, offset),
388388 });
389 log.debug("{s}: {s},{s} mapped to {s},{s} from 0x{x} to 0x{x}", .{
389 log.warn("{s}: {s},{s} mapped to {s},{s} from 0x{x} to 0x{x}", .{
390390 object.name,
391391 parseName(&source_sect.segname),
392392 parseName(&source_sect.sectname),
......@@ -596,7 +596,7 @@ fn updateMetadata(self: *Zld) !void {
596596 });
597597 },
598598 else => {
599 log.debug("unhandled section type 0x{x} for '{s}/{s}'", .{ flags, segname, sectname });
599 log.warn("unhandled section type 0x{x} for '{s}/{s}'", .{ flags, segname, sectname });
600600 },
601601 }
602602 }
......@@ -620,7 +620,7 @@ fn updateMetadata(self: *Zld) !void {
620620
621621 const segname = parseName(&source_sect.segname);
622622 const sectname = parseName(&source_sect.sectname);
623 log.debug("section '{s}/{s}' will be unmapped", .{ segname, sectname });
623 log.warn("section '{s}/{s}' will be unmapped", .{ segname, sectname });
624624 try self.unhandled_sections.putNoClobber(self.allocator, .{
625625 .object_id = object_id,
626626 .source_sect_id = source_sect_id,
......@@ -964,7 +964,7 @@ fn allocateSymbols(self: *Zld) !void {
964964 const target_addr = target_sect.addr + target_mapping.offset;
965965 const n_value = source_sym.inner.n_value - source_sect.addr + target_addr;
966966
967 log.debug("resolving '{s}' symbol at 0x{x}", .{ entry.key, n_value });
967 log.warn("resolving '{s}' symbol at 0x{x}", .{ entry.key, n_value });
968968
969969 // TODO there might be a more generic way of doing this.
970970 var n_sect: u8 = 0;
......@@ -1172,7 +1172,7 @@ fn writeLazySymbolPointer(self: *Zld, index: u32) !void {
11721172 var buf: [@sizeOf(u64)]u8 = undefined;
11731173 mem.writeIntLittle(u64, &buf, end);
11741174 const off = la_symbol_ptr.offset + index * @sizeOf(u64);
1175 log.debug("writing lazy symbol pointer entry 0x{x} at 0x{x}", .{ end, off });
1175 log.warn("writing lazy symbol pointer entry 0x{x} at 0x{x}", .{ end, off });
11761176 try self.file.?.pwriteAll(&buf, off);
11771177}
11781178
......@@ -1185,7 +1185,7 @@ fn writeStub(self: *Zld, index: u32) !void {
11851185 const stub_off = stubs.offset + index * stubs.reserved2;
11861186 const stub_addr = stubs.addr + index * stubs.reserved2;
11871187 const la_ptr_addr = la_symbol_ptr.addr + index * @sizeOf(u64);
1188 log.debug("writing stub at 0x{x}", .{stub_off});
1188 log.warn("writing stub at 0x{x}", .{stub_off});
11891189 var code = try self.allocator.alloc(u8, stubs.reserved2);
11901190 defer self.allocator.free(code);
11911191 switch (self.arch.?) {
......@@ -1444,7 +1444,7 @@ fn resolveSymbols(self: *Zld) !void {
14441444
14451445fn resolveStubsAndGotEntries(self: *Zld) !void {
14461446 for (self.objects.items) |object, object_id| {
1447 log.debug("\nresolving stubs and got entries from {s}", .{object.name});
1447 log.warn("\nresolving stubs and got entries from {s}", .{object.name});
14481448
14491449 for (object.sections.items) |sect| {
14501450 const relocs = sect.relocs orelse continue;
......@@ -1469,7 +1469,7 @@ fn resolveStubsAndGotEntries(self: *Zld) !void {
14691469 .local_index = if (is_import) 0 else reloc.target.symbol,
14701470 });
14711471
1472 log.debug(" | found GOT entry {s}: {}", .{ sym_name, self.got_entries.get(sym_name) });
1472 log.warn(" | found GOT entry {s}: {}", .{ sym_name, self.got_entries.get(sym_name) });
14731473 },
14741474 else => {
14751475 const sym = object.symtab.items[reloc.target.symbol];
......@@ -1486,7 +1486,7 @@ fn resolveStubsAndGotEntries(self: *Zld) !void {
14861486 const index = @intCast(u32, self.stubs.items().len);
14871487 try self.stubs.putNoClobber(self.allocator, name, index);
14881488
1489 log.debug(" | found stub {s}: {}", .{ sym_name, self.stubs.get(sym_name) });
1489 log.warn(" | found stub {s}: {}", .{ sym_name, self.stubs.get(sym_name) });
14901490 },
14911491 }
14921492 }
......@@ -1504,7 +1504,7 @@ fn resolveStubsAndGotEntries(self: *Zld) !void {
15041504 .local_index = 0,
15051505 });
15061506
1507 log.debug(" | found GOT entry dyld_stub_binder: {}", .{self.got_entries.get("dyld_stub_binder")});
1507 log.warn(" | found GOT entry dyld_stub_binder: {}", .{self.got_entries.get("dyld_stub_binder")});
15081508}
15091509
15101510fn resolveRelocsAndWriteSections(self: *Zld) !void {
......@@ -1520,7 +1520,7 @@ fn resolveRelocsAndWriteSections(self: *Zld) !void {
15201520 .object_id = @intCast(u16, object_id),
15211521 .source_sect_id = @intCast(u16, source_sect_id),
15221522 }) orelse {
1523 log.debug("no mapping for {s},{s}; skipping", .{ segname, sectname });
1523 log.warn("no mapping for {s},{s}; skipping", .{ segname, sectname });
15241524 continue;
15251525 };
15261526 const target_seg = self.load_commands.items[target_mapping.target_seg_id].Segment;
......@@ -2128,6 +2128,7 @@ fn flush(self: *Zld) !void {
21282128 try self.file.?.pwriteAll(buffer, sect.offset);
21292129 }
21302130
2131 try self.writeGotEntries();
21312132 try self.setEntryPoint();
21322133 try self.writeRebaseInfoTable();
21332134 try self.writeBindInfoTable();
......@@ -2143,7 +2144,8 @@ fn flush(self: *Zld) !void {
21432144 symtab.symoff = @intCast(u32, seg.inner.fileoff + seg.inner.filesize);
21442145 }
21452146
2146 try self.writeDebugInfo();
2147 // try self.writeDebugInfo();
2148 try self.populateStringTable();
21472149 try self.writeSymbolTable();
21482150 try self.writeDynamicSymbolTable();
21492151 try self.writeStringTable();
......@@ -2170,60 +2172,52 @@ fn flush(self: *Zld) !void {
21702172 }
21712173}
21722174
2175fn writeGotEntries(self: *Zld) !void {
2176 const seg = self.load_commands.items[self.data_const_segment_cmd_index.?].Segment;
2177 const sect = seg.sections.items[self.got_section_index.?];
2178
2179 var buffer = try self.allocator.alloc(u8, self.got_entries.items().len * @sizeOf(u64));
2180 defer self.allocator.free(buffer);
2181
2182 var stream = std.io.fixedBufferStream(buffer);
2183 var writer = stream.writer();
2184
2185 for (self.got_entries.items()) |entry| {
2186 try writer.writeIntLittle(u64, entry.value.target_addr);
2187 }
2188
2189 log.warn("writing GOT pointers at 0x{x} to 0x{x}", .{ sect.offset, sect.offset + buffer.len });
2190
2191 try self.file.?.pwriteAll(buffer, sect.offset);
2192}
2193
21732194fn setEntryPoint(self: *Zld) !void {
21742195 // TODO we should respect the -entry flag passed in by the user to set a custom
21752196 // entrypoint. For now, assume default of `_main`.
21762197 const seg = self.load_commands.items[self.text_segment_cmd_index.?].Segment;
21772198 const text = seg.sections.items[self.text_section_index.?];
2178 const entry_syms = self.locals.get("_main") orelse return error.MissingMainEntrypoint;
2179
2180 var entry_sym: ?macho.nlist_64 = null;
2181 for (entry_syms.items) |es| {
2182 switch (es.tt) {
2183 .Global => {
2184 entry_sym = es.inner;
2185 break;
2186 },
2187 .WeakGlobal => {
2188 entry_sym = es.inner;
2189 },
2190 .Local => {},
2191 }
2192 }
2193 if (entry_sym == null) {
2194 log.err("no (weak) global definition of _main found", .{});
2195 return error.MissingMainEntrypoint;
2196 }
2197
2198 const name = try self.allocator.dupe(u8, "_main");
2199 try self.exports.putNoClobber(self.allocator, name, .{
2200 .n_strx = entry_sym.?.n_strx,
2201 .n_value = entry_sym.?.n_value,
2202 .n_type = macho.N_SECT | macho.N_EXT,
2203 .n_desc = entry_sym.?.n_desc,
2204 .n_sect = entry_sym.?.n_sect,
2205 });
2206
2199 const entry_sym = self.symtab.get("_main") orelse return error.MissingMainEntrypoint;
22072200 const ec = &self.load_commands.items[self.main_cmd_index.?].Main;
2208 ec.entryoff = @intCast(u32, entry_sym.?.n_value - seg.inner.vmaddr);
2201 ec.entryoff = @intCast(u32, entry_sym.inner.n_value - seg.inner.vmaddr);
22092202}
22102203
22112204fn writeRebaseInfoTable(self: *Zld) !void {
22122205 var pointers = std.ArrayList(Pointer).init(self.allocator);
22132206 defer pointers.deinit();
22142207
2215 try pointers.ensureCapacity(pointers.items.len + self.local_rebases.items.len);
2208 try pointers.ensureCapacity(self.local_rebases.items.len);
22162209 pointers.appendSliceAssumeCapacity(self.local_rebases.items);
22172210
22182211 if (self.got_section_index) |idx| {
22192212 // TODO this should be cleaned up!
2220 try pointers.ensureCapacity(pointers.items.len + self.nonlazy_pointers.items().len);
22212213 const seg = self.load_commands.items[self.data_const_segment_cmd_index.?].Segment;
22222214 const sect = seg.sections.items[idx];
22232215 const base_offset = sect.addr - seg.inner.vmaddr;
22242216 const segment_id = @intCast(u16, self.data_const_segment_cmd_index.?);
2225 const index_offset = @intCast(u32, self.nonlazy_imports.items().len);
2226 for (self.nonlazy_pointers.items()) |entry| {
2217 const index_offset = @intCast(u32, self.got_entries.items().len);
2218
2219 try pointers.ensureCapacity(pointers.items.len + self.got_entries.items().len);
2220 for (self.got_entries.items()) |entry| {
22272221 const index = index_offset + entry.value.index;
22282222 pointers.appendAssumeCapacity(.{
22292223 .offset = base_offset + index * @sizeOf(u64),
......@@ -2269,14 +2263,15 @@ fn writeRebaseInfoTable(self: *Zld) !void {
22692263 }
22702264
22712265 if (self.la_symbol_ptr_section_index) |idx| {
2272 try pointers.ensureCapacity(pointers.items.len + self.lazy_imports.items().len);
22732266 const seg = self.load_commands.items[self.data_segment_cmd_index.?].Segment;
22742267 const sect = seg.sections.items[idx];
22752268 const base_offset = sect.addr - seg.inner.vmaddr;
22762269 const segment_id = @intCast(u16, self.data_segment_cmd_index.?);
2277 for (self.lazy_imports.items()) |entry| {
2270
2271 try pointers.ensureCapacity(pointers.items.len + self.stubs.items().len);
2272 for (self.stubs.items()) |entry| {
22782273 pointers.appendAssumeCapacity(.{
2279 .offset = base_offset + entry.value.index * @sizeOf(u64),
2274 .offset = base_offset + entry.value * @sizeOf(u64),
22802275 .segment_id = segment_id,
22812276 });
22822277 }
......@@ -2297,7 +2292,7 @@ fn writeRebaseInfoTable(self: *Zld) !void {
22972292 dyld_info.rebase_size = @intCast(u32, mem.alignForwardGeneric(u64, buffer.len, @sizeOf(u64)));
22982293 seg.inner.filesize += dyld_info.rebase_size;
22992294
2300 log.debug("writing rebase info from 0x{x} to 0x{x}", .{ dyld_info.rebase_off, dyld_info.rebase_off + dyld_info.rebase_size });
2295 log.warn("writing rebase info from 0x{x} to 0x{x}", .{ dyld_info.rebase_off, dyld_info.rebase_off + dyld_info.rebase_size });
23012296
23022297 try self.file.?.pwriteAll(buffer, dyld_info.rebase_off);
23032298}
......@@ -2307,16 +2302,23 @@ fn writeBindInfoTable(self: *Zld) !void {
23072302 defer pointers.deinit();
23082303
23092304 if (self.got_section_index) |idx| {
2310 try pointers.ensureCapacity(pointers.items.len + self.nonlazy_imports.items().len);
23112305 const seg = self.load_commands.items[self.data_const_segment_cmd_index.?].Segment;
23122306 const sect = seg.sections.items[idx];
23132307 const base_offset = sect.addr - seg.inner.vmaddr;
23142308 const segment_id = @intCast(u16, self.data_const_segment_cmd_index.?);
2315 for (self.nonlazy_imports.items()) |entry| {
2309
2310 try pointers.ensureCapacity(pointers.items.len + self.got_entries.items().len);
2311 for (self.got_entries.items()) |entry| {
2312 const dylib_ordinal = dylib_ordinal: {
2313 const sym = self.symtab.get(entry.key) orelse continue; // local indirection
2314 if (sym.tag != .Import) continue; // local indirection
2315 break :dylib_ordinal sym.file.? + 1;
2316 };
2317
23162318 pointers.appendAssumeCapacity(.{
23172319 .offset = base_offset + entry.value.index * @sizeOf(u64),
23182320 .segment_id = segment_id,
2319 .dylib_ordinal = entry.value.dylib_ordinal,
2321 .dylib_ordinal = dylib_ordinal,
23202322 .name = entry.key,
23212323 });
23222324 }
......@@ -2327,10 +2329,14 @@ fn writeBindInfoTable(self: *Zld) !void {
23272329 const sect = seg.sections.items[idx];
23282330 const base_offset = sect.addr - seg.inner.vmaddr;
23292331 const segment_id = @intCast(u16, self.data_segment_cmd_index.?);
2332
2333 const sym = self.symtab.get("__tlv_bootstrap") orelse unreachable;
2334 const dylib_ordinal = sym.file.? + 1;
2335
23302336 try pointers.append(.{
2331 .offset = base_offset + self.tlv_bootstrap.?.index * @sizeOf(u64),
2337 .offset = base_offset,
23322338 .segment_id = segment_id,
2333 .dylib_ordinal = self.tlv_bootstrap.?.dylib_ordinal,
2339 .dylib_ordinal = dylib_ordinal,
23342340 .name = "__tlv_bootstrap",
23352341 });
23362342 }
......@@ -2348,7 +2354,7 @@ fn writeBindInfoTable(self: *Zld) !void {
23482354 dyld_info.bind_size = @intCast(u32, mem.alignForwardGeneric(u64, buffer.len, @alignOf(u64)));
23492355 seg.inner.filesize += dyld_info.bind_size;
23502356
2351 log.debug("writing binding info from 0x{x} to 0x{x}", .{ dyld_info.bind_off, dyld_info.bind_off + dyld_info.bind_size });
2357 log.warn("writing binding info from 0x{x} to 0x{x}", .{ dyld_info.bind_off, dyld_info.bind_off + dyld_info.bind_size });
23522358
23532359 try self.file.?.pwriteAll(buffer, dyld_info.bind_off);
23542360}
......@@ -2356,18 +2362,26 @@ fn writeBindInfoTable(self: *Zld) !void {
23562362fn writeLazyBindInfoTable(self: *Zld) !void {
23572363 var pointers = std.ArrayList(Pointer).init(self.allocator);
23582364 defer pointers.deinit();
2359 try pointers.ensureCapacity(self.lazy_imports.items().len);
23602365
23612366 if (self.la_symbol_ptr_section_index) |idx| {
23622367 const seg = self.load_commands.items[self.data_segment_cmd_index.?].Segment;
23632368 const sect = seg.sections.items[idx];
23642369 const base_offset = sect.addr - seg.inner.vmaddr;
23652370 const segment_id = @intCast(u16, self.data_segment_cmd_index.?);
2366 for (self.lazy_imports.items()) |entry| {
2371
2372 try pointers.ensureCapacity(self.stubs.items().len);
2373
2374 for (self.stubs.items()) |entry| {
2375 const dylib_ordinal = dylib_ordinal: {
2376 const sym = self.symtab.get(entry.key) orelse unreachable;
2377 assert(sym.tag == .Import);
2378 break :dylib_ordinal sym.file.? + 1;
2379 };
2380
23672381 pointers.appendAssumeCapacity(.{
2368 .offset = base_offset + entry.value.index * @sizeOf(u64),
2382 .offset = base_offset + entry.value * @sizeOf(u64),
23692383 .segment_id = segment_id,
2370 .dylib_ordinal = entry.value.dylib_ordinal,
2384 .dylib_ordinal = dylib_ordinal,
23712385 .name = entry.key,
23722386 });
23732387 }
......@@ -2386,7 +2400,7 @@ fn writeLazyBindInfoTable(self: *Zld) !void {
23862400 dyld_info.lazy_bind_size = @intCast(u32, mem.alignForwardGeneric(u64, buffer.len, @alignOf(u64)));
23872401 seg.inner.filesize += dyld_info.lazy_bind_size;
23882402
2389 log.debug("writing lazy binding info from 0x{x} to 0x{x}", .{ dyld_info.lazy_bind_off, dyld_info.lazy_bind_off + dyld_info.lazy_bind_size });
2403 log.warn("writing lazy binding info from 0x{x} to 0x{x}", .{ dyld_info.lazy_bind_off, dyld_info.lazy_bind_off + dyld_info.lazy_bind_size });
23902404
23912405 try self.file.?.pwriteAll(buffer, dyld_info.lazy_bind_off);
23922406 try self.populateLazyBindOffsetsInStubHelper(buffer);
......@@ -2437,7 +2451,7 @@ fn populateLazyBindOffsetsInStubHelper(self: *Zld, buffer: []const u8) !void {
24372451 else => {},
24382452 }
24392453 }
2440 assert(self.lazy_imports.items().len <= offsets.items.len);
2454 assert(self.stubs.items().len <= offsets.items.len);
24412455
24422456 const stub_size: u4 = switch (self.arch.?) {
24432457 .x86_64 => 10,
......@@ -2450,10 +2464,9 @@ fn populateLazyBindOffsetsInStubHelper(self: *Zld, buffer: []const u8) !void {
24502464 else => unreachable,
24512465 };
24522466 var buf: [@sizeOf(u32)]u8 = undefined;
2453 for (self.lazy_imports.items()) |entry| {
2454 const symbol = entry.value;
2455 const placeholder_off = self.stub_helper_stubs_start_off.? + symbol.index * stub_size + off;
2456 mem.writeIntLittle(u32, &buf, offsets.items[symbol.index]);
2467 for (self.stubs.items()) |entry| {
2468 const placeholder_off = self.stub_helper_stubs_start_off.? + entry.value * stub_size + off;
2469 mem.writeIntLittle(u32, &buf, offsets.items[entry.value]);
24572470 try self.file.?.pwriteAll(&buf, placeholder_off);
24582471 }
24592472}
......@@ -2463,11 +2476,16 @@ fn writeExportInfo(self: *Zld) !void {
24632476 defer trie.deinit();
24642477
24652478 const text_segment = self.load_commands.items[self.text_segment_cmd_index.?].Segment;
2466 for (self.exports.items()) |entry| {
2479 for (self.symtab.items()) |entry| {
2480 switch (entry.value.tag) {
2481 .Weak, .Strong => {},
2482 else => continue,
2483 }
24672484 const name = entry.key;
2468 const symbol = entry.value;
2469 // TODO figure out if we should put all exports into the export trie
2485 const symbol = entry.value.inner;
2486
24702487 assert(symbol.n_value >= text_segment.inner.vmaddr);
2488
24712489 try trie.put(.{
24722490 .name = name,
24732491 .vmaddr_offset = symbol.n_value - text_segment.inner.vmaddr,
......@@ -2488,7 +2506,7 @@ fn writeExportInfo(self: *Zld) !void {
24882506 dyld_info.export_size = @intCast(u32, mem.alignForwardGeneric(u64, buffer.len, @alignOf(u64)));
24892507 seg.inner.filesize += dyld_info.export_size;
24902508
2491 log.debug("writing export info from 0x{x} to 0x{x}", .{ dyld_info.export_off, dyld_info.export_off + dyld_info.export_size });
2509 log.warn("writing export info from 0x{x} to 0x{x}", .{ dyld_info.export_off, dyld_info.export_off + dyld_info.export_size });
24922510
24932511 try self.file.?.pwriteAll(buffer, dyld_info.export_off);
24942512}
......@@ -2508,7 +2526,7 @@ fn writeDebugInfo(self: *Zld) !void {
25082526 const compile_unit = debug_info.inner.findCompileUnit(0x0) catch |err| switch (err) {
25092527 error.MissingDebugInfo => {
25102528 // TODO audit cases with missing debug info and audit our dwarf.zig module.
2511 log.debug("invalid or missing debug info in {s}; skipping", .{object.name});
2529 log.warn("invalid or missing debug info in {s}; skipping", .{object.name});
25122530 continue;
25132531 },
25142532 else => |e| return e,
......@@ -2558,7 +2576,7 @@ fn writeDebugInfo(self: *Zld) !void {
25582576 .n_value = mtime,
25592577 });
25602578 }
2561 log.debug("analyzing debug info in '{s}'", .{object.name});
2579 log.warn("analyzing debug info in '{s}'", .{object.name});
25622580
25632581 for (object.symtab.items) |source_sym| {
25642582 const symname = object.getString(source_sym.n_strx);
......@@ -2639,7 +2657,7 @@ fn writeDebugInfo(self: *Zld) !void {
26392657
26402658 const stabs_off = symtab.symoff;
26412659 const stabs_size = symtab.nsyms * @sizeOf(macho.nlist_64);
2642 log.debug("writing symbol stabs from 0x{x} to 0x{x}", .{ stabs_off, stabs_size + stabs_off });
2660 log.warn("writing symbol stabs from 0x{x} to 0x{x}", .{ stabs_off, stabs_size + stabs_off });
26432661 try self.file.?.pwriteAll(mem.sliceAsBytes(stabs.items), stabs_off);
26442662
26452663 linkedit.inner.filesize += stabs_size;
......@@ -2649,66 +2667,56 @@ fn writeDebugInfo(self: *Zld) !void {
26492667 dysymtab.nlocalsym = symtab.nsyms;
26502668}
26512669
2670fn populateStringTable(self: *Zld) !void {
2671 for (self.symtab.items()) |*entry| {
2672 const n_strx = try self.makeString(entry.key);
2673 entry.value.inner.n_strx = n_strx;
2674 }
2675}
2676
26522677fn writeSymbolTable(self: *Zld) !void {
26532678 const seg = &self.load_commands.items[self.linkedit_segment_cmd_index.?].Segment;
26542679 const symtab = &self.load_commands.items[self.symtab_cmd_index.?].Symtab;
26552680
2681 // TODO figure out how to add locals
26562682 var locals = std.ArrayList(macho.nlist_64).init(self.allocator);
26572683 defer locals.deinit();
26582684
2659 for (self.locals.items()) |entries| {
2660 log.debug("'{s}': {} entries", .{ entries.key, entries.value.items.len });
2661 // var symbol: ?macho.nlist_64 = null;
2662 for (entries.value.items) |entry| {
2663 log.debug(" | {}", .{entry.inner});
2664 log.debug(" | {}", .{entry.tt});
2665 log.debug(" | {s}", .{self.objects.items[entry.object_id].name});
2666 try locals.append(entry.inner);
2667 }
2668 }
2669 const nlocals = locals.items.len;
2670
2671 const nexports = self.exports.items().len;
26722685 var exports = std.ArrayList(macho.nlist_64).init(self.allocator);
26732686 defer exports.deinit();
26742687
2675 try exports.ensureCapacity(nexports);
2676 for (self.exports.items()) |entry| {
2677 exports.appendAssumeCapacity(entry.value);
2678 }
2679
2680 const has_tlv: bool = self.tlv_bootstrap != null;
2681
2682 var nundefs = self.lazy_imports.items().len + self.nonlazy_imports.items().len;
2683 if (has_tlv) nundefs += 1;
2684
26852688 var undefs = std.ArrayList(macho.nlist_64).init(self.allocator);
26862689 defer undefs.deinit();
26872690
2688 try undefs.ensureCapacity(nundefs);
2689 for (self.lazy_imports.items()) |entry| {
2690 undefs.appendAssumeCapacity(entry.value.symbol);
2691 }
2692 for (self.nonlazy_imports.items()) |entry| {
2693 undefs.appendAssumeCapacity(entry.value.symbol);
2694 }
2695 if (has_tlv) {
2696 undefs.appendAssumeCapacity(self.tlv_bootstrap.?.symbol);
2691 for (self.symtab.items()) |entry| {
2692 switch (entry.value.tag) {
2693 .Weak, .Strong => {
2694 try exports.append(entry.value.inner);
2695 },
2696 .Import => {
2697 try undefs.append(entry.value.inner);
2698 },
2699 else => unreachable,
2700 }
26972701 }
26982702
2703 const nlocals = locals.items.len;
2704 const nexports = exports.items.len;
2705 const nundefs = undefs.items.len;
2706
26992707 const locals_off = symtab.symoff + symtab.nsyms * @sizeOf(macho.nlist_64);
27002708 const locals_size = nlocals * @sizeOf(macho.nlist_64);
2701 log.debug("writing local symbols from 0x{x} to 0x{x}", .{ locals_off, locals_size + locals_off });
2709 log.warn("writing local symbols from 0x{x} to 0x{x}", .{ locals_off, locals_size + locals_off });
27022710 try self.file.?.pwriteAll(mem.sliceAsBytes(locals.items), locals_off);
27032711
27042712 const exports_off = locals_off + locals_size;
27052713 const exports_size = nexports * @sizeOf(macho.nlist_64);
2706 log.debug("writing exported symbols from 0x{x} to 0x{x}", .{ exports_off, exports_size + exports_off });
2714 log.warn("writing exported symbols from 0x{x} to 0x{x}", .{ exports_off, exports_size + exports_off });
27072715 try self.file.?.pwriteAll(mem.sliceAsBytes(exports.items), exports_off);
27082716
27092717 const undefs_off = exports_off + exports_size;
27102718 const undefs_size = nundefs * @sizeOf(macho.nlist_64);
2711 log.debug("writing undefined symbols from 0x{x} to 0x{x}", .{ undefs_off, undefs_size + undefs_off });
2719 log.warn("writing undefined symbols from 0x{x} to 0x{x}", .{ undefs_off, undefs_size + undefs_off });
27122720 try self.file.?.pwriteAll(mem.sliceAsBytes(undefs.items), undefs_off);
27132721
27142722 symtab.nsyms += @intCast(u32, nlocals + nexports + nundefs);
......@@ -2733,44 +2741,45 @@ fn writeDynamicSymbolTable(self: *Zld) !void {
27332741 const la_symbol_ptr = &data_segment.sections.items[self.la_symbol_ptr_section_index.?];
27342742 const dysymtab = &self.load_commands.items[self.dysymtab_cmd_index.?].Dysymtab;
27352743
2736 const lazy = self.lazy_imports.items();
2737 const nonlazy = self.nonlazy_imports.items();
2738 const got_locals = self.nonlazy_pointers.items();
2744 const nstubs = @intCast(u32, self.stubs.items().len);
2745 const ngot_entries = @intCast(u32, self.got_entries.items().len);
2746
27392747 dysymtab.indirectsymoff = @intCast(u32, seg.inner.fileoff + seg.inner.filesize);
2740 dysymtab.nindirectsyms = @intCast(u32, lazy.len * 2 + nonlazy.len + got_locals.len);
2748 dysymtab.nindirectsyms = nstubs * 2 + ngot_entries;
2749
27412750 const needed_size = dysymtab.nindirectsyms * @sizeOf(u32);
27422751 seg.inner.filesize += needed_size;
27432752
2744 log.debug("writing indirect symbol table from 0x{x} to 0x{x}", .{
2753 log.warn("writing indirect symbol table from 0x{x} to 0x{x}", .{
27452754 dysymtab.indirectsymoff,
27462755 dysymtab.indirectsymoff + needed_size,
27472756 });
27482757
27492758 var buf = try self.allocator.alloc(u8, needed_size);
27502759 defer self.allocator.free(buf);
2760
27512761 var stream = std.io.fixedBufferStream(buf);
27522762 var writer = stream.writer();
27532763
27542764 stubs.reserved1 = 0;
2755 for (lazy) |_, i| {
2756 const symtab_idx = @intCast(u32, dysymtab.iundefsym + i);
2765 for (self.stubs.items()) |entry| {
2766 const symtab_idx = @intCast(u32, dysymtab.iundefsym + entry.value);
27572767 try writer.writeIntLittle(u32, symtab_idx);
27582768 }
27592769
2760 const base_id = @intCast(u32, lazy.len);
2761 got.reserved1 = base_id;
2762 for (nonlazy) |_, i| {
2763 const symtab_idx = @intCast(u32, dysymtab.iundefsym + i + base_id);
2764 try writer.writeIntLittle(u32, symtab_idx);
2765 }
2766 // TODO there should be one common set of GOT entries.
2767 for (got_locals) |_| {
2768 try writer.writeIntLittle(u32, macho.INDIRECT_SYMBOL_LOCAL);
2770 got.reserved1 = nstubs;
2771 for (self.got_entries.items()) |entry| {
2772 if (entry.value.tag == .import) {
2773 const symtab_idx = @intCast(u32, dysymtab.iundefsym + entry.value.index + nstubs);
2774 try writer.writeIntLittle(u32, symtab_idx);
2775 } else {
2776 try writer.writeIntLittle(u32, macho.INDIRECT_SYMBOL_LOCAL);
2777 }
27692778 }
27702779
2771 la_symbol_ptr.reserved1 = got.reserved1 + @intCast(u32, nonlazy.len) + @intCast(u32, got_locals.len);
2772 for (lazy) |_, i| {
2773 const symtab_idx = @intCast(u32, dysymtab.iundefsym + i);
2780 la_symbol_ptr.reserved1 = got.reserved1 + ngot_entries;
2781 for (self.stubs.items()) |entry| {
2782 const symtab_idx = @intCast(u32, dysymtab.iundefsym + entry.value);
27742783 try writer.writeIntLittle(u32, symtab_idx);
27752784 }
27762785
......@@ -2784,7 +2793,7 @@ fn writeStringTable(self: *Zld) !void {
27842793 symtab.strsize = @intCast(u32, mem.alignForwardGeneric(u64, self.strtab.items.len, @alignOf(u64)));
27852794 seg.inner.filesize += symtab.strsize;
27862795
2787 log.debug("writing string table from 0x{x} to 0x{x}", .{ symtab.stroff, symtab.stroff + symtab.strsize });
2796 log.warn("writing string table from 0x{x} to 0x{x}", .{ symtab.stroff, symtab.stroff + symtab.strsize });
27882797
27892798 try self.file.?.pwriteAll(self.strtab.items, symtab.stroff);
27902799
......@@ -2830,7 +2839,7 @@ fn writeDataInCode(self: *Zld) !void {
28302839 dice_cmd.datasize = datasize;
28312840 seg.inner.filesize += datasize;
28322841
2833 log.debug("writing data-in-code from 0x{x} to 0x{x}", .{ fileoff, fileoff + datasize });
2842 log.warn("writing data-in-code from 0x{x} to 0x{x}", .{ fileoff, fileoff + datasize });
28342843
28352844 try self.file.?.pwriteAll(buf.items, fileoff);
28362845}
......@@ -2851,7 +2860,7 @@ fn writeCodeSignaturePadding(self: *Zld) !void {
28512860 seg.inner.filesize += needed_size;
28522861 seg.inner.vmsize = mem.alignForwardGeneric(u64, seg.inner.filesize, self.page_size.?);
28532862
2854 log.debug("writing code signature padding from 0x{x} to 0x{x}", .{ fileoff, fileoff + needed_size });
2863 log.warn("writing code signature padding from 0x{x} to 0x{x}", .{ fileoff, fileoff + needed_size });
28552864
28562865 // Pad out the space. We need to do this to calculate valid hashes for everything in the file
28572866 // except for code signature data.
......@@ -2877,7 +2886,7 @@ fn writeCodeSignature(self: *Zld) !void {
28772886 var stream = std.io.fixedBufferStream(buffer);
28782887 try code_sig.write(stream.writer());
28792888
2880 log.debug("writing code signature from 0x{x} to 0x{x}", .{ code_sig_cmd.dataoff, code_sig_cmd.dataoff + buffer.len });
2889 log.warn("writing code signature from 0x{x} to 0x{x}", .{ code_sig_cmd.dataoff, code_sig_cmd.dataoff + buffer.len });
28812890 try self.file.?.pwriteAll(buffer, code_sig_cmd.dataoff);
28822891}
28832892
......@@ -2895,7 +2904,7 @@ fn writeLoadCommands(self: *Zld) !void {
28952904 }
28962905
28972906 const off = @sizeOf(macho.mach_header_64);
2898 log.debug("writing {} load commands from 0x{x} to 0x{x}", .{ self.load_commands.items.len, off, off + sizeofcmds });
2907 log.warn("writing {} load commands from 0x{x} to 0x{x}", .{ self.load_commands.items.len, off, off + sizeofcmds });
28992908 try self.file.?.pwriteAll(buffer, off);
29002909}
29012910
......@@ -2933,7 +2942,7 @@ fn writeHeader(self: *Zld) !void {
29332942 for (self.load_commands.items) |cmd| {
29342943 header.sizeofcmds += cmd.cmdsize();
29352944 }
2936 log.debug("writing Mach-O header {}", .{header});
2945 log.warn("writing Mach-O header {}", .{header});
29372946 try self.file.?.pwriteAll(mem.asBytes(&header), 0);
29382947}
29392948
......@@ -2947,7 +2956,7 @@ pub fn makeStaticString(bytes: []const u8) [16]u8 {
29472956fn makeString(self: *Zld, bytes: []const u8) !u32 {
29482957 try self.strtab.ensureCapacity(self.allocator, self.strtab.items.len + bytes.len + 1);
29492958 const offset = @intCast(u32, self.strtab.items.len);
2950 log.debug("writing new string '{s}' into string table at offset 0x{x}", .{ bytes, offset });
2959 log.warn("writing new string '{s}' into string table at offset 0x{x}", .{ bytes, offset });
29512960 self.strtab.appendSliceAssumeCapacity(bytes);
29522961 self.strtab.appendAssumeCapacity(0);
29532962 return offset;
......@@ -2963,11 +2972,6 @@ pub fn parseName(name: *const [16]u8) []const u8 {
29632972 return name[0..len];
29642973}
29652974
2966fn aarch64IsArithmetic(inst: *const [4]u8) callconv(.Inline) bool {
2967 const group_decode = @truncate(u5, inst[3]);
2968 return ((group_decode >> 2) == 4);
2969}
2970
29712975fn printDebug(self: Zld) void {
29722976 log.warn("symtab", .{});
29732977 for (self.symtab.items()) |entry| {
src/link/MachO/reloc.zig+16-15
......@@ -33,7 +33,8 @@ pub const Relocation = struct {
3333 log.warn(" | offset 0x{x}", .{base.offset});
3434 log.warn(" | source address 0x{x}", .{args.source_addr});
3535 log.warn(" | target address 0x{x}", .{args.target_addr});
36 log.warn(" | subtractor address 0x{x}", .{args.subtractor});
36 if (args.subtractor) |sub|
37 log.warn(" | subtractor address 0x{x}", .{sub});
3738
3839 return switch (base.@"type") {
3940 .branch => @fieldParentPtr(Branch, "base", base).resolve(args.source_addr, args.target_addr),
......@@ -307,12 +308,12 @@ const RelocIterator = struct {
307308 self.index += 1;
308309 if (self.index < self.buffer.len) {
309310 const reloc = self.buffer[@intCast(u64, self.index)];
310 log.warn("{s}", .{@intToEnum(macho.reloc_type_arm64, reloc.r_type)});
311 log.warn(" | offset = {}", .{reloc.r_address});
312 log.warn(" | PC = {}", .{reloc.r_pcrel == 1});
313 log.warn(" | length = {}", .{reloc.r_length});
314 log.warn(" | symbolnum = {}", .{reloc.r_symbolnum});
315 log.warn(" | extern = {}", .{reloc.r_extern == 1});
311 log.debug("{s}", .{@intToEnum(macho.reloc_type_arm64, reloc.r_type)});
312 log.debug(" | offset = {}", .{reloc.r_address});
313 log.debug(" | PC = {}", .{reloc.r_pcrel == 1});
314 log.debug(" | length = {}", .{reloc.r_length});
315 log.debug(" | symbolnum = {}", .{reloc.r_symbolnum});
316 log.debug(" | extern = {}", .{reloc.r_extern == 1});
316317 return reloc;
317318 }
318319 return null;
......@@ -432,7 +433,7 @@ const Parser = struct {
432433 .inst = parsed_inst,
433434 };
434435
435 log.warn(" | emitting {}", .{branch});
436 log.debug(" | emitting {}", .{branch});
436437 try parser.parsed.append(&branch.base);
437438 }
438439
......@@ -471,7 +472,7 @@ const Parser = struct {
471472 .inst = parsed_inst,
472473 };
473474
474 log.warn(" | emitting {}", .{page});
475 log.debug(" | emitting {}", .{page});
475476
476477 break :ptr &page.base;
477478 },
......@@ -489,7 +490,7 @@ const Parser = struct {
489490 .inst = parsed_inst,
490491 };
491492
492 log.warn(" | emitting {}", .{page});
493 log.debug(" | emitting {}", .{page});
493494
494495 break :ptr &page.base;
495496 },
......@@ -507,7 +508,7 @@ const Parser = struct {
507508 .inst = parsed_inst,
508509 };
509510
510 log.warn(" | emitting {}", .{page});
511 log.debug(" | emitting {}", .{page});
511512
512513 break :ptr &page.base;
513514 },
......@@ -564,7 +565,7 @@ const Parser = struct {
564565 .addend = parser.addend,
565566 };
566567
567 log.warn(" | emitting {}", .{page_off});
568 log.debug(" | emitting {}", .{page_off});
568569 try parser.parsed.append(&page_off.base);
569570 }
570571
......@@ -601,7 +602,7 @@ const Parser = struct {
601602 },
602603 };
603604
604 log.warn(" | emitting {}", .{page_off});
605 log.debug(" | emitting {}", .{page_off});
605606 try parser.parsed.append(&page_off.base);
606607 }
607608
......@@ -668,7 +669,7 @@ const Parser = struct {
668669 },
669670 };
670671
671 log.warn(" | emitting {}", .{page_off});
672 log.debug(" | emitting {}", .{page_off});
672673 try parser.parsed.append(&page_off.base);
673674 }
674675
......@@ -729,7 +730,7 @@ const Parser = struct {
729730 .addend = addend,
730731 };
731732
732 log.warn(" | emitting {}", .{unsigned});
733 log.debug(" | emitting {}", .{unsigned});
733734 try parser.parsed.append(&unsigned.base);
734735 }
735736};