authorgravatar for kubkon@jakubkonka.comJakub Konka <kubkon@jakubkonka.com> 2023-03-28 19:27:05+02:00
committergravatar for kubkon@jakubkonka.comJakub Konka <kubkon@jakubkonka.com> 2023-03-28 19:27:05+02:00
log25f3175217dace219af643bce7bd28913a970362
treebde52f03052e390f398cf382c15051c3917d5157
parent004f32e79d61cb549b6cf71499138db0df56e152

coff: use ArrayHashMap if we are iterating over keys

3 files changed, 45 insertions(+), 61 deletions(-)

src/link/Coff.zig+42-58
......@@ -49,11 +49,8 @@ imports_count_dirty: bool = true,
4949/// Virtual address of the entry point procedure relative to image base.
5050entry_addr: ?u32 = null,
5151
52/// Table of Decls that are currently alive.
53/// We store them here so that we can properly dispose of any allocated
54/// memory within the atom in the incremental linker.
55/// TODO consolidate this.
56decls: std.AutoHashMapUnmanaged(Module.Decl.Index, DeclMetadata) = .{},
52/// Table of tracked Decls.
53decls: std.AutoArrayHashMapUnmanaged(Module.Decl.Index, DeclMetadata) = .{},
5754
5855/// List of atoms that are either synthetic or map directly to the Zig source program.
5956atoms: std.ArrayListUnmanaged(Atom) = .{},
......@@ -98,9 +95,9 @@ const Entry = struct {
9895 sym_index: u32,
9996};
10097
101const RelocTable = std.AutoHashMapUnmanaged(Atom.Index, std.ArrayListUnmanaged(Relocation));
102const BaseRelocationTable = std.AutoHashMapUnmanaged(Atom.Index, std.ArrayListUnmanaged(u32));
103const UnnamedConstTable = std.AutoHashMapUnmanaged(Module.Decl.Index, std.ArrayListUnmanaged(Atom.Index));
98const RelocTable = std.AutoArrayHashMapUnmanaged(Atom.Index, std.ArrayListUnmanaged(Relocation));
99const BaseRelocationTable = std.AutoArrayHashMapUnmanaged(Atom.Index, std.ArrayListUnmanaged(u32));
100const UnnamedConstTable = std.AutoArrayHashMapUnmanaged(Module.Decl.Index, std.ArrayListUnmanaged(Atom.Index));
104101
105102const default_file_alignment: u16 = 0x200;
106103const default_size_of_stack_reserve: u32 = 0x1000000;
......@@ -137,6 +134,10 @@ const DeclMetadata = struct {
137134 /// A list of all exports aliases of this Decl.
138135 exports: std.ArrayListUnmanaged(u32) = .{},
139136
137 fn deinit(m: *DeclMetadata, allocator: Allocator) void {
138 m.exports.deinit(allocator);
139 }
140
140141 fn getExport(m: DeclMetadata, coff_file: *const Coff, name: []const u8) ?u32 {
141142 for (m.exports.items) |exp| {
142143 if (mem.eql(u8, name, coff_file.getSymbolName(.{
......@@ -293,39 +294,27 @@ pub fn deinit(self: *Coff) void {
293294 }
294295 self.import_tables.deinit(gpa);
295296
296 {
297 var it = self.decls.iterator();
298 while (it.next()) |entry| {
299 entry.value_ptr.exports.deinit(gpa);
300 }
301 self.decls.deinit(gpa);
297 for (self.decls.values()) |*metadata| {
298 metadata.deinit(gpa);
302299 }
300 self.decls.deinit(gpa);
303301
304302 self.atom_by_index_table.deinit(gpa);
305303
306 {
307 var it = self.unnamed_const_atoms.valueIterator();
308 while (it.next()) |atoms| {
309 atoms.deinit(gpa);
310 }
311 self.unnamed_const_atoms.deinit(gpa);
304 for (self.unnamed_const_atoms.values()) |*atoms| {
305 atoms.deinit(gpa);
312306 }
307 self.unnamed_const_atoms.deinit(gpa);
313308
314 {
315 var it = self.relocs.valueIterator();
316 while (it.next()) |relocs| {
317 relocs.deinit(gpa);
318 }
319 self.relocs.deinit(gpa);
309 for (self.relocs.values()) |*relocs| {
310 relocs.deinit(gpa);
320311 }
312 self.relocs.deinit(gpa);
321313
322 {
323 var it = self.base_relocs.valueIterator();
324 while (it.next()) |relocs| {
325 relocs.deinit(gpa);
326 }
327 self.base_relocs.deinit(gpa);
314 for (self.base_relocs.values()) |*relocs| {
315 relocs.deinit(gpa);
328316 }
317 self.base_relocs.deinit(gpa);
329318}
330319
331320fn populateMissingMetadata(self: *Coff) !void {
......@@ -800,8 +789,7 @@ fn writePtrWidthAtom(self: *Coff, atom_index: Atom.Index) !void {
800789
801790fn markRelocsDirtyByTarget(self: *Coff, target: SymbolWithLoc) void {
802791 // TODO: reverse-lookup might come in handy here
803 var it = self.relocs.valueIterator();
804 while (it.next()) |relocs| {
792 for (self.relocs.values()) |*relocs| {
805793 for (relocs.items) |*reloc| {
806794 if (!reloc.target.eql(target)) continue;
807795 reloc.dirty = true;
......@@ -810,8 +798,7 @@ fn markRelocsDirtyByTarget(self: *Coff, target: SymbolWithLoc) void {
810798}
811799
812800fn markRelocsDirtyByAddress(self: *Coff, addr: u32) void {
813 var it = self.relocs.valueIterator();
814 while (it.next()) |relocs| {
801 for (self.relocs.values()) |*relocs| {
815802 for (relocs.items) |*reloc| {
816803 const target_vaddr = reloc.getTargetAddress(self) orelse continue;
817804 if (target_vaddr < addr) continue;
......@@ -821,7 +808,7 @@ fn markRelocsDirtyByAddress(self: *Coff, addr: u32) void {
821808}
822809
823810fn resolveRelocs(self: *Coff, atom_index: Atom.Index, code: []u8) void {
824 const relocs = self.relocs.get(atom_index) orelse return;
811 const relocs = self.relocs.getPtr(atom_index) orelse return;
825812
826813 log.debug("relocating '{s}'", .{self.getAtom(atom_index).getName(self)});
827814
......@@ -1196,7 +1183,7 @@ pub fn freeDecl(self: *Coff, decl_index: Module.Decl.Index) void {
11961183
11971184 log.debug("freeDecl {*}", .{decl});
11981185
1199 if (self.decls.fetchRemove(decl_index)) |const_kv| {
1186 if (self.decls.fetchOrderedRemove(decl_index)) |const_kv| {
12001187 var kv = const_kv;
12011188 self.freeAtom(kv.value.atom);
12021189 self.freeUnnamedConsts(decl_index);
......@@ -1423,32 +1410,29 @@ pub fn flushModule(self: *Coff, comp: *Compilation, prog_node: *std.Progress.Nod
14231410 }
14241411
14251412 try self.writeImportTables();
1426 {
1427 var it = self.relocs.keyIterator();
1428 while (it.next()) |atom_index_ptr| {
1429 const atom_index = atom_index_ptr.*;
1430 const relocs = self.relocs.get(atom_index).?;
1431 const needs_update = for (relocs.items) |reloc| {
1432 if (reloc.dirty) break true;
1433 } else false;
14341413
1435 if (!needs_update) continue;
1414 for (self.relocs.keys(), self.relocs.values()) |atom_index, relocs| {
1415 const needs_update = for (relocs.items) |reloc| {
1416 if (reloc.dirty) break true;
1417 } else false;
14361418
1437 const atom = self.getAtom(atom_index);
1438 const sym = atom.getSymbol(self);
1439 const section = self.sections.get(@enumToInt(sym.section_number) - 1).header;
1440 const file_offset = section.pointer_to_raw_data + sym.value - section.virtual_address;
1419 if (!needs_update) continue;
14411420
1442 var code = std.ArrayList(u8).init(gpa);
1443 defer code.deinit();
1444 try code.resize(math.cast(usize, atom.size) orelse return error.Overflow);
1421 const atom = self.getAtom(atom_index);
1422 const sym = atom.getSymbol(self);
1423 const section = self.sections.get(@enumToInt(sym.section_number) - 1).header;
1424 const file_offset = section.pointer_to_raw_data + sym.value - section.virtual_address;
14451425
1446 const amt = try self.base.file.?.preadAll(code.items, file_offset);
1447 if (amt != code.items.len) return error.InputOutput;
1426 var code = std.ArrayList(u8).init(gpa);
1427 defer code.deinit();
1428 try code.resize(math.cast(usize, atom.size) orelse return error.Overflow);
14481429
1449 try self.writeAtom(atom_index, code.items);
1450 }
1430 const amt = try self.base.file.?.preadAll(code.items, file_offset);
1431 if (amt != code.items.len) return error.InputOutput;
1432
1433 try self.writeAtom(atom_index, code.items);
14511434 }
1435
14521436 try self.writeBaseRelocations();
14531437
14541438 if (self.getEntryPoint()) |entry_sym_loc| {
src/link/Coff/Atom.zig+2-2
......@@ -121,8 +121,8 @@ pub fn addBaseRelocation(coff_file: *Coff, atom_index: Index, offset: u32) !void
121121
122122pub fn freeRelocations(coff_file: *Coff, atom_index: Index) void {
123123 const gpa = coff_file.base.allocator;
124 var removed_relocs = coff_file.relocs.fetchRemove(atom_index);
124 var removed_relocs = coff_file.relocs.fetchOrderedRemove(atom_index);
125125 if (removed_relocs) |*relocs| relocs.value.deinit(gpa);
126 var removed_base_relocs = coff_file.base_relocs.fetchRemove(atom_index);
126 var removed_base_relocs = coff_file.base_relocs.fetchOrderedRemove(atom_index);
127127 if (removed_base_relocs) |*base_relocs| base_relocs.value.deinit(gpa);
128128}
src/link/Coff/Relocation.zig+1-1
......@@ -72,7 +72,7 @@ pub fn getTargetAddress(self: Relocation, coff_file: *const Coff) ?u32 {
7272 }
7373}
7474
75pub fn resolve(self: *Relocation, atom_index: Atom.Index, code: []u8, coff_file: *Coff) void {
75pub fn resolve(self: Relocation, atom_index: Atom.Index, code: []u8, coff_file: *Coff) void {
7676 const atom = coff_file.getAtom(atom_index);
7777 const source_sym = atom.getSymbol(coff_file);
7878 const source_vaddr = source_sym.value + self.offset;