authorgravatar for noam@pixelhero.devNoam Preil <noam@pixelhero.dev> 2020-07-12 22:56:31-04:00
committergravatar for noreply@github.comGitHub <noreply@github.com> 2020-07-12 22:56:31-04:00
log2c882b2e651386399fd48c24302fd2d4ba430ef3
treeb8d3299504b4dd3dceae45a912f720e1d5461831
parentdff1ac1089dd8a7cae5c167bdb4e6269c9b84bb6
signaturebadge-question-mark Signed by PGP key 4AEE18F83AFDEB23

CBE: Make C an ObjectFormat instead of a special bool (#5849)

5 files changed, 14 insertions(+), 11 deletions(-)

lib/std/target.zig+1
......@@ -435,6 +435,7 @@ pub const Target = struct {
435435 elf,
436436 macho,
437437 wasm,
438 c,
438439 };
439440
440441 pub const SubSystem = enum {
src-self-hosted/Module.zig-2
......@@ -723,7 +723,6 @@ pub const InitOptions = struct {
723723 object_format: ?std.builtin.ObjectFormat = null,
724724 optimize_mode: std.builtin.Mode = .Debug,
725725 keep_source_files_loaded: bool = false,
726 cbe: bool = false,
727726};
728727
729728pub fn init(gpa: *Allocator, options: InitOptions) !Module {
......@@ -733,7 +732,6 @@ pub fn init(gpa: *Allocator, options: InitOptions) !Module {
733732 .output_mode = options.output_mode,
734733 .link_mode = options.link_mode orelse .Static,
735734 .object_format = options.object_format orelse options.target.getObjectFormat(),
736 .cbe = options.cbe,
737735 });
738736 errdefer bin_file.destroy();
739737
src-self-hosted/link.zig+5-3
......@@ -22,7 +22,6 @@ pub const Options = struct {
2222 /// Used for calculating how much space to reserve for executable program code in case
2323 /// the binary file deos not already have such a section.
2424 program_code_size_hint: u64 = 256 * 1024,
25 cbe: bool = false,
2625};
2726
2827/// Attempts incremental linking, if the file already exists.
......@@ -35,10 +34,11 @@ pub fn openBinFilePath(
3534 sub_path: []const u8,
3635 options: Options,
3736) !*File {
38 const file = try dir.createFile(sub_path, .{ .truncate = options.cbe, .read = true, .mode = determineMode(options) });
37 const cbe = options.object_format == .c;
38 const file = try dir.createFile(sub_path, .{ .truncate = cbe, .read = true, .mode = determineMode(options) });
3939 errdefer file.close();
4040
41 if (options.cbe) {
41 if (cbe) {
4242 var bin_file = try allocator.create(File.C);
4343 errdefer allocator.destroy(bin_file);
4444 bin_file.* = try openCFile(allocator, file, options);
......@@ -1573,6 +1573,7 @@ pub fn createElfFile(allocator: *Allocator, file: fs.File, options: Options) !Fi
15731573 .Lib => return error.TODOImplementWritingLibFiles,
15741574 }
15751575 switch (options.object_format) {
1576 .c => unreachable,
15761577 .unknown => unreachable, // TODO remove this tag from the enum
15771578 .coff => return error.TODOImplementWritingCOFF,
15781579 .elf => {},
......@@ -1632,6 +1633,7 @@ fn openBinFileInner(allocator: *Allocator, file: fs.File, options: Options) !Fil
16321633 }
16331634 switch (options.object_format) {
16341635 .unknown => unreachable, // TODO remove this tag from the enum
1636 .c => unreachable,
16351637 .coff => return error.IncrFailed,
16361638 .elf => {},
16371639 .macho => return error.IncrFailed,
src-self-hosted/main.zig+7-5
......@@ -194,8 +194,8 @@ fn buildOutputType(
194194 var emit_zir: Emit = .no;
195195 var target_arch_os_abi: []const u8 = "native";
196196 var target_mcpu: ?[]const u8 = null;
197 var cbe: bool = false;
198197 var target_dynamic_linker: ?[]const u8 = null;
198 var object_format: ?std.builtin.ObjectFormat = null;
199199
200200 var system_libs = std.ArrayList([]const u8).init(gpa);
201201 defer system_libs.deinit();
......@@ -283,7 +283,11 @@ fn buildOutputType(
283283 i += 1;
284284 target_mcpu = args[i];
285285 } else if (mem.eql(u8, arg, "--c")) {
286 cbe = true;
286 if (object_format) |old| {
287 std.debug.print("attempted to override object format {} with C\n", .{old});
288 process.exit(1);
289 }
290 object_format = .c;
287291 } else if (mem.startsWith(u8, arg, "-mcpu=")) {
288292 target_mcpu = arg["-mcpu=".len..];
289293 } else if (mem.eql(u8, arg, "--dynamic-linker")) {
......@@ -417,7 +421,6 @@ fn buildOutputType(
417421 else => |e| return e,
418422 };
419423
420 const object_format: ?std.builtin.ObjectFormat = null;
421424 var target_info = try std.zig.system.NativeTargetInfo.detect(gpa, cross_target);
422425 if (target_info.cpu_detection_unimplemented) {
423426 // TODO We want to just use detected_info.target but implementing
......@@ -436,7 +439,7 @@ fn buildOutputType(
436439 std.debug.print("-fno-emit-bin not supported yet", .{});
437440 process.exit(1);
438441 },
439 .yes_default_path => if (cbe)
442 .yes_default_path => if (object_format != null and object_format.? == .c)
440443 try std.fmt.allocPrint(arena, "{}.c", .{root_name})
441444 else
442445 try std.zig.binNameAlloc(arena, root_name, target_info.target, output_mode, link_mode),
......@@ -470,7 +473,6 @@ fn buildOutputType(
470473 .object_format = object_format,
471474 .optimize_mode = build_mode,
472475 .keep_source_files_loaded = zir_out_path != null,
473 .cbe = cbe,
474476 });
475477 defer module.deinit();
476478
src-self-hosted/test.zig+1-1
......@@ -444,7 +444,7 @@ pub const TestContext = struct {
444444 .bin_file_path = bin_name,
445445 .root_pkg = root_pkg,
446446 .keep_source_files_loaded = true,
447 .cbe = case.cbe,
447 .object_format = if (case.cbe) .c else null,
448448 });
449449 defer module.deinit();
450450