| author |  Jacob Young <jacobly@ziglang.org> 2026-06-02 13:50:50-04:00 |
| committer | Jacob Young <jacobly@ziglang.org> 2026-06-03 22:28:39+02:00 |
| log | 3391ad7a9091edec0b368b0e98e61ec02043e91b |
| tree | 20dd8e738a7abe22e9807a4561b75de4f9ca2c96 |
| parent | 22aa2bd1e775d5ec144711642ad5c0d7c99b4398 |
x86_64: implement and test `@intFromBool`
Also fixes, for the x86_64 backend, #319633 files changed, 31 insertions(+), 3 deletions(-)
src- Air
- codegen
- x86_64
- test
- behavior
- x86_64
src/Air/print.zig-1
| ... | @@ -516,7 +516,6 @@ const Writer = struct { | ... | @@ -516,7 +516,6 @@ const Writer = struct { |
| 516 | try w.writeOperand(s, inst, 1, bin.lhs); | 516 | try w.writeOperand(s, inst, 1, bin.lhs); |
| 517 | try s.writeAll(", "); | 517 | try s.writeAll(", "); |
| 518 | try w.writeOperand(s, inst, 2, bin.rhs); | 518 | try w.writeOperand(s, inst, 2, bin.rhs); |
| 519 | try s.writeAll(", "); | ||
| 520 | } | 519 | } |
| 521 | 520 | ||
| 522 | fn writeLegalizeCompilerRtCall(w: *Writer, s: *std.Io.Writer, inst: Air.Inst.Index) Error!void { | 521 | fn writeLegalizeCompilerRtCall(w: *Writer, s: *std.Io.Writer, inst: Air.Inst.Index) Error!void { |
src/codegen/x86_64/CodeGen.zig+21-2
| ... | @@ -179453,7 +179453,26 @@ fn airBitCast(self: *CodeGen, inst: Air.Inst.Index) !void { | ... | @@ -179453,7 +179453,26 @@ fn airBitCast(self: *CodeGen, inst: Air.Inst.Index) !void { |
| 179453 | .gt => src_ty, | 179453 | .gt => src_ty, |
| 179454 | }, | 179454 | }, |
| 179455 | .register_mask => src_ty, | 179455 | .register_mask => src_ty, |
| 179456 | }, dst_mcv, src_mcv, .{}); | 179456 | }, dst_mcv, if (src_ty.isVector(zcu) and src_ty.childType(zcu).toIntern() == .bool_type) src_mcv: { |
| 179457 | try self.spillEflagsIfOccupied(); | ||
| 179458 | const dst_signedness: std.builtin.Signedness = if (dst_ty.scalarType(zcu).isSignedInt(zcu)) .signed else .unsigned; | ||
| 179459 | switch (src_mcv) { | ||
| 179460 | .immediate => |src_imm| break :src_mcv .{ .immediate = switch (dst_signedness) { | ||
| 179461 | .unsigned => @as(u1, @truncate(src_imm)), | ||
| 179462 | .signed => @as(u8, @bitCast(@as(i8, @as(i1, @bitCast(@as(u1, @truncate(src_imm))))))), | ||
| 179463 | } }, | ||
| 179464 | else => { | ||
| 179465 | try self.spillEflagsIfOccupied(); | ||
| 179466 | const tmp_reg = try self.copyToTmpRegister(.u8, src_mcv); | ||
| 179467 | try self.asmRegisterImmediate(.{ ._, .@"and" }, tmp_reg.to8(), .u(1)); | ||
| 179468 | switch (dst_signedness) { | ||
| 179469 | .unsigned => {}, | ||
| 179470 | .signed => try self.asmRegister(.{ ._, .neg }, tmp_reg.to8()), | ||
| 179471 | } | ||
| 179472 | break :src_mcv .{ .register = tmp_reg }; | ||
| 179473 | }, | ||
| 179474 | } | ||
| 179475 | } else src_mcv, .{}); | ||
| 179457 | break :dst dst_mcv; | 179476 | break :dst dst_mcv; |
| 179458 | }; | 179477 | }; |
| 179459 | 179478 | ||
| ... | @@ -182778,7 +182797,7 @@ const Temp = struct { | ... | @@ -182778,7 +182797,7 @@ const Temp = struct { |
| 182778 | break :part_ty .usize; | 182797 | break :part_ty .usize; |
| 182779 | }, | 182798 | }, |
| 182780 | }, | 182799 | }, |
| 182781 | .struct_type => { | 182800 | .struct_type, .union_type => { |
| 182782 | assert(src_regs.len - part_index == std.math.divCeil(u32, src_abi_size, 8) catch unreachable); | 182801 | assert(src_regs.len - part_index == std.math.divCeil(u32, src_abi_size, 8) catch unreachable); |
| 182783 | break :part_ty switch (src_abi_size) { | 182802 | break :part_ty switch (src_abi_size) { |
| 182784 | 0, 3, 5...7 => unreachable, | 182803 | 0, 3, 5...7 => unreachable, |
test/behavior/x86_64/unary.zig+10
| ... | @@ -1,5 +1,6 @@ | ... | @@ -1,5 +1,6 @@ |
| 1 | const AsSignedness = math.AsSignedness; | 1 | const AsSignedness = math.AsSignedness; |
| 2 | const checkExpected = math.checkExpected; | 2 | const checkExpected = math.checkExpected; |
| 3 | const ChangeScalar = math.ChangeScalar; | ||
| 3 | const Compare = math.Compare; | 4 | const Compare = math.Compare; |
| 4 | const fmax = math.fmax; | 5 | const fmax = math.fmax; |
| 5 | const fmin = math.fmin; | 6 | const fmin = math.fmin; |
| ... | @@ -4890,6 +4891,15 @@ test bitNot { | ... | @@ -4890,6 +4891,15 @@ test bitNot { |
| 4890 | try test_bit_not.testIntVectors(); | 4891 | try test_bit_not.testIntVectors(); |
| 4891 | } | 4892 | } |
| 4892 | 4893 | ||
| 4894 | inline fn intFromBool(comptime Type: type, rhs: Type) ChangeScalar(Type, u1) { | ||
| 4895 | return @intFromBool(rhs); | ||
| 4896 | } | ||
| 4897 | test intFromBool { | ||
| 4898 | const test_int_from_bool = unary(intFromBool, .{}); | ||
| 4899 | try test_int_from_bool.testBools(); | ||
| 4900 | try test_int_from_bool.testBoolVectors(); | ||
| 4901 | } | ||
| 4902 | |||
| 4893 | inline fn clz(comptime Type: type, rhs: Type) Log2IntCeil(Type) { | 4903 | inline fn clz(comptime Type: type, rhs: Type) Log2IntCeil(Type) { |
| 4894 | return @clz(rhs); | 4904 | return @clz(rhs); |
| 4895 | } | 4905 | } |