| author |  Alex Rønne Petersen <alex@alexrp.com> 2026-03-25 03:45:10+01:00 |
| committer | Alex Rønne Petersen <alex@alexrp.com> 2026-03-25 19:33:43+01:00 |
| log | 5e0e1841c060ea823d8869b8408e18eec52cba71 |
| tree | b09d550598690d166e5848e09c143527c68fae68 |
| parent | 8a517285cebb007f14d499c611f3a052f45f0683 |
Compilation: close the linker output file before writing whole cache manifest
Otherwise a different process may get a cache hit on the file while we still
have a writable fd open for it. This isn't actually a real problem in the sense
that running the file should just work as expected if the OS allows it. But
until very recently[0], the Linux kernel would give ETXTBSY in this case. So
make sure we close the file before letting other processes know that it's
usable.
closes https://codeberg.org/ziglang/zig/issues/31563
[0] https://github.com/torvalds/linux/commit/2a010c41285345da60cece35575b4e0af7e7bf441 files changed, 5 insertions(+), 5 deletions(-)
src/Compilation.zig+5-5
| ... | ... | @@ -3230,16 +3230,16 @@ pub fn update(comp: *Compilation, main_progress_node: std.Progress.Node) UpdateE |
| 3230 | 3230 | // cache manifest must not be written. |
| 3231 | 3231 | if (anyErrors(comp)) return; |
| 3232 | 3232 | |
| 3233 | // Failure here only means an unnecessary cache miss. | |
| 3234 | man.writeManifest() catch |err| { | |
| 3235 | log.warn("failed to write cache manifest: {s}", .{@errorName(err)}); | |
| 3236 | }; | |
| 3237 | ||
| 3238 | 3233 | if (comp.bin_file) |lf| { |
| 3239 | 3234 | lf.destroy(); |
| 3240 | 3235 | comp.bin_file = null; |
| 3241 | 3236 | } |
| 3242 | 3237 | |
| 3238 | // Failure here only means an unnecessary cache miss. | |
| 3239 | man.writeManifest() catch |err| { | |
| 3240 | log.warn("failed to write cache manifest: {s}", .{@errorName(err)}); | |
| 3241 | }; | |
| 3242 | ||
| 3243 | 3243 | assert(whole.lock == null); |
| 3244 | 3244 | whole.lock = man.toOwnedLock(); |
| 3245 | 3245 | }, |