authorgravatar for kubkon@jakubkonka.comJakub Konka <kubkon@jakubkonka.com> 2023-11-15 19:20:03+01:00
committergravatar for kubkon@jakubkonka.comJakub Konka <kubkon@jakubkonka.com> 2023-11-15 19:20:03+01:00
log6e4d7362cedd9570bb32868d868877d6ba39c156
tree5041d6b759152e2021cd4bedeaa1af4a123d4dfa
parentd771c0a7a19a4d39e1541afa0bf69935daa5222e

elf: fix emitting start/stop synthetic symbols


1 files changed, 23 insertions(+), 24 deletions(-)

src/link/Elf.zig+23-24
......@@ -1208,14 +1208,15 @@ pub fn flushModule(self: *Elf, comp: *Compilation, prog_node: *std.Progress.Node
12081208 }
12091209 }
12101210
1211 try self.initOutputSections();
12111212 try self.addLinkerDefinedSymbols();
12121213 self.claimUnresolved();
12131214
12141215 // Scan and create missing synthetic entries such as GOT indirection.
12151216 try self.scanRelocs();
12161217
1217 // Generate and emit non-incremental sections.
1218 try self.initSections();
1218 // Generate and emit synthetic sections.
1219 try self.initSyntheticSections();
12191220 try self.initSpecialPhdrs();
12201221 try self.sortShdrs();
12211222 for (self.objects.items) |index| {
......@@ -3210,21 +3211,18 @@ fn addLinkerDefinedSymbols(self: *Elf) !void {
32103211 self.rela_iplt_start_index = try linker_defined.addGlobal("__rela_iplt_start", self);
32113212 self.rela_iplt_end_index = try linker_defined.addGlobal("__rela_iplt_end", self);
32123213
3213 for (self.objects.items) |index| {
3214 const object = self.file(index).?.object;
3215 for (object.atoms.items) |atom_index| {
3216 if (self.getStartStopBasename(atom_index)) |name| {
3217 const gpa = self.base.allocator;
3218 try self.start_stop_indexes.ensureUnusedCapacity(gpa, 2);
3219
3220 const start = try std.fmt.allocPrintZ(gpa, "__start_{s}", .{name});
3221 defer gpa.free(start);
3222 const stop = try std.fmt.allocPrintZ(gpa, "__stop_{s}", .{name});
3223 defer gpa.free(stop);
3224
3225 self.start_stop_indexes.appendAssumeCapacity(try linker_defined.addGlobal(start, self));
3226 self.start_stop_indexes.appendAssumeCapacity(try linker_defined.addGlobal(stop, self));
3227 }
3214 for (self.shdrs.items) |shdr| {
3215 if (self.getStartStopBasename(shdr)) |name| {
3216 const gpa = self.base.allocator;
3217 try self.start_stop_indexes.ensureUnusedCapacity(gpa, 2);
3218
3219 const start = try std.fmt.allocPrintZ(gpa, "__start_{s}", .{name});
3220 defer gpa.free(start);
3221 const stop = try std.fmt.allocPrintZ(gpa, "__stop_{s}", .{name});
3222 defer gpa.free(stop);
3223
3224 self.start_stop_indexes.appendAssumeCapacity(try linker_defined.addGlobal(start, self));
3225 self.start_stop_indexes.appendAssumeCapacity(try linker_defined.addGlobal(stop, self));
32283226 }
32293227 }
32303228
......@@ -3354,12 +3352,14 @@ fn allocateLinkerDefinedSymbols(self: *Elf) void {
33543352 }
33553353}
33563354
3357fn initSections(self: *Elf) !void {
3358 const ptr_size = self.ptrWidthBytes();
3359
3355fn initOutputSections(self: *Elf) !void {
33603356 for (self.objects.items) |index| {
33613357 try self.file(index).?.object.initOutputSections(self);
33623358 }
3359}
3360
3361fn initSyntheticSections(self: *Elf) !void {
3362 const ptr_size = self.ptrWidthBytes();
33633363
33643364 const needs_eh_frame = for (self.objects.items) |index| {
33653365 if (self.file(index).?.object.cies.items.len > 0) break true;
......@@ -5748,10 +5748,9 @@ pub fn isCIdentifier(name: []const u8) bool {
57485748 return true;
57495749}
57505750
5751fn getStartStopBasename(self: *Elf, atom_index: Atom.Index) ?[]const u8 {
5752 const atom_ptr = self.atom(atom_index) orelse return null;
5753 const name = atom_ptr.name(self);
5754 if (atom_ptr.inputShdr(self).sh_flags & elf.SHF_ALLOC != 0 and name.len > 0) {
5751fn getStartStopBasename(self: *Elf, shdr: elf.Elf64_Shdr) ?[]const u8 {
5752 const name = self.getShString(shdr.sh_name);
5753 if (shdr.sh_flags & elf.SHF_ALLOC != 0 and name.len > 0) {
57555754 if (isCIdentifier(name)) return name;
57565755 }
57575756 return null;