Commit 76fb3e062161e84554e0665444135281f7bcaf74 | zig

author	Jakub Konka <kubkon@jakubkonka.com> 2022-11-06 00:36:27+01:00
committer	Jakub Konka <kubkon@jakubkonka.com> 2022-11-06 00:36:27+01:00
log	76fb3e062161e84554e0665444135281f7bcaf74
tree	95ba509db81c7e25678dad4debde931de93b91b1
parent	aaaa7df15264edd38d755eb77253d54073e9f192

macho: do not zero-out file if there are no nonzerofill sects

If the `__DATA` segment comprises of only zerofill sections, do not
accidentally zero out all of file.

1 files changed, 7 insertions(+), 10 deletions(-)

src
- link
  - MachO
    zld.zig

src/link/MachO/zld.zig+7-10

 @@ -4305,24 +4305,21 @@ pub fn linkWithZld(macho_file: *MachO, comp: *Compilation, prog_node: *std.Progr
         // segment and the beginning of __LINKEDIT segment is zerofilled as the loader will
         // copy-paste this space into memory for quicker zerofill operation.
         if (zld.getSegmentByName("__DATA")) |data_seg_id| blk: {
-            var physical_zerofill_start: u64 = 0;
+            var physical_zerofill_start: ?u64 = null;
             const section_indexes = zld.getSectionIndexes(data_seg_id);
             for (zld.sections.items(.header)[section_indexes.start..section_indexes.end]) |header| {
                 if (header.isZerofill() and header.size > 0) break;
                 physical_zerofill_start = header.offset + header.size;
             } else break :blk;
+            const start = physical_zerofill_start orelse break :blk;
             const linkedit = zld.getLinkeditSegmentPtr();
-            const physical_zerofill_size = math.cast(usize, linkedit.fileoff - physical_zerofill_start) orelse
+            const size = math.cast(usize, linkedit.fileoff - start) orelse return error.Overflow;
-                return error.Overflow;
+            if (size > 0) {
-            if (physical_zerofill_size > 0) {
+                log.debug("zeroing out zerofill area of length {x} at {x}", .{ size, start });
-                log.debug("zeroing out zerofill area of length {x} at {x}", .{
+                var padding = try zld.gpa.alloc(u8, size);
-                    physical_zerofill_size,
-                    physical_zerofill_start,
-                });
-                var padding = try zld.gpa.alloc(u8, physical_zerofill_size);
                 defer zld.gpa.free(padding);
                 mem.set(u8, padding, 0);
-                try zld.file.pwriteAll(padding, physical_zerofill_start);
+                try zld.file.pwriteAll(padding, start);
             }
         }