Commit 8de45e51438d7f593825ae2134ab7dfc46f3bab2 | zig

author	momumi <57862114+momumi@users.noreply.github.com> 2020-03-22 13:45:31+10:00
committer	momumi <57862114+momumi@users.noreply.github.com> 2020-03-22 13:59:14+10:00
log	8de45e51438d7f593825ae2134ab7dfc46f3bab2
tree	ebf5cb2d0f7a6e43241e9755f0f84a33e9b29ffb
parent	29324e6f393011ee010b80f2c88d946f082bef22

update parsing of int literals in self-hosted

* update std.math.big.Int.setString() to ignore underscores and make it
  case insensitive
* fix issue in ir.zig with leading zeroes in integer literals

2 files changed, 28 insertions(+), 4 deletions(-)

lib
- std
  - math
    big
    int.zig
src-self-hosted
- ir.zig

lib/std/math/big/int.zig+23-2

 @@ -373,6 +373,7 @@ pub const Int = struct {
         const d = switch (ch) {
             '0'...'9' => ch - '0',
             'a'...'f' => (ch - 'a') + 0xa,
+            'A'...'F' => (ch - 'A') + 0xa,
             else => return error.InvalidCharForDigit,
         };
 @@ -393,8 +394,9 @@ pub const Int = struct {
     /// Set self from the string representation `value`.
     ///
-    /// value must contain only digits <= `base`. Base prefixes are not allowed (e.g. 0x43 should
+    /// `value` must contain only digits <= `base` and is case insensitive.  Base prefixes are
-    /// simply be 43).
+    /// not allowed (e.g. 0x43 should simply be 43).  Underscores in the input string are
+    /// ignored and can be used as digit separators.
     ///
     /// Returns an error if memory could not be allocated or `value` has invalid digits for the
     /// requested base.
 @@ -415,6 +417,9 @@ pub const Int = struct {
         try self.set(0);
         for (value[i..]) |ch| {
+            if (ch == '_') {
+                continue;
+            }
             const d = try charToDigit(ch, base);
             const ap_d = Int.initFixed(([_]Limb{d})[0..]);
 @@ -1582,6 +1587,22 @@ test "big.int string negative" {
     testing.expect((try a.to(i32)) == -1023);
 }
+test "big.int string set number with underscores" {
+    var a = try Int.init(testing.allocator);
+    defer a.deinit();
+    try a.setString(10, "__1_2_0_3_1_7_2_4_1_2_0_____9_1__2__4_7_8_1_2_4_1_2_9_0_8_4_7_1_2_4___");
+    testing.expect((try a.to(u128)) == 120317241209124781241290847124);
+}
+test "big.int string set case insensitive number" {
+    var a = try Int.init(testing.allocator);
+    defer a.deinit();
+    try a.setString(16, "aB_cD_eF");
+    testing.expect((try a.to(u32)) == 0xabcdef);
+}
 test "big.int string set bad char error" {
     var a = try Int.init(testing.allocator);
     defer a.deinit();

src-self-hosted/ir.zig+5-2

 @@ -1311,13 +1311,16 @@ pub const Builder = struct {
         var base: u8 = undefined;
         var rest: []const u8 = undefined;
         if (int_token.len >= 3 and int_token[0] == '0') {
+            rest = int_token[2..];
             base = switch (int_token[1]) {
                 'b' => 2,
                 'o' => 8,
                 'x' => 16,
-                else => unreachable,
+                else => {
+                    base = 10;
+                    rest = int_token;
+                },
             };
-            rest = int_token[2..];
         } else {
             base = 10;
             rest = int_token;