authorgravatar for kubkon@jakubkonka.comJakub Konka <kubkon@jakubkonka.com> 2024-09-24 11:45:01+02:00
committergravatar for kubkon@jakubkonka.comJakub Konka <kubkon@jakubkonka.com> 2024-09-25 17:54:50+02:00
log992c6c3f68dba24c1ca92cd7e78716d2fd336495
tree8466ddc8351bc912f30be863a4b728fab0fedcae
parent82cf762b0205f036677d234abb35bf1deafb5c7e

elf: reset output symtab contexts before re-updating


1 files changed, 17 insertions(+), 1 deletions(-)

src/link/Elf.zig+17-1
......@@ -4127,6 +4127,7 @@ pub fn updateSymtabSize(self: *Elf) !void {
41274127 nlocals += @intCast(self.sections.slice().len);
41284128
41294129 if (self.requiresThunks()) for (self.thunks.items) |*th| {
4130 th.output_symtab_ctx.reset();
41304131 th.output_symtab_ctx.ilocal = nlocals;
41314132 th.calcSymtabSize(self);
41324133 nlocals += th.output_symtab_ctx.nlocals;
......@@ -4138,6 +4139,7 @@ pub fn updateSymtabSize(self: *Elf) !void {
41384139 const ctx = switch (file_ptr) {
41394140 inline else => |x| &x.output_symtab_ctx,
41404141 };
4142 ctx.reset();
41414143 ctx.ilocal = nlocals;
41424144 ctx.iglobal = nglobals;
41434145 try file_ptr.updateSymtabSize(self);
......@@ -4147,6 +4149,7 @@ pub fn updateSymtabSize(self: *Elf) !void {
41474149 }
41484150
41494151 if (self.got_section_index) |_| {
4152 self.got.output_symtab_ctx.reset();
41504153 self.got.output_symtab_ctx.ilocal = nlocals;
41514154 self.got.updateSymtabSize(self);
41524155 nlocals += self.got.output_symtab_ctx.nlocals;
......@@ -4154,6 +4157,7 @@ pub fn updateSymtabSize(self: *Elf) !void {
41544157 }
41554158
41564159 if (self.plt_section_index) |_| {
4160 self.plt.output_symtab_ctx.reset();
41574161 self.plt.output_symtab_ctx.ilocal = nlocals;
41584162 self.plt.updateSymtabSize(self);
41594163 nlocals += self.plt.output_symtab_ctx.nlocals;
......@@ -4161,6 +4165,7 @@ pub fn updateSymtabSize(self: *Elf) !void {
41614165 }
41624166
41634167 if (self.plt_got_section_index) |_| {
4168 self.plt_got.output_symtab_ctx.reset();
41644169 self.plt_got.output_symtab_ctx.ilocal = nlocals;
41654170 self.plt_got.updateSymtabSize(self);
41664171 nlocals += self.plt_got.output_symtab_ctx.nlocals;
......@@ -4359,6 +4364,9 @@ pub fn writeSymtab(self: *Elf) !void {
43594364
43604365 try self.symtab.resize(gpa, nsyms);
43614366 const needed_strtab_size = math.cast(usize, strtab_shdr.sh_size - 1) orelse return error.Overflow;
4367 // TODO we could resize instead and in ZigObject/Object always access as slice
4368 self.strtab.clearRetainingCapacity();
4369 self.strtab.appendAssumeCapacity(0);
43624370 try self.strtab.ensureUnusedCapacity(gpa, needed_strtab_size);
43634371
43644372 for (slice.items(.shdr), 0..) |shdr, shndx| {
......@@ -5330,7 +5338,7 @@ fn fmtDumpState(
53305338 {
53315339 try writer.writeAll("atom lists\n");
53325340 for (slice.items(.shdr), slice.items(.atom_list_2), 0..) |shdr, atom_list, shndx| {
5333 try writer.print("shdr({d}) : {s} : {}", .{ shndx, self.getShString(shdr.sh_name), atom_list.fmt(self) });
5341 try writer.print("shdr({d}) : {s} : {}\n", .{ shndx, self.getShString(shdr.sh_name), atom_list.fmt(self) });
53345342 }
53355343 }
53365344
......@@ -5462,6 +5470,14 @@ pub const SymtabCtx = struct {
54625470 nlocals: u32 = 0,
54635471 nglobals: u32 = 0,
54645472 strsize: u32 = 0,
5473
5474 pub fn reset(ctx: *SymtabCtx) void {
5475 ctx.ilocal = 0;
5476 ctx.iglobal = 0;
5477 ctx.nlocals = 0;
5478 ctx.nglobals = 0;
5479 ctx.strsize = 0;
5480 }
54655481};
54665482
54675483pub const null_sym = elf.Elf64_Sym{