authorgravatar for 124872+jedisct1@users.noreply.github.comFrank Denis <124872+jedisct1@users.noreply.github.com> 2021-08-24 02:06:02+02:00
committergravatar for andrew@ziglang.orgAndrew Kelley <andrew@ziglang.org> 2021-08-31 13:44:23-07:00
loga1d532752f5c2f41a9cb21d9a06c9bf3b1bd8adc
treeada4544a1c950b37cad27a1fe23b86d68f2cf6d5
parent258845196702f458d00d7e974f05437100c8fc8f

Don't define valgrind_support on macOS (#9612)

Unfortunately, Valgrind for macOS has been broken for years, and the Homebrew formula is only for Linux.

2 files changed, 2 insertions(+), 2 deletions(-)

src/stage1/target.cpp+1-1
...@@ -914,7 +914,7 @@ bool target_has_valgrind_support(const ZigTarget *target) {...@@ -914,7 +914,7 @@ bool target_has_valgrind_support(const ZigTarget *target) {
914 case ZigLLVM_UnknownArch:914 case ZigLLVM_UnknownArch:
915 zig_unreachable();915 zig_unreachable();
916 case ZigLLVM_x86_64:916 case ZigLLVM_x86_64:
917 return (target->os == OsLinux || target_os_is_darwin(target->os) || target->os == OsSolaris ||917 return (target->os == OsLinux || target->os == OsSolaris ||
918 (target->os == OsWindows && target->abi != ZigLLVM_MSVC));918 (target->os == OsWindows && target->abi != ZigLLVM_MSVC));
919 default:919 default:
920 return false;920 return false;
src/target.zig+1-1
...@@ -163,7 +163,7 @@ pub fn isSingleThreaded(target: std.Target) bool {...@@ -163,7 +163,7 @@ pub fn isSingleThreaded(target: std.Target) bool {
163pub fn hasValgrindSupport(target: std.Target) bool {163pub fn hasValgrindSupport(target: std.Target) bool {
164 switch (target.cpu.arch) {164 switch (target.cpu.arch) {
165 .x86_64 => {165 .x86_64 => {
166 return target.os.tag == .linux or target.isDarwin() or target.os.tag == .solaris or166 return target.os.tag == .linux or target.os.tag == .solaris or
167 (target.os.tag == .windows and target.abi != .msvc);167 (target.os.tag == .windows and target.abi != .msvc);
168 },168 },
169 else => return false,169 else => return false,