| author |  Andrew Kelley <andrew@ziglang.org> 2022-08-23 21:24:03-07:00 |
| committer | Andrew Kelley <andrew@ziglang.org> 2022-08-23 21:24:03-07:00 |
| log | a31b449b55c32eba1cb61a48753a6fc98696c98f |
| tree | d4141e59b51882e94a98ac5c9e023b22af1ddc66 |
| parent | 60722261fa465ecff559c9903e0855d538826ed4 |
make LLVM and Clang emit DWARF 4 instead of 5
This reverts 6d679eb2bcbe76e389c02e0bb4d4c4feb2847783 and additionally
changes the command line parameters passed to Clang to match.
Clang 14 defaults to DWARFv5 which is an interesting choice. v5 has been
out for 5 years and yet Valgrind does not support it, and apparently
neither does either GDB or LLD, I haven't determined which, but I wasn't
able to use GDB to debug my LLVM-emitted dwarf 5 zig code that was linked
with LLD.
A couple years ago when I was working on the self-hosted ELF linker, I
emitted DWARFv5 but then downgraded to v4 when I realized that third
party tools were stuck in the past. Years later, they still are.
Hopefully, Clang 14's bold move will inspire third party tools to get
their shit together, however, in the meantime, everything's broken, so
we're passing `-gdwarf-4` to clang and instructing LLVM to emit DWARFv4.
Note that Zig's std.debug code *does* support DWARFv5 already as of a
previous commit that I made today.2 files changed, 3 insertions(+), 3 deletions(-)
src/Compilation.zig+2-2
| ... | @@ -4085,10 +4085,10 @@ pub fn addCCArgs( | ... | @@ -4085,10 +4085,10 @@ pub fn addCCArgs( |
| 4085 | } | 4085 | } |
| 4086 | 4086 | ||
| 4087 | if (!comp.bin_file.options.strip) { | 4087 | if (!comp.bin_file.options.strip) { |
| 4088 | try argv.append("-g"); | ||
| 4089 | switch (target.ofmt) { | 4088 | switch (target.ofmt) { |
| 4090 | .coff => try argv.append("-gcodeview"), | 4089 | .coff => try argv.append("-gcodeview"), |
| 4091 | else => {}, | 4090 | .elf, .macho => try argv.append("-gdwarf-4"), |
| 4091 | else => try argv.append("-g"), | ||
| 4092 | } | 4092 | } |
| 4093 | } | 4093 | } |
| 4094 | 4094 |
src/zig_llvm.cpp+1-1
| ... | @@ -1130,7 +1130,7 @@ void ZigLLVMGetNativeTarget(ZigLLVM_ArchType *arch_type, | ... | @@ -1130,7 +1130,7 @@ void ZigLLVMGetNativeTarget(ZigLLVM_ArchType *arch_type, |
| 1130 | 1130 | ||
| 1131 | void ZigLLVMAddModuleDebugInfoFlag(LLVMModuleRef module) { | 1131 | void ZigLLVMAddModuleDebugInfoFlag(LLVMModuleRef module) { |
| 1132 | unwrap(module)->addModuleFlag(Module::Warning, "Debug Info Version", DEBUG_METADATA_VERSION); | 1132 | unwrap(module)->addModuleFlag(Module::Warning, "Debug Info Version", DEBUG_METADATA_VERSION); |
| 1133 | unwrap(module)->addModuleFlag(Module::Warning, "Dwarf Version", 5); | 1133 | unwrap(module)->addModuleFlag(Module::Warning, "Dwarf Version", 4); |
| 1134 | } | 1134 | } |
| 1135 | 1135 | ||
| 1136 | void ZigLLVMAddModuleCodeViewFlag(LLVMModuleRef module) { | 1136 | void ZigLLVMAddModuleCodeViewFlag(LLVMModuleRef module) { |