authorgravatar for andrew@ziglang.orgAndrew Kelley <andrew@ziglang.org> 2019-08-05 00:44:39-04:00
committergravatar for andrew@ziglang.orgAndrew Kelley <andrew@ziglang.org> 2019-08-05 00:44:39-04:00
loga7763c06f9941bdeccc0679abf863b21f7cc33a3
tree7ff99dcfdb8a1c73b83a599cc37ad6915e0bad31
parent0d8c9fcb18b399bd2afedbcbcc7736326ef92297
signature Commit is signed but in an unrecognized format.

delete IrInstructionMarkErrRetTracePtr

this IR instruction is no longer needed

5 files changed, 0 insertions(+), 54 deletions(-)

BRANCH_TODO-1
......@@ -1,4 +1,3 @@
1 * delete IrInstructionMarkErrRetTracePtr
21 * go over the commented out tests
32 * error return tracing
43 * compile error for error: expected anyframe->T, found 'anyframe'
src/all_types.hpp-7
......@@ -2334,7 +2334,6 @@ enum IrInstructionId {
23342334 IrInstructionIdAtomicLoad,
23352335 IrInstructionIdSaveErrRetAddr,
23362336 IrInstructionIdAddImplicitReturnType,
2337 IrInstructionIdMarkErrRetTracePtr,
23382337 IrInstructionIdErrSetCast,
23392338 IrInstructionIdToBytes,
23402339 IrInstructionIdFromBytes,
......@@ -3451,12 +3450,6 @@ struct IrInstructionAddImplicitReturnType {
34513450 IrInstruction *value;
34523451};
34533452
3454struct IrInstructionMarkErrRetTracePtr {
3455 IrInstruction base;
3456
3457 IrInstruction *err_ret_trace_ptr;
3458};
3459
34603453// For float ops which take a single argument
34613454struct IrInstructionFloatOp {
34623455 IrInstruction base;
src/codegen.cpp-10
......@@ -5062,14 +5062,6 @@ static LLVMValueRef ir_render_atomic_load(CodeGen *g, IrExecutable *executable,
50625062 return load_inst;
50635063}
50645064
5065static LLVMValueRef ir_render_mark_err_ret_trace_ptr(CodeGen *g, IrExecutable *executable,
5066 IrInstructionMarkErrRetTracePtr *instruction)
5067{
5068 assert(g->have_err_ret_tracing);
5069 g->cur_err_ret_trace_val_stack = ir_llvm_value(g, instruction->err_ret_trace_ptr);
5070 return nullptr;
5071}
5072
50735065static LLVMValueRef ir_render_float_op(CodeGen *g, IrExecutable *executable, IrInstructionFloatOp *instruction) {
50745066 LLVMValueRef op = ir_llvm_value(g, instruction->op1);
50755067 assert(instruction->base.value.type->id == ZigTypeIdFloat);
......@@ -5544,8 +5536,6 @@ static LLVMValueRef ir_render_instruction(CodeGen *g, IrExecutable *executable,
55445536 return ir_render_atomic_load(g, executable, (IrInstructionAtomicLoad *)instruction);
55455537 case IrInstructionIdSaveErrRetAddr:
55465538 return ir_render_save_err_ret_addr(g, executable, (IrInstructionSaveErrRetAddr *)instruction);
5547 case IrInstructionIdMarkErrRetTracePtr:
5548 return ir_render_mark_err_ret_trace_ptr(g, executable, (IrInstructionMarkErrRetTracePtr *)instruction);
55495539 case IrInstructionIdFloatOp:
55505540 return ir_render_float_op(g, executable, (IrInstructionFloatOp *)instruction);
55515541 case IrInstructionIdMulAdd:
src/ir.cpp-27
......@@ -993,10 +993,6 @@ static constexpr IrInstructionId ir_instruction_id(IrInstructionAddImplicitRetur
993993 return IrInstructionIdAddImplicitReturnType;
994994}
995995
996static constexpr IrInstructionId ir_instruction_id(IrInstructionMarkErrRetTracePtr *) {
997 return IrInstructionIdMarkErrRetTracePtr;
998}
999
1000996static constexpr IrInstructionId ir_instruction_id(IrInstructionFloatOp *) {
1001997 return IrInstructionIdFloatOp;
1002998}
......@@ -3092,15 +3088,6 @@ static IrInstruction *ir_build_add_implicit_return_type(IrBuilder *irb, Scope *s
30923088 return &instruction->base;
30933089}
30943090
3095static IrInstruction *ir_build_mark_err_ret_trace_ptr(IrBuilder *irb, Scope *scope, AstNode *source_node, IrInstruction *err_ret_trace_ptr) {
3096 IrInstructionMarkErrRetTracePtr *instruction = ir_build_instruction<IrInstructionMarkErrRetTracePtr>(irb, scope, source_node);
3097 instruction->err_ret_trace_ptr = err_ret_trace_ptr;
3098
3099 ir_ref_instruction(err_ret_trace_ptr, irb->current_basic_block);
3100
3101 return &instruction->base;
3102}
3103
31043091static IrInstruction *ir_build_has_decl(IrBuilder *irb, Scope *scope, AstNode *source_node,
31053092 IrInstruction *container, IrInstruction *name)
31063093{
......@@ -23908,17 +23895,6 @@ static IrInstruction *ir_analyze_instruction_save_err_ret_addr(IrAnalyze *ira, I
2390823895 return result;
2390923896}
2391023897
23911static IrInstruction *ir_analyze_instruction_mark_err_ret_trace_ptr(IrAnalyze *ira, IrInstructionMarkErrRetTracePtr *instruction) {
23912 IrInstruction *err_ret_trace_ptr = instruction->err_ret_trace_ptr->child;
23913 if (type_is_invalid(err_ret_trace_ptr->value.type))
23914 return ira->codegen->invalid_instruction;
23915
23916 IrInstruction *result = ir_build_mark_err_ret_trace_ptr(&ira->new_irb, instruction->base.scope,
23917 instruction->base.source_node, err_ret_trace_ptr);
23918 result->value.type = ira->codegen->builtin_types.entry_void;
23919 return result;
23920}
23921
2392223898static void ir_eval_float_op(IrAnalyze *ira, IrInstructionFloatOp *source_instr, ZigType *float_type,
2392323899 ConstExprValue *op, ConstExprValue *out_val) {
2392423900 assert(ira && source_instr && float_type && out_val && op);
......@@ -24798,8 +24774,6 @@ static IrInstruction *ir_analyze_instruction_base(IrAnalyze *ira, IrInstruction
2479824774 return ir_analyze_instruction_save_err_ret_addr(ira, (IrInstructionSaveErrRetAddr *)instruction);
2479924775 case IrInstructionIdAddImplicitReturnType:
2480024776 return ir_analyze_instruction_add_implicit_return_type(ira, (IrInstructionAddImplicitReturnType *)instruction);
24801 case IrInstructionIdMarkErrRetTracePtr:
24802 return ir_analyze_instruction_mark_err_ret_trace_ptr(ira, (IrInstructionMarkErrRetTracePtr *)instruction);
2480324777 case IrInstructionIdFloatOp:
2480424778 return ir_analyze_instruction_float_op(ira, (IrInstructionFloatOp *)instruction);
2480524779 case IrInstructionIdMulAdd:
......@@ -24951,7 +24925,6 @@ bool ir_has_side_effects(IrInstruction *instruction) {
2495124925 case IrInstructionIdCancel:
2495224926 case IrInstructionIdSaveErrRetAddr:
2495324927 case IrInstructionIdAddImplicitReturnType:
24954 case IrInstructionIdMarkErrRetTracePtr:
2495524928 case IrInstructionIdAtomicRmw:
2495624929 case IrInstructionIdCmpxchgGen:
2495724930 case IrInstructionIdCmpxchgSrc:
src/ir_print.cpp-9
......@@ -1457,12 +1457,6 @@ static void ir_print_add_implicit_return_type(IrPrint *irp, IrInstructionAddImpl
14571457 fprintf(irp->f, ")");
14581458}
14591459
1460static void ir_print_mark_err_ret_trace_ptr(IrPrint *irp, IrInstructionMarkErrRetTracePtr *instruction) {
1461 fprintf(irp->f, "@markErrRetTracePtr(");
1462 ir_print_other_instruction(irp, instruction->err_ret_trace_ptr);
1463 fprintf(irp->f, ")");
1464}
1465
14661460static void ir_print_float_op(IrPrint *irp, IrInstructionFloatOp *instruction) {
14671461
14681462 fprintf(irp->f, "@%s(", float_op_to_name(instruction->op, false));
......@@ -1963,9 +1957,6 @@ static void ir_print_instruction(IrPrint *irp, IrInstruction *instruction) {
19631957 case IrInstructionIdAddImplicitReturnType:
19641958 ir_print_add_implicit_return_type(irp, (IrInstructionAddImplicitReturnType *)instruction);
19651959 break;
1966 case IrInstructionIdMarkErrRetTracePtr:
1967 ir_print_mark_err_ret_trace_ptr(irp, (IrInstructionMarkErrRetTracePtr *)instruction);
1968 break;
19691960 case IrInstructionIdFloatOp:
19701961 ir_print_float_op(irp, (IrInstructionFloatOp *)instruction);
19711962 break;