Commit a87b5332319b20347916f77e57253e2df4b2a3af | zig

author	Matthew Lugg <mlugg@mlugg.co.uk> 2025-11-19 17:11:41+00:00
committer	Matthew Lugg <mlugg@mlugg.co.uk> 2025-11-20 10:42:21+00:00
log	a87b5332319b20347916f77e57253e2df4b2a3af
tree	27f84c4981f878b2f5f0c9c9edb881d135ff1eb6
parent	b05fefb9c9bf3065e353102d0e54ea76d5f4e34d
signature	Commit is signed but in an unrecognized format.

std.Io.Writer: fix some bugs

1 files changed, 16 insertions(+), 6 deletions(-)

lib
- std
  - Io
    Writer.zig

lib/std/Io/Writer.zig+16-6

 @@ -270,16 +270,17 @@ fn writeSplatHeaderLimitFinish(
             remaining -= copy_len;
             if (remaining == 0) break :v;
         }
-        for (data[0 .. data.len - 1]) |buf| if (buf.len != 0) {
+        for (data[0 .. data.len - 1]) |buf| {
-            const copy_len = @min(header.len, remaining);
+            if (buf.len == 0) continue;
-            vecs[i] = buf;
+            const copy_len = @min(buf.len, remaining);
+            vecs[i] = buf[0..copy_len];
             i += 1;
             remaining -= copy_len;
             if (remaining == 0) break :v;
             if (vecs.len - i == 0) break :v;
-        };
+        }
         const pattern = data[data.len - 1];
-        if (splat == 1) {
+        if (splat == 1 or remaining < pattern.len) {
             vecs[i] = pattern[0..@min(remaining, pattern.len)];
             i += 1;
             break :v;
 @@ -915,7 +916,16 @@ pub fn sendFileHeader(
     if (new_end <= w.buffer.len) {
         @memcpy(w.buffer[w.end..][0..header.len], header);
         w.end = new_end;
-        return header.len + try w.vtable.sendFile(w, file_reader, limit);
+        const file_bytes = w.vtable.sendFile(w, file_reader, limit) catch |err| switch (err) {
+            error.ReadFailed, error.WriteFailed => |e| return e,
+            error.EndOfStream, error.Unimplemented => |e| {
+                // These errors are non-fatal, so if we wrote any header bytes, we will report that
+                // and suppress this error. Only if there was no header may we return the error.
+                if (header.len != 0) return header.len;
+                return e;
+            },
+        };
+        return header.len + file_bytes;
     }
     const buffered_contents = limit.slice(file_reader.interface.buffered());
     const n = try w.vtable.drain(w, &.{ header, buffered_contents }, 1);