authorgravatar for kubkon@jakubkonka.comJakub Konka <kubkon@jakubkonka.com> 2022-03-21 23:54:17+01:00
committergravatar for noreply@github.comGitHub <noreply@github.com> 2022-03-21 23:54:17+01:00
loga9b6de693ce04f73f8aecce91e8033951024c123
treea4600da1abaa7a18f3af1595dbb38b09d10955f4
parent916a65cb7bc96e5faa9337ab541d1ae230b48259
parent00e2113c8b07f9d1c67c7c70b69e7b9e6343b2d9
signature Signed by PGP key 4AEE18F83AFDEB23

Merge pull request #11223 from mparadinha/ptr-elem-val

stage2: x86_64: implement `ptr_elem_val`

3 files changed, 44 insertions(+), 16 deletions(-)

src/arch/x86_64/CodeGen.zig+43-9
......@@ -2174,10 +2174,44 @@ fn airArrayElemVal(self: *Self, inst: Air.Inst.Index) !void {
21742174fn airPtrElemVal(self: *Self, inst: Air.Inst.Index) !void {
21752175 const is_volatile = false; // TODO
21762176 const bin_op = self.air.instructions.items(.data)[inst].bin_op;
2177 const result: MCValue = if (!is_volatile and self.liveness.isUnused(inst))
2178 .dead
2179 else
2180 return self.fail("TODO implement ptr_elem_val for {}", .{self.target.cpu.arch});
2177 const result: MCValue = if (!is_volatile and self.liveness.isUnused(inst)) .dead else result: {
2178 // this is identical to the `airPtrElemPtr` codegen expect here an
2179 // additional `mov` is needed at the end to get the actual value
2180
2181 const ptr_ty = self.air.typeOf(bin_op.lhs);
2182 const ptr = try self.resolveInst(bin_op.lhs);
2183 ptr.freezeIfRegister(&self.register_manager);
2184 defer ptr.unfreezeIfRegister(&self.register_manager);
2185
2186 const elem_ty = ptr_ty.elemType2();
2187 const elem_abi_size = elem_ty.abiSize(self.target.*);
2188 const index_ty = self.air.typeOf(bin_op.rhs);
2189 const index = try self.resolveInst(bin_op.rhs);
2190 index.freezeIfRegister(&self.register_manager);
2191 defer index.unfreezeIfRegister(&self.register_manager);
2192
2193 const offset_reg = try self.elemOffset(index_ty, index, elem_abi_size);
2194 self.register_manager.freezeRegs(&.{offset_reg});
2195 defer self.register_manager.unfreezeRegs(&.{offset_reg});
2196
2197 const dst_mcv = try self.copyToRegisterWithInstTracking(inst, ptr_ty, ptr);
2198 try self.genBinMathOpMir(.add, ptr_ty, dst_mcv, .{ .register = offset_reg });
2199 if (elem_abi_size > 8) {
2200 return self.fail("TODO copy value with size {} from pointer", .{elem_abi_size});
2201 } else {
2202 // mov dst_mcv, [dst_mcv]
2203 _ = try self.addInst(.{
2204 .tag = .mov,
2205 .ops = (Mir.Ops{
2206 .flags = 0b01,
2207 .reg1 = registerAlias(dst_mcv.register, @intCast(u32, elem_abi_size)),
2208 .reg2 = dst_mcv.register,
2209 }).encode(),
2210 .data = .{ .imm = 0 },
2211 });
2212 break :result .{ .register = registerAlias(dst_mcv.register, @intCast(u32, elem_abi_size)) };
2213 }
2214 };
21812215 return self.finishAir(inst, result, .{ bin_op.lhs, bin_op.rhs, .none });
21822216}
21832217
......@@ -5166,7 +5200,7 @@ fn genSetReg(self: *Self, ty: Type, reg: Register, mcv: MCValue) InnerError!void
51665200 if (!self.wantSafety())
51675201 return; // The already existing value will do just fine.
51685202 // Write the debug undefined value.
5169 switch (reg.size()) {
5203 switch (registerAlias(reg, abi_size).size()) {
51705204 8 => return self.genSetReg(ty, reg, .{ .immediate = 0xaa }),
51715205 16 => return self.genSetReg(ty, reg, .{ .immediate = 0xaaaa }),
51725206 32 => return self.genSetReg(ty, reg, .{ .immediate = 0xaaaaaaaa }),
......@@ -5303,7 +5337,7 @@ fn genSetReg(self: *Self, ty: Type, reg: Register, mcv: MCValue) InnerError!void
53035337 _ = try self.addInst(.{
53045338 .tag = .mov,
53055339 .ops = (Mir.Ops{
5306 .reg1 = reg.to64(),
5340 .reg1 = registerAlias(reg, abi_size),
53075341 .reg2 = reg.to64(),
53085342 .flags = 0b01,
53095343 }).encode(),
......@@ -5316,7 +5350,7 @@ fn genSetReg(self: *Self, ty: Type, reg: Register, mcv: MCValue) InnerError!void
53165350 _ = try self.addInst(.{
53175351 .tag = .mov,
53185352 .ops = (Mir.Ops{
5319 .reg1 = reg,
5353 .reg1 = registerAlias(reg, abi_size),
53205354 .flags = 0b01,
53215355 }).encode(),
53225356 .data = .{ .imm = @truncate(u32, x) },
......@@ -5343,8 +5377,8 @@ fn genSetReg(self: *Self, ty: Type, reg: Register, mcv: MCValue) InnerError!void
53435377 _ = try self.addInst(.{
53445378 .tag = .mov,
53455379 .ops = (Mir.Ops{
5346 .reg1 = reg,
5347 .reg2 = reg,
5380 .reg1 = registerAlias(reg, abi_size),
5381 .reg2 = reg.to64(),
53485382 .flags = 0b01,
53495383 }).encode(),
53505384 .data = .{ .imm = 0 },
test/behavior/basic.zig-7
......@@ -382,7 +382,6 @@ fn hereIsAnOpaqueType(ptr: *OpaqueA) *OpaqueA {
382382test "take address of parameter" {
383383 if (builtin.zig_backend == .stage2_aarch64) return error.SkipZigTest;
384384 if (builtin.zig_backend == .stage2_arm) return error.SkipZigTest;
385 if (builtin.zig_backend == .stage2_x86_64) return error.SkipZigTest;
386385
387386 try testTakeAddressOfParameter(12.34);
388387}
......@@ -408,7 +407,6 @@ fn testPointerToVoidReturnType2() *const void {
408407test "array 2D const double ptr" {
409408 if (builtin.zig_backend == .stage2_aarch64) return error.SkipZigTest;
410409 if (builtin.zig_backend == .stage2_arm) return error.SkipZigTest;
411 if (builtin.zig_backend == .stage2_x86_64) return error.SkipZigTest;
412410 if (builtin.zig_backend == .stage2_wasm) return error.SkipZigTest; // TODO
413411
414412 const rect_2d_vertexes = [_][1]f32{
......@@ -421,7 +419,6 @@ test "array 2D const double ptr" {
421419test "array 2D const double ptr with offset" {
422420 if (builtin.zig_backend == .stage2_aarch64) return error.SkipZigTest;
423421 if (builtin.zig_backend == .stage2_arm) return error.SkipZigTest;
424 if (builtin.zig_backend == .stage2_x86_64) return error.SkipZigTest;
425422 if (builtin.zig_backend == .stage2_wasm) return error.SkipZigTest;
426423
427424 const rect_2d_vertexes = [_][2]f32{
......@@ -434,7 +431,6 @@ test "array 2D const double ptr with offset" {
434431test "array 3D const double ptr with offset" {
435432 if (builtin.zig_backend == .stage2_aarch64) return error.SkipZigTest;
436433 if (builtin.zig_backend == .stage2_arm) return error.SkipZigTest;
437 if (builtin.zig_backend == .stage2_x86_64) return error.SkipZigTest;
438434 if (builtin.zig_backend == .stage2_wasm) return error.SkipZigTest; // TODO
439435
440436 const rect_3d_vertexes = [_][2][2]f32{
......@@ -519,7 +515,6 @@ var global_foo: *i32 = undefined;
519515test "peer result location with typed parent, runtime condition, comptime prongs" {
520516 if (builtin.zig_backend == .stage2_aarch64) return error.SkipZigTest;
521517 if (builtin.zig_backend == .stage2_arm) return error.SkipZigTest;
522 if (builtin.zig_backend == .stage2_x86_64) return error.SkipZigTest;
523518
524519 const S = struct {
525520 fn doTheTest(arg: i32) i32 {
......@@ -620,7 +615,6 @@ test "self reference through fn ptr field" {
620615test "global variable initialized to global variable array element" {
621616 if (builtin.zig_backend == .stage2_aarch64) return error.SkipZigTest;
622617 if (builtin.zig_backend == .stage2_arm) return error.SkipZigTest;
623 if (builtin.zig_backend == .stage2_x86_64) return error.SkipZigTest;
624618
625619 if (builtin.zig_backend == .stage2_wasm) return error.SkipZigTest;
626620
......@@ -655,7 +649,6 @@ test "global constant is loaded with a runtime-known index" {
655649test "multiline string literal is null terminated" {
656650 if (builtin.zig_backend == .stage2_aarch64) return error.SkipZigTest;
657651 if (builtin.zig_backend == .stage2_arm) return error.SkipZigTest;
658 if (builtin.zig_backend == .stage2_x86_64) return error.SkipZigTest;
659652
660653 const s1 =
661654 \\one
test/behavior/eval.zig+1
......@@ -424,6 +424,7 @@ test "f64 at compile time is lossy" {
424424}
425425
426426test {
427 if (builtin.zig_backend != .stage1 and builtin.os.tag == .macos) return error.SkipZigTest;
427428 comptime try expect(@as(f128, 1 << 113) == 10384593717069655257060992658440192);
428429}
429430