authorgravatar for andrew@ziglang.orgAndrew Kelley <andrew@ziglang.org> 2026-06-04 00:02:36-07:00
committergravatar for andrew@ziglang.orgAndrew Kelley <andrew@ziglang.org> 2026-06-04 00:06:17-07:00
logac9f020c878c6397cee0f476b0afd5ce38178374
treede711555dd72e54465cd78f29053138cb825cdb9
parentb0c17a6becae820624da8cf41c880184ce0a104e

StaticStringMap: failing unit test

getIndex doesn't return an index based on the input, it returns an internal index to the generated sorted array this makes it unfit to be public

1 files changed, 7 insertions(+), 7 deletions(-)

lib/std/static_string_map.zig+7-7
......@@ -240,7 +240,7 @@ pub fn StaticStringMapWithEql(
240240 return self.kvs.values[self.getIndex(str) orelse return null];
241241 }
242242
243 pub fn getIndex(self: Self, str: []const u8) ?usize {
243 fn getIndex(self: Self, str: []const u8) ?usize {
244244 const kvs = self.kvs.*;
245245 if (kvs.len == 0)
246246 return null;
......@@ -583,13 +583,13 @@ test "sorting kvs doesn't exceed eval branch quota" {
583583}
584584
585585test "initEnum" {
586 const map = StaticStringMap(void).initEnum(TestEnum);
586 const UnsortedEnum = enum { BB, A, CCC, DDD };
587 const map = StaticStringMap(void).initEnum(UnsortedEnum);
587588 try testing.expect(map.has("A"));
588589 try testing.expect(!map.has("a"));
589 try testing.expectEqual(0, map.getIndex("A"));
590 try testing.expectEqual(1, map.getIndex("B"));
591 try testing.expectEqual(2, map.getIndex("C"));
592 try testing.expectEqual(3, map.getIndex("D"));
593 try testing.expectEqual(4, map.getIndex("E"));
590 try testing.expectEqual(0, map.getIndex("BB"));
591 try testing.expectEqual(1, map.getIndex("A"));
592 try testing.expectEqual(2, map.getIndex("CCC"));
593 try testing.expectEqual(3, map.getIndex("DDD"));
594594 try testing.expectEqual(null, map.getIndex("F"));
595595}