Commit ae65c236c55a1e22e63bb9f03c1ff925268646f1 | zig

author	Andrew Kelley <andrew@ziglang.org> 2019-08-26 15:24:24-04:00
committer	Andrew Kelley <andrew@ziglang.org> 2019-08-26 15:24:24-04:00
log	ae65c236c55a1e22e63bb9f03c1ff925268646f1
tree	989ebc145c52256ad2bca5a454f7fa2da278a529
parent	d316f704501ff7fc809fdfb082226031ef875046
signature	Commit is signed but in an unrecognized format.

fix regression with global variable assignment...

...with optional unwrapping with var initialized to undefined

3 files changed, 38 insertions(+), 23 deletions(-)

src
- codegen.cpp
- ir.cpp
test
- stage1
  - behavior
    misc.zig

src/codegen.cpp+2

...	@@ -3527,6 +3527,8 @@ static LLVMValueRef ir_render_store_ptr(CodeGen g, IrExecutable executable, Ir	...	@@ -3527,6 +3527,8 @@ static LLVMValueRef ir_render_store_ptr(CodeGen g, IrExecutable executable, Ir
3527	}	3527	}
3528		3528
3529	static LLVMValueRef ir_render_var_ptr(CodeGen g, IrExecutable executable, IrInstructionVarPtr *instruction) {	3529	static LLVMValueRef ir_render_var_ptr(CodeGen g, IrExecutable executable, IrInstructionVarPtr *instruction) {
		3530	if (instruction->base.value.special != ConstValSpecialRuntime)
		3531	return ir_llvm_value(g, &instruction->base);
3530	ZigVar *var = instruction->var;	3532	ZigVar *var = instruction->var;
3531	if (type_has_bits(var->var_type)) {	3533	if (type_has_bits(var->var_type)) {
3532	assert(var->value_ref);	3534	assert(var->value_ref);

src/ir.cpp+21-23

 @@ -15259,23 +15259,25 @@ static IrInstruction *ir_get_var_ptr(IrAnalyze *ira, IrInstruction *instruction,
     bool comptime_var_mem = ir_get_var_is_comptime(var);
     bool linkage_makes_it_runtime = var->decl_node->data.variable_declaration.is_extern;
-    bool is_const = var->src_is_const;
     bool is_volatile = false;
+    IrInstruction *result = ir_build_var_ptr(&ira->new_irb,
+            instruction->scope, instruction->source_node, var);
+    result->value.type = get_pointer_to_type_extra(ira->codegen, var->var_type,
+            var->src_is_const, is_volatile, PtrLenSingle, var->align_bytes, 0, 0, false);
     if (linkage_makes_it_runtime)
         goto no_mem_slot;
     if (value_is_comptime(var->const_value)) {
         mem_slot = var->const_value;
-    } else {
+    } else if (var->mem_slot_index != SIZE_MAX && (comptime_var_mem || var->gen_is_const)) {
-        if (var->mem_slot_index != SIZE_MAX && (comptime_var_mem || var->gen_is_const)) {
+        // find the relevant exec_context
-            // find the relevant exec_context
+        assert(var->owner_exec != nullptr);
-            assert(var->owner_exec != nullptr);
+        assert(var->owner_exec->analysis != nullptr);
-            assert(var->owner_exec->analysis != nullptr);
+        IrExecContext *exec_context = &var->owner_exec->analysis->exec_context;
-            IrExecContext *exec_context = &var->owner_exec->analysis->exec_context;
+        assert(var->mem_slot_index < exec_context->mem_slot_list.length);
-            assert(var->mem_slot_index < exec_context->mem_slot_list.length);
+        mem_slot = exec_context->mem_slot_list.at(var->mem_slot_index);
-            mem_slot = exec_context->mem_slot_list.at(var->mem_slot_index);
-        }
     }
     if (mem_slot != nullptr) {
 @@ -15294,8 +15296,11 @@ static IrInstruction *ir_get_var_ptr(IrAnalyze *ira, IrInstruction *instruction,
                     assert(!comptime_var_mem);
                     ptr_mut = ConstPtrMutRuntimeVar;
                 }
-                return ir_get_const_ptr(ira, instruction, mem_slot, var->var_type,
+                result->value.special = ConstValSpecialStatic;
-                        ptr_mut, is_const, is_volatile, var->align_bytes);
+                result->value.data.x_ptr.mut = ptr_mut;
+                result->value.data.x_ptr.special = ConstPtrSpecialRef;
+                result->value.data.x_ptr.data.ref.pointee = mem_slot;
+                return result;
             }
         }
         zig_unreachable();
 @@ -15303,15 +15308,10 @@ static IrInstruction *ir_get_var_ptr(IrAnalyze *ira, IrInstruction *instruction,
 no_mem_slot:
-    IrInstruction *var_ptr_instruction = ir_build_var_ptr(&ira->new_irb,
-            instruction->scope, instruction->source_node, var);
-    var_ptr_instruction->value.type = get_pointer_to_type_extra(ira->codegen, var->var_type,
-            var->src_is_const, is_volatile, PtrLenSingle, var->align_bytes, 0, 0, false);
     bool in_fn_scope = (scope_fn_entry(var->parent_scope) != nullptr);
-    var_ptr_instruction->value.data.rh_ptr = in_fn_scope ? RuntimeHintPtrStack : RuntimeHintPtrNonStack;
+    result->value.data.rh_ptr = in_fn_scope ? RuntimeHintPtrStack : RuntimeHintPtrNonStack;
-    return var_ptr_instruction;
+    return result;
 }
 // This function is called when a comptime value becomes accessible at runtime.
 @@ -17317,8 +17317,7 @@ static IrInstruction *ir_analyze_decl_ref(IrAnalyze *ira, IrInstruction *source_
         case TldIdCompTime:
         case TldIdUsingNamespace:
             zig_unreachable();
-        case TldIdVar:
+        case TldIdVar: {
-        {
             TldVar *tld_var = (TldVar *)tld;
             ZigVar *var = tld_var->var;
             if (var == nullptr) {
 @@ -17330,8 +17329,7 @@ static IrInstruction *ir_analyze_decl_ref(IrAnalyze *ira, IrInstruction *source_
             return ir_get_var_ptr(ira, source_instruction, var);
         }
-        case TldIdFn:
+        case TldIdFn: {
-        {
             TldFn *tld_fn = (TldFn *)tld;
             ZigFn *fn_entry = tld_fn->fn_entry;
             assert(fn_entry->type_entry);

test/stage1/behavior/misc.zig+15

...	@@ -706,3 +706,18 @@ test "result location zero sized array inside struct field implicit cast to slic	...	@@ -706,3 +706,18 @@ test "result location zero sized array inside struct field implicit cast to slic
706	var foo = E{ .entries = [_]u32{} };	706	var foo = E{ .entries = [_]u32{} };
707	expect(foo.entries.len == 0);	707	expect(foo.entries.len == 0);
708	}	708	}
		709
		710	var global_foo: *i32 = undefined;
		711
		712	test "global variable assignment with optional unwrapping with var initialized to undefined" {
		713	const S = struct {
		714	var data: i32 = 1234;
		715	fn foo() ?*i32 {
		716	return &data;
		717	}
		718	};
		719	global_foo = S.foo() orelse {
		720	@panic("bad");
		721	};
		722	expect(global_foo.* == 1234);
		723	}