authorgravatar for mlugg@mlugg.co.ukMatthew Lugg <mlugg@mlugg.co.uk> 2026-01-06 11:13:13+00:00
committergravatar for mlugg@mlugg.co.ukMatthew Lugg <mlugg@mlugg.co.uk> 2026-01-06 11:15:47+00:00
logbe0a77efd2aad5108d3357914cbc71f560ea0161
tree75a9e10eefd3fd54511ff249600ba895ca0941ec
parent073ef0f393ff4297e8d48a72f30a605c2d272289
signaturelock-open Commit is signed but in an unrecognized format.

std: re-enable some disabled tests

I believe these tests may have been flaky as a result of the bug fixed in the previous commit. A big hint is that they were all crashing with SIGSEGV with no stack trace. I suspect that some lingering SIGIOs from cancelations were being delivered to a thread after its `munmap` call, which was happening because the test runner called `Io.Threaded.deinit` to cause all of the (detached) worker threads to exit. If this passes, I'll re-run the x86_64-linux CI jobs on this commit a few times before merge to try and be sure there are no lingering failures. Resolves: https://codeberg.org/ziglang/zig/issues/30096 Resolves: https://codeberg.org/ziglang/zig/issues/30592 Resolves: https://codeberg.org/ziglang/zig/issues/30682

2 files changed, 0 insertions(+), 6 deletions(-)

lib/std/Io/test.zig-4
......@@ -254,8 +254,6 @@ test "Group.cancel" {
254254}
255255
256256test "Group.concurrent" {
257 if (builtin.os.tag == .linux and !builtin.link_libc) return error.SkipZigTest; // https://codeberg.org/ziglang/zig/issues/30096
258
259257 const io = testing.io;
260258
261259 var group: Io.Group = .init;
......@@ -421,8 +419,6 @@ test "Event" {
421419}
422420
423421test "recancel" {
424 if (builtin.os.tag == .linux and !builtin.link_libc) return error.SkipZigTest; // https://codeberg.org/ziglang/zig/issues/30592
425
426422 const global = struct {
427423 fn worker(io: Io) Io.Cancelable!void {
428424 var dummy_event: Io.Event = .unset;
lib/std/crypto/argon2.zig-2
......@@ -907,8 +907,6 @@ test "kdf" {
907907}
908908
909909test "phc format hasher" {
910 if (true) return error.SkipZigTest; // https://codeberg.org/ziglang/zig/issues/30682
911
912910 const allocator = std.testing.allocator;
913911 const password = "testpass";
914912 const io = std.testing.io;