| author |  Andrew Kelley <andrew@ziglang.org> 2022-08-22 11:46:54-07:00 |
| committer | Andrew Kelley <andrew@ziglang.org> 2022-08-22 11:46:54-07:00 |
| log | c955379504d4866f9c474c50317b2a0da18ee631 |
| tree | 4dd89f89f346d2a1f435efff54cd27d33485f2c5 |
| parent | 1a32f2a7f40328799537cc94240a57054a1275bc |
Revert "test_runner: workaround #1923, isolating error traces in tests"
This reverts commit 1a32f2a7f40328799537cc94240a57054a1275bc.
Sorry, this workaround is not welcome. Instead, please solve the actual
issue by doing the accepted behavior in the compiler itself:
> in a catch or else (handling a returned error), if the block does not
> try or return error.xyz, set the index to 0
This also applies to if statements, such as the one that test runner is
doing just above this hack.1 files changed, 0 insertions(+), 7 deletions(-)
lib/test_runner.zig-7
| ... | ... | @@ -96,13 +96,6 @@ pub fn main() void { |
| 96 | 96 | test_node.end(); |
| 97 | 97 | }, |
| 98 | 98 | } |
| 99 | // Workaround issue #1923 by clearing error stack traces between tests | |
| 100 | // | |
| 101 | // This is not a true fix, but helps isolate errors to the tests where they | |
| 102 | // originate instead of confusing them all together | |
| 103 | if (@errorReturnTrace()) |trace| { | |
| 104 | trace.index = 0; | |
| 105 | } | |
| 106 | 99 | } |
| 107 | 100 | root_node.end(); |
| 108 | 101 | if (ok_count == test_fn_list.len) { |