Commit d2d8b969a1674a6583292631ca7decc94cb56145 | zig

author	pentuppup <pentuppup@noreply.codeberg.org> 2025-09-10 11:59:47-04:00
committer	Andrew Kelley <andrew@ziglang.org> 2026-01-08 05:05:39+01:00
log	d2d8b969a1674a6583292631ca7decc94cb56145
tree	a31f406525e313829d841028f69204ff8be042cb
parent	cdaf27931412b7806e568a41de1ac1eea4c46cfa

fix redundant safety checks being emitted for slicing

1 files changed, 14 insertions(+), 9 deletions(-)

src
- Sema.zig

src/Sema.zig+14-9

 @@ -32272,9 +32272,15 @@ fn analyzeSlice(
     var runtime_src: ?LazySrcLoc = null;
     // requirement: start <= end
-    if (try sema.resolveDefinedValue(block, end_src, end)) |end_val| {
+    if (try sema.resolveDefinedValue(block, start_src, start)) |start_val| {
-        if (try sema.resolveDefinedValue(block, start_src, start)) |start_val| {
+        if (try sema.compareAll(start_val, .eq, .zero_usize, .usize)) {
-            if (!by_length and !(try sema.compareAll(start_val, .lte, end_val, .usize))) {
+            checked_start_lte_end = true;
+        }
+        if (try sema.resolveDefinedValue(block, end_src, end)) |end_val| {
+            if (!checked_start_lte_end and
+                !by_length and
+                !(try sema.compareAll(start_val, .lte, end_val, .usize)))
+            {
                 return sema.fail(
                     block,
                     start_src,
 @@ -32330,10 +32336,10 @@ fn analyzeSlice(
                 runtime_src = ptr_src;
             }
         } else {
-            runtime_src = start_src;
+            runtime_src = end_src;
         }
     } else {
-        runtime_src = end_src;
+        runtime_src = start_src;
     }
     if (!checked_start_lte_end and block.wantSafety() and !block.isComptime()) {
 @@ -32396,7 +32402,9 @@ fn analyzeSlice(
                     else
                         end;
-                    try sema.addSafetyCheckIndexOob(block, src, actual_end, actual_len, .cmp_lte);
+                    if (try sema.resolveDefinedValue(block, src, actual_len) == null or
+                        try sema.resolveDefinedValue(block, src, actual_end) == null)
+                        try sema.addSafetyCheckIndexOob(block, src, actual_end, actual_len, .cmp_lte);
                 }
                 // requirement: result[new_len] == slice_sentinel
 @@ -32461,9 +32469,6 @@ fn analyzeSlice(
                 end;
             try sema.addSafetyCheckIndexOob(block, src, actual_end, len_inst, .cmp_lte);
         }
-        // requirement: start <= end
-        try sema.addSafetyCheckIndexOob(block, src, start, end, .cmp_lte);
     }
     const result = try block.addInst(.{
         .tag = .slice,