Commit e3e9c7c33c029368ad644619ed20f3d7cccd3a47 | zig

author	Andrew Kelley <andrew@ziglang.org> 2026-01-05 14:17:44-08:00
committer	Andrew Kelley <andrew@ziglang.org> 2026-01-07 11:03:36-08:00
log	e3e9c7c33c029368ad644619ed20f3d7cccd3a47
tree	4f4939db9c21513ab523ee8f6f11ea735a2ab93d
parent	2f639a45b401998a113174829839110ba8970dfa

std.Build.Step.Compile: take advantage of std lib atomic files

1 files changed, 19 insertions(+), 8 deletions(-)

lib
- std
  - Build
    Step
    Compile.zig

lib/std/Build/Step/Compile.zig+19-8

 @@ -1706,18 +1706,29 @@ fn getZigArgs(compile: *Compile, fuzz: bool) ![][]const u8 {
             // The args file is already present from a previous run.
         } else |err| switch (err) {
             error.FileNotFound => {
-                try b.cache_root.handle.createDirPath(io, "tmp");
+                var af = b.cache_root.handle.createFileAtomic(io, args_file, .{
-                const rand_int = std.crypto.random.int(u64);
+                    .replace = false,
-                const tmp_path = "tmp" ++ fs.path.sep_str ++ std.fmt.hex(rand_int);
+                    .make_path = true,
-                try b.cache_root.handle.writeFile(io, .{ .sub_path = tmp_path, .data = args });
+                }) catch |e| return step.fail("failed creating tmp args file {f}{s}: {t}", .{
-                defer b.cache_root.handle.deleteFile(io, tmp_path) catch {
+                    b.cache_root, args_file, e,
-                    // It's fine if the temporary file can't be cleaned up.
+                });
+                defer af.deinit(io);
+                af.file.writeStreamingAll(io, args) catch |e| {
+                    return step.fail("failed writing args data to tmp file {f}{s}: {t}", .{
+                        b.cache_root, args_file, e,
+                    });
                 };
-                b.cache_root.handle.rename(tmp_path, b.cache_root.handle, args_file, io) catch |rename_err| switch (rename_err) {
+                // Note we can't clean up this file, not even after build
+                // success, because that might interfere with another build
+                // process that needs the same file.
+                af.link(io) catch |e| switch (e) {
                     error.PathAlreadyExists => {
                         // The args file was created by another concurrent build process.
                     },
-                    else => |other_err| return other_err,
+                    else => |other_err| return step.fail("failed linking tmp file {f}{s}: {t}", .{
+                        b.cache_root, args_file, other_err,
+                    }),
                 };
             },
             else => |other_err| return other_err,