authorgravatar for r00ster91@proton.meWooster <r00ster91@proton.me> 2023-05-02 04:43:06+02:00
committergravatar for r00ster91@proton.meWooster <r00ster91@proton.me> 2023-05-02 04:43:06+02:00
logeab4cd7a66803809ca94a03adc8bbdefc87bd60b
treec91b0c229c4b7c7471419c4328b71ab75a9f44ff
parent6f1336a50c6c2d9498bb9b3fb291cb305688c1b9

autodoc: type "?" instead of opening help modal if search selected

The question mark character can appear in identifiers as part of the `@"syntax"` so we should allow typing it. Now, when the search is selected, "?" is entered instead. It also shouldn't be that common in general for the user to want to open the help modal.

1 files changed, 7 insertions(+), 1 deletions(-)

lib/docs/main.js+7-1
......@@ -127,16 +127,20 @@ const NAV_MODES = {
127127 window.guideSearch = guidesSearchIndex;
128128 parseGuides();
129129
130
130 // identifiers can contain '?' so we want to allow typing
131 // the question mark when the search is focused instead of toggling the help modal
132 let canToggleHelpModal = true;
131133
132134 domSearch.disabled = false;
133135 domSearch.addEventListener("keydown", onSearchKeyDown, false);
134136 domSearch.addEventListener("focus", ev => {
135137 domSearchPlaceholder.classList.add("hidden");
138 canToggleHelpModal = false;
136139 });
137140 domSearch.addEventListener("blur", ev => {
138141 if (domSearch.value.length == 0)
139142 domSearchPlaceholder.classList.remove("hidden");
143 canToggleHelpModal = true;
140144 });
141145 domSectSearchAllResultsLink.addEventListener('click', onClickSearchShowAllResults, false);
142146 function onClickSearchShowAllResults(ev) {
......@@ -4044,6 +4048,8 @@ function addDeclToSearchResults(decl, declIndex, modNames, item, list, stack) {
40444048 }
40454049 break;
40464050 case "?":
4051 if (!canToggleHelpModal) break;
4052
40474053 // toggle the help modal
40484054 if (!domHelpModal.classList.contains("hidden")) {
40494055 onEscape(ev);