authorgravatar for jtwambolt@gmail.comJackson Wambolt <jtwambolt@gmail.com> 2025-07-30 15:48:38-05:00
committergravatar for noreply@github.comGitHub <noreply@github.com> 2025-07-30 20:48:38+00:00
logeb1a4970dae76b49fe8cf1fa792a571cfebed86d
treed245cbd64083bd0b356da2f64b7ee4eb8fc8a6f1
parent389ccf692a56411186e32b25e1a19442542c9f30
signaturebadge-check Signed by PGP key B5690EEEBB952194

Sema: check min/max operand types

2 files changed, 42 insertions(+), 0 deletions(-)

src/Sema.zig+1
...@@ -24609,6 +24609,7 @@ fn analyzeMinMax(...@@ -24609,6 +24609,7 @@ fn analyzeMinMax(
24609 } else {24609 } else {
24610 for (operands[1..], operand_srcs[1..]) |operand, operand_src| {24610 for (operands[1..], operand_srcs[1..]) |operand, operand_src| {
24611 const operand_ty = sema.typeOf(operand);24611 const operand_ty = sema.typeOf(operand);
24612 try sema.checkNumericType(block, operand_src, operand_ty);
24612 if (operand_ty.zigTypeTag(zcu) == .vector) {24613 if (operand_ty.zigTypeTag(zcu) == .vector) {
24613 return sema.failWithOwnedErrorMsg(block, msg: {24614 return sema.failWithOwnedErrorMsg(block, msg: {
24614 const msg = try sema.errMsg(operand_srcs[0], "expected vector, found '{f}'", .{first_operand_ty.fmt(pt)});24615 const msg = try sema.errMsg(operand_srcs[0], "expected vector, found '{f}'", .{first_operand_ty.fmt(pt)});
test/cases/compile_errors/minmax_nonnumeric_operand.zig created+41
...@@ -0,0 +1,41 @@
1// zig fmt: off
2comptime { _ = @min(0, u32); } // type
3comptime { _ = @max(0, {}); } // void
4comptime { _ = @min(0, false); } // boolean
5comptime { _ = @min(0, &@as(u8, 0)); } // pointer
6comptime { _ = @max(0, [0]u8{}); } // array
7comptime { _ = @min(0, Struct{}); } // struct
8comptime { _ = @max(0, null); } // null
9comptime { _ = @min(0, @as(?u8, 0)); } // nullable
10comptime { _ = @max(0, @as(error{}!u8, 0)); } // error union
11comptime { _ = @min(0, error.Foo); } // error set
12comptime { _ = @max(0, Enum.foo); } // enum
13comptime { _ = @min(0, Union{ .foo = {} }); } // union
14comptime { _ = @max(0, struct { fn func() u8 { return 42; }}.func); }
15comptime { _ = @max(0, .foo); } // enum literal
16
17const Struct = struct {};
18const Enum = enum { foo };
19const Union = union { foo: void };
20
21// error
22// backend=stage2
23// target=native
24//
25// :2:24: error: expected number, found 'type'
26// :3:24: error: expected number, found 'void'
27// :4:24: error: expected number, found 'bool'
28// :5:24: error: expected number, found '*const u8'
29// :6:29: error: expected number, found '[0]u8'
30// :7:30: error: expected number, found 'tmp.Struct'
31// :17:16: note: struct declared here
32// :8:24: error: expected number, found '@TypeOf(null)'
33// :9:24: error: expected number, found '?u8'
34// :10:24: error: expected number, found 'error{}!u8'
35// :11:24: error: expected number, found 'error{Foo}'
36// :12:28: error: expected number, found 'tmp.Enum'
37// :18:14: note: enum declared here
38// :13:29: error: expected number, found 'tmp.Union'
39// :19:15: note: union declared here
40// :14:61: error: expected number, found 'fn () u8'
41// :15:25: error: expected number, found '@Type(.enum_literal)'