authorgravatar for andrew@ziglang.orgAndrew Kelley <andrew@ziglang.org> 2023-02-27 20:42:13-07:00
committergravatar for andrew@ziglang.orgAndrew Kelley <andrew@ziglang.org> 2023-02-27 20:42:13-07:00
logf33af7af40faccc05f66417f1ba5caa4eb158769
treead6a3924010d283d998d47f1f4a6a5510d129076
parentf6c934677315665c140151b8dd28a56f948205e2

delete a subtly incorrect Haiku collectOutput implementation

It's not OK to half-ass this function. Please implement it correctly, or not at all.

1 files changed, 1 insertions(+), 7 deletions(-)

lib/std/child_process.zig+1-7
...@@ -210,13 +210,7 @@ pub const ChildProcess = struct {...@@ -210,13 +210,7 @@ pub const ChildProcess = struct {
210 ) !void {210 ) !void {
211 debug.assert(child.stdout_behavior == .Pipe);211 debug.assert(child.stdout_behavior == .Pipe);
212 debug.assert(child.stderr_behavior == .Pipe);212 debug.assert(child.stderr_behavior == .Pipe);
213 if (builtin.os.tag == .haiku) {213 if (builtin.os.tag == .windows) {
214 const stdout_in = child.stdout.?.reader();
215 const stderr_in = child.stderr.?.reader();
216
217 try stdout_in.readAllArrayList(stdout, max_output_bytes);
218 try stderr_in.readAllArrayList(stderr, max_output_bytes);
219 } else if (builtin.os.tag == .windows) {
220 try collectOutputWindows(child, stdout, stderr, max_output_bytes);214 try collectOutputWindows(child, stdout, stderr, max_output_bytes);
221 } else {215 } else {
222 try collectOutputPosix(child, stdout, stderr, max_output_bytes);216 try collectOutputPosix(child, stdout, stderr, max_output_bytes);