authorgravatar for jacobly@ziglang.orgJacob Young <jacobly@ziglang.org> 2022-11-28 04:37:47-05:00
committergravatar for andrew@ziglang.orgAndrew Kelley <andrew@ziglang.org> 2023-01-09 14:44:09-07:00
log2f11de4f514d9775c7713313f2dcfa7343cd2bf2
treee3c3bcc77fe3933fb48cc345537aa14901c249d1
parente5d76176b9b18eefd8136f51c0188e5c57631e62

std.big.int.Mutable: fix set(@as(DoubleLimb, 0))

Previously, this would set len to 1 but fail to initialize any limbs.

2 files changed, 14 insertions(+), 2 deletions(-)

lib/std/math/big/int.zig+6-2
......@@ -238,12 +238,14 @@ pub const Mutable = struct {
238238 self.limbs[0] = w_value;
239239 } else {
240240 var i: usize = 0;
241 while (w_value != 0) : (i += 1) {
241 while (true) : (i += 1) {
242242 self.limbs[i] = @truncate(Limb, w_value);
243243
244244 // TODO: shift == 64 at compile-time fails. Fails on u128 limbs.
245245 w_value >>= limb_bits / 2;
246246 w_value >>= limb_bits / 2;
247
248 if (w_value == 0) break;
247249 }
248250 }
249251 },
......@@ -256,11 +258,13 @@ pub const Mutable = struct {
256258 const mask = (1 << limb_bits) - 1;
257259
258260 comptime var i = 0;
259 inline while (w_value != 0) : (i += 1) {
261 inline while (true) : (i += 1) {
260262 self.limbs[i] = w_value & mask;
261263
262264 w_value >>= limb_bits / 2;
263265 w_value >>= limb_bits / 2;
266
267 if (w_value == 0) break;
264268 }
265269 }
266270 },
lib/std/math/big/int_test.zig+8
......@@ -69,6 +69,14 @@ test "big.int set negative minimum" {
6969 try testing.expect((try a.to(i64)) == minInt(i64));
7070}
7171
72test "big.int set double-width maximum then zero" {
73 var a = try Managed.initSet(testing.allocator, maxInt(DoubleLimb));
74 defer a.deinit();
75 try a.set(@as(DoubleLimb, 0));
76
77 try testing.expectEqual(@as(DoubleLimb, 0), try a.to(DoubleLimb));
78}
79
7280test "big.int to target too small error" {
7381 var a = try Managed.initSet(testing.allocator, 0xffffffff);
7482 defer a.deinit();