Commit 9aa93a045ebbf7d5c6349eb41e99ca516ab9ba65 | zig

author	Matthew Lugg <mlugg@mlugg.co.uk> 2026-06-21 14:52:18+01:00
committer	Andrew Kelley <andrew@ziglang.org> 2026-06-21 20:31:19+02:00
log	9aa93a045ebbf7d5c6349eb41e99ca516ab9ba65
tree	c95ca70d3ce8427b9b40a739e2447a5c55c17a5a
parent	b9153f3f1d5f29a3a90779c2a5026fb52c719ac0

Lld: don't include shared libraries in static archives

The only reason this wasn't causing more problems is because both LLD
and our old ELF linker both ignore bogus archive entries! `Elf2`, OTOH,
emits an error when it encounters such an entry, which is how this was
spotted.

1 files changed, 8 insertions(+), 6 deletions(-)

src
- link
  - Lld.zig

src/link/Lld.zig+8-6

 @@ -304,14 +304,16 @@ fn linkAsArchive(lld: *Lld, arena: Allocator) !void {
     // insight as to what's going on here you can read that function body which is more
     // well-commented.
-    const link_inputs = comp.link_inputs;
     var object_files: std.ArrayList([*:0]const u8) = .empty;
-    try object_files.ensureUnusedCapacity(arena, link_inputs.len);
+    try object_files.ensureUnusedCapacity(arena, comp.link_inputs.len);
-    for (link_inputs) |input| {
+    for (comp.link_inputs) |input| switch (input) {
-        object_files.appendAssumeCapacity(try input.path().?.toStringZ(arena));
+        .res, .dso, .dso_exact => {}, // shared libraries should not be included in static archives
-    }
+        .object, .archive => {
+            const path = try input.path().?.toStringZ(arena);
+            object_files.appendAssumeCapacity(path);
+        },
+    };
     try object_files.ensureUnusedCapacity(arena, comp.c_objects.items.len +
         comp.win32_resources.items.len + 2);